No description
Find a file
Javier Martinez Canillas 0fac5f8fb1 video: fbdev: vesafb: Fix a use-after-free due early fb_info cleanup
[ Upstream commit acde4003ef ]

Commit b3c9a924aa ("fbdev: vesafb: Cleanup fb_info in .fb_destroy rather
than .remove") fixed a use-after-free error due the vesafb driver freeing
the fb_info in the .remove handler instead of doing it in .fb_destroy.

This can happen if the .fb_destroy callback is executed after the .remove
callback, since the former tries to access a pointer freed by the latter.

But that change didn't take into account that another possible scenario is
that .fb_destroy is called before the .remove callback. For example, if no
process has the fbdev chardev opened by the time the driver is removed.

If that's the case, fb_info will be freed when unregister_framebuffer() is
called, making the fb_info pointer accessed in vesafb_remove() after that
to no longer be valid.

To prevent that, move the expression containing the info->par to happen
before the unregister_framebuffer() function call.

Fixes: b3c9a924aa ("fbdev: vesafb: Cleanup fb_info in .fb_destroy rather than .remove")
Reported-by: Pascal Ernster <dri-devel@hardfalcon.net>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Pascal Ernster <dri-devel@hardfalcon.net>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-06-09 10:23:16 +02:00
arch KVM: LAPIC: Drop pending LAPIC timer injection when canceling the timer 2022-06-09 10:23:13 +02:00
block bfq: Allow current waker to defend against a tentative one 2022-06-09 10:23:01 +02:00
certs certs: Add support for using elliptic curve keys for signing modules 2021-08-23 19:55:42 +03:00
crypto crypto: cryptd - Protect per-CPU resource by disabling BH. 2022-06-09 10:23:11 +02:00
Documentation f2fs: support fault injection for dquot_initialize() 2022-06-09 10:23:13 +02:00
drivers video: fbdev: vesafb: Fix a use-after-free due early fb_info cleanup 2022-06-09 10:23:16 +02:00
fs NFS: Further fixes to the writeback error handling 2022-06-09 10:23:15 +02:00
include mailbox: forward the hrtimer if not queued and under a lock 2022-06-09 10:23:12 +02:00
init random: handle latent entropy and command line from random_init() 2022-05-30 09:29:16 +02:00
ipc ipc/mqueue: use get_tree_nodev() in mqueue_get_tree() 2022-06-09 10:23:10 +02:00
kernel dma-direct: don't over-decrypt memory 2022-06-09 10:23:03 +02:00
lib kunit: fix debugfs code to use enum kunit_status, not bool 2022-06-09 10:22:53 +02:00
LICENSES LICENSES/dual/CC-BY-4.0: Git rid of "smart quotes" 2021-07-15 06:31:24 -06:00
mm zsmalloc: fix races between asynchronous zspage free and page migration 2022-06-06 08:43:39 +02:00
net net/smc: postpone sk_refcnt increment in connect() 2022-06-09 10:23:03 +02:00
samples samples: bpf: Don't fail for a missing VMLINUX_BTF when VMLINUX_H is provided 2022-06-09 10:22:55 +02:00
scripts scripts/faddr2line: Fix overlapping text section failures 2022-06-09 10:22:57 +02:00
security lockdown: also lock down previous kgdb use 2022-05-25 09:57:37 +02:00
sound ASoC: atmel-classd: Remove endianness flag on class d component 2022-06-09 10:23:10 +02:00
tools perf jevents: Fix event syntax error caused by ExtSel 2022-06-09 10:23:16 +02:00
usr usr/include/Makefile: add linux/nfc.h to the compile-test coverage 2022-02-01 17:27:15 +01:00
virt KVM: avoid NULL pointer dereference in kvm_dirty_ring_push 2022-04-13 20:59:26 +02:00
.clang-format clang-format: Update with the latest for_each macro list 2021-05-12 23:32:39 +02:00
.cocciconfig
.get_maintainer.ignore Opt out of scripts/get_maintainer.pl 2019-05-16 10:53:40 -07:00
.gitattributes .gitattributes: use 'dts' diff driver for dts files 2019-12-04 19:44:11 -08:00
.gitignore .gitignore: ignore only top-level modules.builtin 2021-05-02 00:43:35 +09:00
.mailmap mailmap: add Andrej Shadura 2021-10-18 20:22:03 -10:00
COPYING COPYING: state that all contributions really are covered by this file 2020-02-10 13:32:20 -08:00
CREDITS MAINTAINERS: Move Daniel Drake to credits 2021-09-21 08:34:58 +03:00
Kbuild kbuild: rename hostprogs-y/always to hostprogs/always-y 2020-02-04 01:53:07 +09:00
Kconfig kbuild: ensure full rebuild when the compiler is updated 2020-05-12 13:28:33 +09:00
MAINTAINERS MAINTAINERS: add git tree for random.c 2022-05-30 09:28:59 +02:00
Makefile Linux 5.15.45 2022-06-06 08:43:42 +02:00
README Drop all 00-INDEX files from Documentation/ 2018-09-09 15:08:58 -06:00

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.