linux-stable/arch
Niklas Schnelle 18babcfa36 s390/pci: fix max size calculation in zpci_memcpy_toio()
[ Upstream commit 80df7d6af7 ]

The zpci_get_max_write_size() helper is used to determine the maximum
size a PCI store or load can use at a given __iomem address.

For the PCI block store the following restrictions apply:

1. The dst + len must not cross a 4K boundary in the (pseudo-)MMIO space
2. len must not exceed ZPCI_MAX_WRITE_SIZE
3. len must be a multiple of 8 bytes
4. The src address must be double word (8 byte) aligned
5. The dst address must be double word (8 byte) aligned

Otherwise only a normal PCI store which takes its src value from
a register can be used. For these PCI store restriction 1 still applies.
Similarly 1 also applies to PCI loads.

It turns out zpci_max_write_size() instead implements stricter
conditions which prevents PCI block stores from being used where they
can and should be used. In particular instead of conditions 4 and 5 it
wrongly enforces both dst and src to be size aligned. This indirectly
covers condition 1 but also prevents many legal PCI block stores.

On top of the functional shortcomings the zpci_get_max_write_size() is
misnamed as it is used for both read and write size calculations. Rename
it to zpci_get_max_io_size() and implement the listed conditions
explicitly.

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Fixes: cd24834130 ("s390/pci: base support")
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
[agordeev@linux.ibm.com replaced spaces with tabs]
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-01-25 14:52:52 -08:00
..
alpha
arc
arm ARM: 9330/1: davinci: also select PINCTRL 2024-01-25 14:52:49 -08:00
arm64 KVM: arm64: vgic-its: Avoid potential UAF in LPI translation cache 2024-01-25 14:52:49 -08:00
csky
h8300
hexagon
ia64
m68k
microblaze
mips MIPS: Alchemy: Fix an out-of-bound access in db1550_dev_setup() 2024-01-25 14:52:50 -08:00
nds32
nios2
openrisc
parisc
powerpc powerpc/imc-pmu: Add a null pointer check in update_events_in_group() 2024-01-25 14:52:33 -08:00
riscv riscv: Fix module_alloc() that did not reset the linear mapping permissions 2024-01-25 14:52:50 -08:00
s390 s390/pci: fix max size calculation in zpci_memcpy_toio() 2024-01-25 14:52:52 -08:00
sh
sparc
um
x86 x86/kvm: Do not try to disable kvmclock if it was not enabled 2024-01-25 14:52:49 -08:00
xtensa
.gitignore
Kconfig