mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-28 23:24:50 +00:00
Code Issues Releases Wiki Activity
linux-stable/drivers/parport
History
Andy Shevchenko 12280cc708 parport: Clean up resources correctly when parport_register_port() fails 
The smatch warns about uncleaned resources in case the
parport_register_port() fails:

  parport_register_port() warn: '&tmp->full_list' not removed from list

This is indeed an issue introduced when converting code to use
kasprintf(). However, the whole kasprintf() dance in this case
is not needed as dev_set_name() can handle the formatted input
and produces the same result. So, the solution is to delegate
name forming to the dev_set_name() and make device_register()
error path to deal with error handling (via put_device() call).

Fixes: 8d8ae17eb0 ("parport: Use kasprintf() instead of fixed buffer formatting")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202310180809.hepZB9k6-lkp@intel.com/
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231018145948.1367648-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-10-21 23:04:23 +02:00
..
BUGS-parport
daisy.c parport: daisy: Convert DPRINTK to pr_debug 2020-04-23 17:05:38 +02:00
ieee1284.c treewide: Use fallthrough pseudo-keyword 2020-08-23 17:36:59 -05:00
ieee1284_ops.c parport: remove non-zero check on count 2021-08-27 16:18:42 +02:00
Kconfig parport: PC style parport depends on HAS_IOPORT 2023-05-31 19:17:40 +01:00
Makefile parport: remove ax88796 driver 2023-01-16 09:26:06 +01:00
multiface.h
parport_amiga.c module: remove never implemented MODULE_SUPPORTED_DEVICE 2021-03-17 13:16:18 -07:00
parport_atari.c module: remove never implemented MODULE_SUPPORTED_DEVICE 2021-03-17 13:16:18 -07:00
parport_cs.c parport: Convert printk(KERN_<LEVEL> to pr_<level>( 2020-04-23 17:05:37 +02:00
parport_gsc.c parport: gsc: remove DMA leftover code 2023-08-03 14:40:37 +02:00
parport_gsc.h parport: gsc: remove DMA leftover code 2023-08-03 14:40:37 +02:00
parport_ip32.c treewide: remove editor modelines and cruft 2021-05-07 00:26:34 -07:00
parport_mfc3.c module: remove never implemented MODULE_SUPPORTED_DEVICE 2021-03-17 13:16:18 -07:00
parport_pc.c parport_pc: add support for ASIX AX99100 2023-07-30 13:54:56 +02:00
parport_serial.c parport: serial: Retrieve IRQ vector with help of special getter 2021-07-29 17:08:40 +02:00
parport_sunbpp.c parport: Explicitly include correct DT includes 2023-08-28 13:36:24 -05:00
probe.c parport: Use string_upper() instead of open coded variant 2021-05-21 14:48:58 +02:00
procfs.c parport: Use kasprintf() instead of fixed buffer formatting 2023-10-18 10:02:52 +02:00
share.c parport: Clean up resources correctly when parport_register_port() fails 2023-10-21 23:04:23 +02:00
TODO-parport