mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
30bfec4fec
After reading all CAN frames from the controller in the IRQ handler and storing them into a skb_queue, the driver calls napi_schedule(). In the napi poll function the skb from the skb_queue are then pushed into the networking stack. However if napi_schedule() is called from a threaded IRQ handler this triggers the following error: | NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!! To avoid this, create a new rx-offload function (can_rx_offload_threaded_irq_finish()) with a call to local_bh_disable()/local_bh_enable() around the napi_schedule() call. Convert all drivers that call can_rx_offload_irq_finish() from threaded IRQ context to can_rx_offload_threaded_irq_finish(). Link: https://lore.kernel.org/r/20210724204745.736053-4-mkl@pengutronix.de Suggested-by: Daniel Glöckner <dg@emlix.com> Tested-by: Oleksij Rempel <o.rempel@pengutronix.de> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
62 lines
1.9 KiB
C
62 lines
1.9 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* linux/can/rx-offload.h
|
|
*
|
|
* Copyright (c) 2014 David Jander, Protonic Holland
|
|
* Copyright (c) 2014-2017 Pengutronix, Marc Kleine-Budde <kernel@pengutronix.de>
|
|
*/
|
|
|
|
#ifndef _CAN_RX_OFFLOAD_H
|
|
#define _CAN_RX_OFFLOAD_H
|
|
|
|
#include <linux/netdevice.h>
|
|
#include <linux/can.h>
|
|
|
|
struct can_rx_offload {
|
|
struct net_device *dev;
|
|
|
|
struct sk_buff *(*mailbox_read)(struct can_rx_offload *offload,
|
|
unsigned int mb, u32 *timestamp,
|
|
bool drop);
|
|
|
|
struct sk_buff_head skb_queue;
|
|
struct sk_buff_head skb_irq_queue;
|
|
u32 skb_queue_len_max;
|
|
|
|
unsigned int mb_first;
|
|
unsigned int mb_last;
|
|
|
|
struct napi_struct napi;
|
|
|
|
bool inc;
|
|
};
|
|
|
|
int can_rx_offload_add_timestamp(struct net_device *dev,
|
|
struct can_rx_offload *offload);
|
|
int can_rx_offload_add_fifo(struct net_device *dev,
|
|
struct can_rx_offload *offload,
|
|
unsigned int weight);
|
|
int can_rx_offload_add_manual(struct net_device *dev,
|
|
struct can_rx_offload *offload,
|
|
unsigned int weight);
|
|
int can_rx_offload_irq_offload_timestamp(struct can_rx_offload *offload,
|
|
u64 reg);
|
|
int can_rx_offload_irq_offload_fifo(struct can_rx_offload *offload);
|
|
int can_rx_offload_queue_sorted(struct can_rx_offload *offload,
|
|
struct sk_buff *skb, u32 timestamp);
|
|
unsigned int can_rx_offload_get_echo_skb(struct can_rx_offload *offload,
|
|
unsigned int idx, u32 timestamp,
|
|
unsigned int *frame_len_ptr);
|
|
int can_rx_offload_queue_tail(struct can_rx_offload *offload,
|
|
struct sk_buff *skb);
|
|
void can_rx_offload_irq_finish(struct can_rx_offload *offload);
|
|
void can_rx_offload_threaded_irq_finish(struct can_rx_offload *offload);
|
|
void can_rx_offload_del(struct can_rx_offload *offload);
|
|
void can_rx_offload_enable(struct can_rx_offload *offload);
|
|
|
|
static inline void can_rx_offload_disable(struct can_rx_offload *offload)
|
|
{
|
|
napi_disable(&offload->napi);
|
|
}
|
|
|
|
#endif /* !_CAN_RX_OFFLOAD_H */
|