mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-22 00:40:03 +00:00
![Oleg Kanatov](/assets/img/avatar_default.png)
When closing the block allocation map, an incorrect pointer was NULL'ed. This commit fixes that. Signed-off-by: Oleg Kanatov <okanatov@gmail.com> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
153 lines
3.3 KiB
C
153 lines
3.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Copyright (C) International Business Machines Corp., 2000-2004
|
|
*/
|
|
|
|
/*
|
|
* jfs_umount.c
|
|
*
|
|
* note: file system in transition to aggregate/fileset:
|
|
* (ref. jfs_mount.c)
|
|
*
|
|
* file system unmount is interpreted as mount of the single/only
|
|
* fileset in the aggregate and, if unmount of the last fileset,
|
|
* as unmount of the aggerate;
|
|
*/
|
|
|
|
#include <linux/fs.h>
|
|
#include "jfs_incore.h"
|
|
#include "jfs_filsys.h"
|
|
#include "jfs_superblock.h"
|
|
#include "jfs_dmap.h"
|
|
#include "jfs_imap.h"
|
|
#include "jfs_metapage.h"
|
|
#include "jfs_debug.h"
|
|
|
|
/*
|
|
* NAME: jfs_umount(vfsp, flags, crp)
|
|
*
|
|
* FUNCTION: vfs_umount()
|
|
*
|
|
* PARAMETERS: vfsp - virtual file system pointer
|
|
* flags - unmount for shutdown
|
|
* crp - credential
|
|
*
|
|
* RETURN : EBUSY - device has open files
|
|
*/
|
|
int jfs_umount(struct super_block *sb)
|
|
{
|
|
struct jfs_sb_info *sbi = JFS_SBI(sb);
|
|
struct inode *ipbmap = sbi->ipbmap;
|
|
struct inode *ipimap = sbi->ipimap;
|
|
struct inode *ipaimap = sbi->ipaimap;
|
|
struct inode *ipaimap2 = sbi->ipaimap2;
|
|
struct jfs_log *log;
|
|
int rc = 0;
|
|
|
|
jfs_info("UnMount JFS: sb:0x%p", sb);
|
|
|
|
/*
|
|
* update superblock and close log
|
|
*
|
|
* if mounted read-write and log based recovery was enabled
|
|
*/
|
|
if ((log = sbi->log))
|
|
/*
|
|
* Wait for outstanding transactions to be written to log:
|
|
*/
|
|
jfs_flush_journal(log, 2);
|
|
|
|
/*
|
|
* close fileset inode allocation map (aka fileset inode)
|
|
*/
|
|
diUnmount(ipimap, 0);
|
|
|
|
diFreeSpecial(ipimap);
|
|
sbi->ipimap = NULL;
|
|
|
|
/*
|
|
* close secondary aggregate inode allocation map
|
|
*/
|
|
if (ipaimap2) {
|
|
diUnmount(ipaimap2, 0);
|
|
diFreeSpecial(ipaimap2);
|
|
sbi->ipaimap2 = NULL;
|
|
}
|
|
|
|
/*
|
|
* close aggregate inode allocation map
|
|
*/
|
|
diUnmount(ipaimap, 0);
|
|
diFreeSpecial(ipaimap);
|
|
sbi->ipaimap = NULL;
|
|
|
|
/*
|
|
* close aggregate block allocation map
|
|
*/
|
|
dbUnmount(ipbmap, 0);
|
|
|
|
diFreeSpecial(ipbmap);
|
|
sbi->ipbmap = NULL;
|
|
|
|
/*
|
|
* Make sure all metadata makes it to disk before we mark
|
|
* the superblock as clean
|
|
*/
|
|
filemap_write_and_wait(sbi->direct_inode->i_mapping);
|
|
|
|
/*
|
|
* ensure all file system file pages are propagated to their
|
|
* home blocks on disk (and their in-memory buffer pages are
|
|
* invalidated) BEFORE updating file system superblock state
|
|
* (to signify file system is unmounted cleanly, and thus in
|
|
* consistent state) and log superblock active file system
|
|
* list (to signify skip logredo()).
|
|
*/
|
|
if (log) { /* log = NULL if read-only mount */
|
|
updateSuper(sb, FM_CLEAN);
|
|
|
|
/*
|
|
* close log:
|
|
*
|
|
* remove file system from log active file system list.
|
|
*/
|
|
rc = lmLogClose(sb);
|
|
}
|
|
jfs_info("UnMount JFS Complete: rc = %d", rc);
|
|
return rc;
|
|
}
|
|
|
|
|
|
int jfs_umount_rw(struct super_block *sb)
|
|
{
|
|
struct jfs_sb_info *sbi = JFS_SBI(sb);
|
|
struct jfs_log *log = sbi->log;
|
|
|
|
if (!log)
|
|
return 0;
|
|
|
|
/*
|
|
* close log:
|
|
*
|
|
* remove file system from log active file system list.
|
|
*/
|
|
jfs_flush_journal(log, 2);
|
|
|
|
/*
|
|
* Make sure all metadata makes it to disk
|
|
*/
|
|
dbSync(sbi->ipbmap);
|
|
diSync(sbi->ipimap);
|
|
|
|
/*
|
|
* Note that we have to do this even if sync_blockdev() will
|
|
* do exactly the same a few instructions later: We can't
|
|
* mark the superblock clean before everything is flushed to
|
|
* disk.
|
|
*/
|
|
filemap_write_and_wait(sbi->direct_inode->i_mapping);
|
|
|
|
updateSuper(sb, FM_CLEAN);
|
|
|
|
return lmLogClose(sb);
|
|
}
|