linux-stable/include/linux/bcma
Linus Walleij 2b6c0e1528 bcma: Use the proper gpio include
The <linux/bcma/bcma_driver_chipcommon.h> is including the legacy
header <linux/gpio.h> to obtain struct gpio_chip. Instead, include
<linux/gpio/driver.h> where this struct is defined.

It turns out that the brcm80211 brcmsmac depends on this to
bring in the symbol gpio_is_valid().

The driver looks up the BCMA parent GPIO driver and checks that
this succeeds, but then it goes on to use the deprecated GPIO
call gpio_is_valid() to check the consistency of the .base
member of the BCMA GPIO struct. The whole check can be dropped
because the bcma_gpio is initialized in the declarations:

  struct gpio_chip *bcma_gpio = &cc_drv->gpio;

And this can never be NULL.

Cc: Jonas Gorski <jonas.gorski@gmail.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221028092332.238728-1-linus.walleij@linaro.org
2022-11-04 12:59:25 +02:00
..
bcma.h bcma: keep a direct pointer to the struct device 2019-01-10 13:39:18 +02:00
bcma_driver_arm_c9.h
bcma_driver_chipcommon.h bcma: Use the proper gpio include 2022-11-04 12:59:25 +02:00
bcma_driver_gmac_cmn.h
bcma_driver_mips.h
bcma_driver_pci.h
bcma_driver_pcie2.h
bcma_regs.h
bcma_soc.h MIPS: BCM47XX: Setup struct device for the SoC 2019-01-09 13:21:02 -08:00