Maurizio Lombardi 165aa2bfb4 scsi: iscsi: flush running unbind operations when removing a session ... In some cases, the iscsi_remove_session() function is called while an unbind_work operation is still running. This may cause a situation where sysfs objects are removed in an incorrect order, triggering a kernel warning. [ 605.249442] ------------[ cut here ]------------ [ 605.259180] sysfs group 'power' not found for kobject 'target2:0:0' [ 605.321371] WARNING: CPU: 1 PID: 26794 at fs/sysfs/group.c:235 sysfs_remove_group+0x76/0x80 [ 605.341266] Modules linked in: dm_service_time target_core_user target_core_pscsi target_core_file target_core_iblock iscsi_target_mod target_core_mod nls_utf8 isofs ppdev bochs_drm nfit ttm libnvdimm drm_kms_helper syscopyarea sysfillrect sysimgblt joydev pcspkr fb_sys_fops drm i2c_piix4 sg parport_pc parport xfs libcrc32c dm_multipath sr_mod sd_mod cdrom ata_generic 8021q garp mrp ata_piix stp crct10dif_pclmul crc32_pclmul llc libata crc32c_intel virtio_net net_failover ghash_clmulni_intel serio_raw failover sunrpc dm_mirror dm_region_hash dm_log dm_mod be2iscsi bnx2i cnic uio cxgb4i cxgb4 libcxgbi libcxgb qla4xxx iscsi_boot_sysfs iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi [ 605.627479] CPU: 1 PID: 26794 Comm: kworker/u32:2 Not tainted 4.18.0-60.el8.x86_64 #1 [ 605.721401] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS ?-20180724_192412-buildhw-07.phx2.fedoraproject.org-1.fc29 04/01/2014 [ 605.823651] Workqueue: scsi_wq_2 __iscsi_unbind_session [scsi_transport_iscsi] [ 605.830940] RIP: 0010:sysfs_remove_group+0x76/0x80 [ 605.922907] Code: 48 89 df 5b 5d 41 5c e9 38 c4 ff ff 48 89 df e8 e0 bf ff ff eb cb 49 8b 14 24 48 8b 75 00 48 c7 c7 38 73 cb a7 e8 24 77 d7 ff <0f> 0b 5b 5d 41 5c c3 0f 1f 00 0f 1f 44 00 00 41 56 41 55 41 54 55 [ 606.122304] RSP: 0018:ffffbadcc8d1bda8 EFLAGS: 00010286 [ 606.218492] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 [ 606.326381] RDX: ffff98bdfe85eb40 RSI: ffff98bdfe856818 RDI: ffff98bdfe856818 [ 606.514498] RBP: ffffffffa7ab73e0 R08: 0000000000000268 R09: 0000000000000007 [ 606.529469] R10: 0000000000000000 R11: ffffffffa860d9ad R12: ffff98bdf978e838 [ 606.630535] R13: ffff98bdc2cd4010 R14: ffff98bdc2cd3ff0 R15: ffff98bdc2cd4000 [ 606.824707] FS: 0000000000000000(0000) GS:ffff98bdfe840000(0000) knlGS:0000000000000000 [ 607.018333] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 607.117844] CR2: 00007f84b78ac024 CR3: 000000002c00a003 CR4: 00000000003606e0 [ 607.117844] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 607.420926] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 607.524236] Call Trace: [ 607.530591] device_del+0x56/0x350 [ 607.624393] ? ata_tlink_match+0x30/0x30 [libata] [ 607.727805] ? attribute_container_device_trigger+0xb4/0xf0 [ 607.829911] scsi_target_reap_ref_release+0x39/0x50 [ 607.928572] scsi_remove_target+0x1a2/0x1d0 [ 608.017350] __iscsi_unbind_session+0xb3/0x160 [scsi_transport_iscsi] [ 608.117435] process_one_work+0x1a7/0x360 [ 608.132917] worker_thread+0x30/0x390 [ 608.222900] ? pwq_unbound_release_workfn+0xd0/0xd0 [ 608.323989] kthread+0x112/0x130 [ 608.418318] ? kthread_bind+0x30/0x30 [ 608.513821] ret_from_fork+0x35/0x40 [ 608.613909] ---[ end trace 0b98c310c8a6138c ]--- Signed-off-by: Maurizio Lombardi <mlombard@redhat.com> Acked-by: Chris Leech <cleech@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2019-03-18 16:55:48 -04:00
..
aacraid	SCSI misc on 20190315	2019-03-16 12:51:50 -07:00
aic7xxx	scsi: remove unneeded header search paths	2019-01-29 01:22:21 -05:00
aic94xx	scsi: aic94xx: fix calls to dma_set_mask_and_coherent()	2019-02-25 21:37:26 -05:00
arcmsr	scsi: arcmsr: Update driver version to v1.40.00.10-20190116	2019-01-22 21:38:21 -05:00
arm	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
be2iscsi	genirq/affinity: Add new callback for (re)calculating interrupt sets	2019-02-18 11:21:28 +01:00
bfa	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
bnx2fc	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
bnx2i	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
csiostor	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
cxgbi	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
cxlflash	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
device_handler	scsi: return blk_status_t from device handler ->prep_fn	2018-11-09 19:17:14 -07:00
dpt
esas2r	scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template	2019-02-08 17:33:00 -05:00
fcoe	scsi: fcoe: make use of fip_mode enum complete	2019-02-19 18:58:38 -05:00
fnic	scsi: fnic: Remove set but not used variable 'vdev'	2019-01-29 01:16:09 -05:00
hisi_sas	SCSI misc on 20190315	2019-03-16 12:51:50 -07:00
ibmvscsi	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
ibmvscsi_tgt	scsi: target/core: Remove the write_pending_status() callback function	2019-02-04 21:23:59 -05:00
isci	scsi: isci: initialize shost fully before calling scsi_add_host()	2019-01-08 22:27:24 -05:00
libfc	Revert "scsi: libfc: Add WARN_ON() when deleting rports"	2019-02-04 22:17:33 -05:00
libsas	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
lpfc	SCSI misc on 20190315	2019-03-16 12:51:50 -07:00
megaraid	SCSI misc on 20190315	2019-03-16 12:51:50 -07:00
mpt3sas	scsi: mpt3sas: Add missing breaks in switch statements	2019-02-27 09:36:54 -05:00
mvsas	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
pcmcia	scsi: pcmcia: nsp_cs: Remove unnecessary parentheses	2019-01-29 01:28:49 -05:00
pm8001	SCSI fixes on 20190118	2019-01-20 09:15:04 +12:00
qedf	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
qedi	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
qla2xxx	SCSI misc on 20190315	2019-03-16 12:51:50 -07:00
qla4xxx	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
smartpqi	SCSI misc on 20190315	2019-03-16 12:51:50 -07:00
snic	scsi: snic: no need to check return value of debugfs_create functions	2019-01-29 00:40:54 -05:00
sym53c8xx_2	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
ufs	SCSI misc on 20190315	2019-03-16 12:51:50 -07:00
.gitignore
3w-9xxx.c	scsi: 3w-9xxx: fix calls to dma_set_mask_and_coherent()	2019-02-25 21:37:25 -05:00
3w-9xxx.h
3w-sas.c	SCSI fixes on 20190302	2019-03-02 11:39:54 -08:00
3w-sas.h
3w-xxxx.c	scsi: 3w-xxxx: fix indentation issue, add missing tab	2018-12-19 21:54:07 -05:00
3w-xxxx.h	scsi: 3w-xxx: fully convert to the generic DMA API	2018-10-17 21:58:51 -04:00
53c700.c	scsi: 53c700: pass correct "dev" to dma_alloc_attrs()	2019-01-29 01:33:00 -05:00
53c700.h	scsi: 53c700: Fix spelling of 'NEGOTIATION'	2018-08-30 07:27:22 -04:00
53c700.scr
53c700_d.h_shipped
a100u2w.c	cross-tree: phase out dma_zalloc_coherent()	2019-01-08 07:58:37 -05:00
a100u2w.h
a2091.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
a2091.h
a3000.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
a3000.h
a4000t.c
advansys.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
aha152x.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
aha152x.h
aha1542.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
aha1542.h
aha1740.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
aha1740.h	scsi: core: remove Scsi_Cmnd typedef	2018-06-19 22:02:25 -04:00
am53c974.c	scsi: esp_scsi: move dma mapping into the core code	2018-10-15 23:00:38 -04:00
atari_scsi.c	nvram: Replace nvram_* function exports with static functions	2019-01-22 10:21:43 +01:00
atp870u.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
atp870u.h
BusLogic.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
BusLogic.h
bvme6000_scsi.c
ch.c	scsi: core: check for equality of result byte values	2018-06-26 12:27:06 -04:00
constants.c
dc395x.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
dc395x.h
dmx3191d.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
dpt_i2o.c	scsi: dpt_i2o: remove serial number usage	2019-02-27 09:19:23 -05:00
dpti.h
esp_scsi.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
esp_scsi.h	scsi: esp_scsi: De-duplicate PIO routines	2018-10-17 21:38:20 -04:00
FlashPoint.c	scsi: FlashPoint: Remove unnecessary parentheses	2018-09-25 20:45:53 -04:00
g_NCR5380.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
gdth.c	scsi: gdth: use generic DMA API	2019-01-08 21:58:35 -05:00
gdth.h	scsi: gdth: remove ISA and EISA support	2019-01-08 21:58:35 -05:00
gdth_ioctl.h	scsi: gdth: remove dead code under #ifdef GDTH_IOCTL_PROC	2019-01-08 21:58:35 -05:00
gdth_proc.c	scsi: gdth: use generic DMA API	2019-01-08 21:58:35 -05:00
gdth_proc.h	scsi: gdth: remove gdth_{alloc,free}_ioctl	2019-01-08 21:57:42 -05:00
gvp11.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
gvp11.h
hosts.c	SCSI misc on 20181224	2018-12-28 14:48:06 -08:00
hpsa.c	scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template	2019-02-08 17:33:00 -05:00
hpsa.h	scsi: hpsa: correct enclosure sas address	2018-07-10 22:25:03 -04:00
hpsa_cmd.h
hptiop.c	scsi: hptiop: fix calls to dma_set_mask()	2019-02-25 21:44:40 -05:00
hptiop.h
imm.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
imm.h
initio.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
initio.h
ipr.c	scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template	2019-02-08 17:33:00 -05:00
ipr.h	scsi: ipr: System hung while dlpar adding primary ipr adapter back	2018-09-21 12:35:39 -04:00
ips.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
ips.h	scsi: ips: properly handle 64-bit DMA	2018-11-06 21:31:28 -05:00
iscsi_boot_sysfs.c
iscsi_tcp.c	scsi: remove bidirectional command support	2019-02-05 21:29:21 -05:00
iscsi_tcp.h
jazz_esp.c	scsi: esp_scsi: move dma mapping into the core code	2018-10-15 23:00:38 -04:00
Kconfig	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
lasi700.c
libiscsi.c	SCSI misc on 20190315	2019-03-16 12:51:50 -07:00
libiscsi_tcp.c	scsi: libiscsi: fall back to sendmsg for slab pages	2019-03-06 19:26:45 -05:00
mac53c94.c	scsi: mac53c94: remove DISABLE_CLUSTERING	2018-12-18 23:13:12 -05:00
mac53c94.h
mac_esp.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
mac_scsi.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
Makefile	scsi: remove the SCSI OSD library	2019-02-05 21:28:52 -05:00
megaraid.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
megaraid.h	scsi: core: remove Scsi_Cmnd typedef	2018-06-19 22:02:25 -04:00
mesh.c	cross-tree: phase out dma_zalloc_coherent()	2019-01-08 07:58:37 -05:00
mesh.h
mvme16x_scsi.c
mvme147.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
mvme147.h
mvumi.c	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
mvumi.h
myrb.c	SCSI misc on 20181224	2018-12-28 14:48:06 -08:00
myrb.h	scsi: myrb: Add Mylex RAID controller (block interface)	2018-10-17 21:06:49 -04:00
myrs.c	scsi: myrs: remove the dma_boundary_limit	2018-12-19 21:43:30 -05:00
myrs.h	scsi: myrs: Add Mylex RAID controller (SCSI interface)	2018-10-17 21:07:54 -04:00
ncr53c8xx.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
ncr53c8xx.h
NCR5380.c	scsi: NCR5380: Return false instead of NULL	2018-11-05 22:47:38 -05:00
NCR5380.h	scsi: NCR5380: Have NCR5380_select() return a bool	2018-09-28 02:17:51 -04:00
nsp32.c	scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry	2019-01-29 01:26:57 -05:00
nsp32.h
nsp32_debug.c	scsi: core: remove Scsi_Cmnd typedef	2018-06-19 22:02:25 -04:00
nsp32_io.h
osst.c	scsi: st: osst: Remove negative constant left-shifts	2019-02-27 09:10:16 -05:00
osst.h
osst_detect.h
osst_options.h
pmcraid.c	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
pmcraid.h
ppa.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
ppa.h
ps3rom.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
qla1280.c	scsi: qla1280: set 64bit coherent mask	2019-01-11 22:30:51 -05:00
qla1280.h
qlogicfas.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
qlogicfas408.c
qlogicfas408.h
qlogicpti.c	scsi: qlogicpti: Use of_node_name_eq for node name comparisons	2019-02-13 22:07:03 -05:00
qlogicpti.h	scsi: qlogicpti: Use of_node_name_eq for node name comparisons	2019-02-13 22:07:03 -05:00
raid_class.c	scsi: raid_attrs: fix unused variable warning	2018-08-30 07:21:04 -04:00
script_asm.pl
scsi.c	scsi: kill command serial number	2019-02-27 09:19:24 -05:00
scsi.h	scsi: core: remove Scsi_Cmnd typedef	2018-06-19 22:02:25 -04:00
scsi_common.c
scsi_debug.c	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
scsi_debugfs.c	scsi: devinfo: use const_ilog2 for array indices	2018-04-20 19:14:28 -04:00
scsi_debugfs.h
scsi_devinfo.c	scsi: devinfo: BLIST_RETRY_ASC_C1 for Fujitsu ETERNUS	2018-04-20 19:14:36 -04:00
scsi_dh.c	scsi: scsi_dh: replace too broad "TP9" string with the exact models	2018-04-18 19:34:08 -04:00
scsi_error.c	scsi: remove bidirectional command support	2019-02-05 21:29:21 -05:00
scsi_ioctl.c	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
scsi_lib.c	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
scsi_lib_dma.c
scsi_logging.c
scsi_logging.h
scsi_netlink.c
scsi_pm.c	scsi: core: Synchronize request queue PM status only on successful resume	2019-01-08 21:57:26 -05:00
scsi_priv.h	scsi: kill off the legacy IO path	2018-11-07 13:42:32 -07:00
scsi_proc.c
scsi_sas_internal.h
scsi_scan.c	scsi: core: replace GFP_ATOMIC with GFP_KERNEL in scsi_scan.c	2019-02-27 09:39:28 -05:00
scsi_sysctl.c
scsi_sysfs.c	scsi: kill off the legacy IO path	2018-11-07 13:42:32 -07:00
scsi_trace.c
scsi_transport_api.h
scsi_transport_fc.c	bsg: convert to use blk-mq	2018-11-07 13:42:32 -07:00
scsi_transport_iscsi.c	scsi: iscsi: flush running unbind operations when removing a session	2019-03-18 16:55:48 -04:00
scsi_transport_sas.c	scsi: bsg-lib: handle bidi requests without block layer help	2019-02-05 21:27:40 -05:00
scsi_transport_spi.c	scsi: core: check for equality of result byte values	2018-06-26 12:27:06 -04:00
scsi_transport_srp.c	for-4.18/block-20180603	2018-06-04 07:58:06 -07:00
scsicam.c
sd.c	SCSI misc on 20190306	2019-03-09 16:53:47 -08:00
sd.h	scsi: sd: Fix typo in sd_first_printk()	2019-02-12 22:33:00 -05:00
sd_dif.c	block: move dif_prepare/dif_complete functions to block layer	2018-07-30 08:27:02 -06:00
sd_zbc.c	scsi: sd_zbc: Fix sd_zbc_report_zones() buffer allocation	2019-02-15 22:09:54 -05:00
sense_codes.h
ses.c	treewide: kzalloc() -> kcalloc()	2018-06-12 16:19:22 -07:00
sg.c	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
sgiwd93.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
sim710.c
sni_53c710.c
sr.c	scsi: stop setting up request->special	2019-02-05 21:29:49 -05:00
sr.h
sr_ioctl.c	block: Switch struct packet_command to use struct scsi_sense_hdr	2018-08-02 15:22:13 -06:00
sr_vendor.c
st.c	scsi: st: osst: Remove negative constant left-shifts	2019-02-27 09:10:16 -05:00
st.h
st_options.h
stex.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
storvsc_drv.c	SCSI misc on 20181224	2018-12-28 14:48:06 -08:00
sun3_scsi.c	scsi: remove the use_clustering flag	2018-12-18 23:19:21 -05:00
sun3_scsi_vme.c
sun3x_esp.c	scsi: esp_scsi: move dma mapping into the core code	2018-10-15 23:00:38 -04:00
sun_esp.c	scsi: sun_esp: Use of_node_name_eq for node name comparisons	2018-12-07 21:56:06 -05:00
virtio_scsi.c	scsi: virtio_scsi: don't send sc payload with tmfs	2019-03-06 12:35:02 -05:00
vmw_pvscsi.c	SCSI misc on 20181224	2018-12-28 14:48:06 -08:00
vmw_pvscsi.h
wd33c93.c
wd33c93.h
wd719x.c	scsi: flip the default on use_clustering	2018-12-18 23:13:12 -05:00
wd719x.h	scsi: wd719x: use per-command private data	2018-11-15 14:27:08 -05:00
xen-scsifront.c	scsi: xen-scsifront: remove DISABLE_CLUSTERING	2018-12-18 23:13:12 -05:00
zalon.c
zorro7xx.c
zorro_esp.c	scsi: esp_scsi: De-duplicate PIO routines	2018-10-17 21:38:20 -04:00