mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 17:08:10 +00:00
4609e1f18e
Convert to struct mnt_idmap.
Last cycle we merged the necessary infrastructure in
256c8aed2b ("fs: introduce dedicated idmap type for mounts").
This is just the conversion to struct mnt_idmap.
Currently we still pass around the plain namespace that was attached to a
mount. This is in general pretty convenient but it makes it easy to
conflate namespaces that are relevant on the filesystem with namespaces
that are relevent on the mount level. Especially for non-vfs developers
without detailed knowledge in this area this can be a potential source for
bugs.
Once the conversion to struct mnt_idmap is done all helpers down to the
really low-level helpers will take a struct mnt_idmap argument instead of
two namespace arguments. This way it becomes impossible to conflate the two
eliminating the possibility of any bugs. All of the vfs and all filesystems
only operate on struct mnt_idmap.
Acked-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
88 lines
2.2 KiB
C
88 lines
2.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Pioctl operations for Coda.
|
|
* Original version: (C) 1996 Peter Braam
|
|
* Rewritten for Linux 2.1: (C) 1997 Carnegie Mellon University
|
|
*
|
|
* Carnegie Mellon encourages users of this code to contribute improvements
|
|
* to the Coda project. Contact Peter Braam <coda@cs.cmu.edu>.
|
|
*/
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/time.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/stat.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/string.h>
|
|
#include <linux/namei.h>
|
|
#include <linux/module.h>
|
|
#include <linux/uaccess.h>
|
|
|
|
#include <linux/coda.h>
|
|
#include "coda_psdev.h"
|
|
#include "coda_linux.h"
|
|
|
|
/* pioctl ops */
|
|
static int coda_ioctl_permission(struct mnt_idmap *idmap,
|
|
struct inode *inode, int mask);
|
|
static long coda_pioctl(struct file *filp, unsigned int cmd,
|
|
unsigned long user_data);
|
|
|
|
/* exported from this file */
|
|
const struct inode_operations coda_ioctl_inode_operations = {
|
|
.permission = coda_ioctl_permission,
|
|
.setattr = coda_setattr,
|
|
};
|
|
|
|
const struct file_operations coda_ioctl_operations = {
|
|
.unlocked_ioctl = coda_pioctl,
|
|
.llseek = noop_llseek,
|
|
};
|
|
|
|
/* the coda pioctl inode ops */
|
|
static int coda_ioctl_permission(struct mnt_idmap *idmap,
|
|
struct inode *inode, int mask)
|
|
{
|
|
return (mask & MAY_EXEC) ? -EACCES : 0;
|
|
}
|
|
|
|
static long coda_pioctl(struct file *filp, unsigned int cmd,
|
|
unsigned long user_data)
|
|
{
|
|
struct path path;
|
|
int error;
|
|
struct PioctlData data;
|
|
struct inode *inode = file_inode(filp);
|
|
struct inode *target_inode = NULL;
|
|
struct coda_inode_info *cnp;
|
|
|
|
/* get the Pioctl data arguments from user space */
|
|
if (copy_from_user(&data, (void __user *)user_data, sizeof(data)))
|
|
return -EINVAL;
|
|
|
|
/*
|
|
* Look up the pathname. Note that the pathname is in
|
|
* user memory, and namei takes care of this
|
|
*/
|
|
error = user_path_at(AT_FDCWD, data.path,
|
|
data.follow ? LOOKUP_FOLLOW : 0, &path);
|
|
if (error)
|
|
return error;
|
|
|
|
target_inode = d_inode(path.dentry);
|
|
|
|
/* return if it is not a Coda inode */
|
|
if (target_inode->i_sb != inode->i_sb) {
|
|
error = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
/* now proceed to make the upcall */
|
|
cnp = ITOC(target_inode);
|
|
|
|
error = venus_pioctl(inode->i_sb, &(cnp->c_fid), cmd, &data);
|
|
out:
|
|
path_put(&path);
|
|
return error;
|
|
}
|