mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
![Zenghui Yu](/assets/img/avatar_default.png)
debugfs code complained at boot time that debugfs: Directory 'reg-dummy-regulator-dummy' with parent 'regulator' already present! if we compile kernel with DEBUG_TEST_DRIVER_REMOVE. The problem is that we don't provide .remove() method for dummy_regulator_driver, which should invoke regulator_unregister() on device teardown to properly free things. Though it's harmless as dummy_pdev never gets unbound in practice, let's use devm_regulator_register() to get rid of the inconsistency. Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> Link: https://lore.kernel.org/r/20210925035507.1904-1-yuzenghui@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org>
90 lines
2 KiB
C
90 lines
2 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* dummy.c
|
|
*
|
|
* Copyright 2010 Wolfson Microelectronics PLC.
|
|
*
|
|
* Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
|
|
*
|
|
* This is useful for systems with mixed controllable and
|
|
* non-controllable regulators, as well as for allowing testing on
|
|
* systems with no controllable regulators.
|
|
*/
|
|
|
|
#include <linux/err.h>
|
|
#include <linux/export.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/regulator/driver.h>
|
|
#include <linux/regulator/machine.h>
|
|
|
|
#include "dummy.h"
|
|
|
|
struct regulator_dev *dummy_regulator_rdev;
|
|
|
|
static const struct regulator_init_data dummy_initdata = {
|
|
.constraints = {
|
|
.always_on = 1,
|
|
},
|
|
};
|
|
|
|
static const struct regulator_ops dummy_ops;
|
|
|
|
static const struct regulator_desc dummy_desc = {
|
|
.name = "regulator-dummy",
|
|
.id = -1,
|
|
.type = REGULATOR_VOLTAGE,
|
|
.owner = THIS_MODULE,
|
|
.ops = &dummy_ops,
|
|
};
|
|
|
|
static int dummy_regulator_probe(struct platform_device *pdev)
|
|
{
|
|
struct regulator_config config = { };
|
|
int ret;
|
|
|
|
config.dev = &pdev->dev;
|
|
config.init_data = &dummy_initdata;
|
|
|
|
dummy_regulator_rdev = devm_regulator_register(&pdev->dev, &dummy_desc,
|
|
&config);
|
|
if (IS_ERR(dummy_regulator_rdev)) {
|
|
ret = PTR_ERR(dummy_regulator_rdev);
|
|
pr_err("Failed to register regulator: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver dummy_regulator_driver = {
|
|
.probe = dummy_regulator_probe,
|
|
.driver = {
|
|
.name = "reg-dummy",
|
|
},
|
|
};
|
|
|
|
static struct platform_device *dummy_pdev;
|
|
|
|
void __init regulator_dummy_init(void)
|
|
{
|
|
int ret;
|
|
|
|
dummy_pdev = platform_device_alloc("reg-dummy", -1);
|
|
if (!dummy_pdev) {
|
|
pr_err("Failed to allocate dummy regulator device\n");
|
|
return;
|
|
}
|
|
|
|
ret = platform_device_add(dummy_pdev);
|
|
if (ret != 0) {
|
|
pr_err("Failed to register dummy regulator device: %d\n", ret);
|
|
platform_device_put(dummy_pdev);
|
|
return;
|
|
}
|
|
|
|
ret = platform_driver_register(&dummy_regulator_driver);
|
|
if (ret != 0) {
|
|
pr_err("Failed to register dummy regulator driver: %d\n", ret);
|
|
platform_device_unregister(dummy_pdev);
|
|
}
|
|
}
|