mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
![Martin K. Petersen](/assets/img/avatar_default.png)
During device discovery we ended up calling revalidate twice and thus requested the same parameters multiple times. This was originally necessary due to the request_queue and gendisk needing to be instantiated to configure the block integrity profile. Since this dependency no longer exists, reorganize the integrity probing code so it can be run once at the end of discovery and drop the superfluous revalidate call. Postponing the registration step involves splitting sd_read_protection() into two functions, one to read the device protection type and one to configure the mode of operation. As part of this cleanup, make the printing code a bit less verbose. Link: https://lore.kernel.org/r/20220302053559.32147-14-martin.petersen@oracle.com Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
81 lines
1.8 KiB
C
81 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* sd_dif.c - SCSI Data Integrity Field
|
|
*
|
|
* Copyright (C) 2007, 2008 Oracle Corporation
|
|
* Written by: Martin K. Petersen <martin.petersen@oracle.com>
|
|
*/
|
|
|
|
#include <linux/blk-integrity.h>
|
|
#include <linux/t10-pi.h>
|
|
|
|
#include <scsi/scsi.h>
|
|
#include <scsi/scsi_cmnd.h>
|
|
#include <scsi/scsi_dbg.h>
|
|
#include <scsi/scsi_device.h>
|
|
#include <scsi/scsi_driver.h>
|
|
#include <scsi/scsi_eh.h>
|
|
#include <scsi/scsi_host.h>
|
|
#include <scsi/scsi_ioctl.h>
|
|
#include <scsi/scsicam.h>
|
|
|
|
#include "sd.h"
|
|
|
|
/*
|
|
* Configure exchange of protection information between OS and HBA.
|
|
*/
|
|
void sd_dif_config_host(struct scsi_disk *sdkp)
|
|
{
|
|
struct scsi_device *sdp = sdkp->device;
|
|
struct gendisk *disk = sdkp->disk;
|
|
u8 type = sdkp->protection_type;
|
|
struct blk_integrity bi;
|
|
int dif, dix;
|
|
|
|
dif = scsi_host_dif_capable(sdp->host, type);
|
|
dix = scsi_host_dix_capable(sdp->host, type);
|
|
|
|
if (!dix && scsi_host_dix_capable(sdp->host, 0)) {
|
|
dif = 0; dix = 1;
|
|
}
|
|
|
|
if (!dix)
|
|
return;
|
|
|
|
memset(&bi, 0, sizeof(bi));
|
|
|
|
/* Enable DMA of protection information */
|
|
if (scsi_host_get_guard(sdkp->device->host) & SHOST_DIX_GUARD_IP) {
|
|
if (type == T10_PI_TYPE3_PROTECTION)
|
|
bi.profile = &t10_pi_type3_ip;
|
|
else
|
|
bi.profile = &t10_pi_type1_ip;
|
|
|
|
bi.flags |= BLK_INTEGRITY_IP_CHECKSUM;
|
|
} else
|
|
if (type == T10_PI_TYPE3_PROTECTION)
|
|
bi.profile = &t10_pi_type3_crc;
|
|
else
|
|
bi.profile = &t10_pi_type1_crc;
|
|
|
|
bi.tuple_size = sizeof(struct t10_pi_tuple);
|
|
|
|
if (dif && type) {
|
|
bi.flags |= BLK_INTEGRITY_DEVICE_CAPABLE;
|
|
|
|
if (!sdkp->ATO)
|
|
goto out;
|
|
|
|
if (type == T10_PI_TYPE3_PROTECTION)
|
|
bi.tag_size = sizeof(u16) + sizeof(u32);
|
|
else
|
|
bi.tag_size = sizeof(u16);
|
|
}
|
|
|
|
sd_printk(KERN_NOTICE, sdkp,
|
|
"Enabling DIX %s, application tag size %u bytes\n",
|
|
bi.profile->name, bi.tag_size);
|
|
out:
|
|
blk_integrity_register(disk, &bi);
|
|
}
|
|
|