mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-23 11:01:15 +00:00
95da310e66
USB serial likes to use port->tty back pointers for the real work it does and to do so without any actual locking. Unfortunately when you consider hangup events, hangup/parallel reopen or even worse hangup followed by parallel close events the tty->port and port->tty pointers are not guaranteed to be the same as port->tty is the active tty while tty->port is the port the tty may or may not still be attached to. So rework the entire API to pass the tty struct. For console cases we need to pass both for now. This shows up multiple drivers that immediately crash with USB console some of which have been fixed in the process. Longer term we need a proper tty as console abstraction Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
72 lines
1.5 KiB
C
72 lines
1.5 KiB
C
/*
|
|
* USB Debug cable driver
|
|
*
|
|
* Copyright (C) 2006 Greg Kroah-Hartman <greg@kroah.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License version
|
|
* 2 as published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/tty.h>
|
|
#include <linux/module.h>
|
|
#include <linux/usb.h>
|
|
#include <linux/usb/serial.h>
|
|
|
|
#define USB_DEBUG_MAX_PACKET_SIZE 8
|
|
|
|
static struct usb_device_id id_table [] = {
|
|
{ USB_DEVICE(0x0525, 0x127a) },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(usb, id_table);
|
|
|
|
static struct usb_driver debug_driver = {
|
|
.name = "debug",
|
|
.probe = usb_serial_probe,
|
|
.disconnect = usb_serial_disconnect,
|
|
.id_table = id_table,
|
|
.no_dynamic_id = 1,
|
|
};
|
|
|
|
int usb_debug_open(struct tty_struct *tty, struct usb_serial_port *port,
|
|
struct file *filp)
|
|
{
|
|
port->bulk_out_size = USB_DEBUG_MAX_PACKET_SIZE;
|
|
return usb_serial_generic_open(tty, port, filp);
|
|
}
|
|
|
|
static struct usb_serial_driver debug_device = {
|
|
.driver = {
|
|
.owner = THIS_MODULE,
|
|
.name = "debug",
|
|
},
|
|
.id_table = id_table,
|
|
.num_ports = 1,
|
|
.open = usb_debug_open,
|
|
};
|
|
|
|
static int __init debug_init(void)
|
|
{
|
|
int retval;
|
|
|
|
retval = usb_serial_register(&debug_device);
|
|
if (retval)
|
|
return retval;
|
|
retval = usb_register(&debug_driver);
|
|
if (retval)
|
|
usb_serial_deregister(&debug_device);
|
|
return retval;
|
|
}
|
|
|
|
static void __exit debug_exit(void)
|
|
{
|
|
usb_deregister(&debug_driver);
|
|
usb_serial_deregister(&debug_device);
|
|
}
|
|
|
|
module_init(debug_init);
|
|
module_exit(debug_exit);
|
|
MODULE_LICENSE("GPL");
|