Pierre-Louis Bossart cc73306bf4 ALSA: hda: intel-dsp-config: harden I2C/I2S codec detection ... [ Upstream commit 79ac4c1443 ] The SOF driver is selected whenever specific I2C/I2S HIDs are reported as 'present' in the ACPI DSDT. In some cases, an HID is reported but the hardware does not actually rely on I2C/I2S. This false positive leads to an invalid selection of the SOF driver and as a result an invalid topology is loaded. This patch hardens the detection with a check that the NHLT table is consistent with the report of an I2S-based codec in DSDT. This table should expose at least one SSP endpoint configured for an I2S-codec connection. Tested on Huawei Matebook D14 (NBLB-WAX9N) using an HDaudio codec with an invalid ES8336 ACPI HID reported: [ 7.858249] snd_hda_intel 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040380 [ 7.858312] snd_hda_intel 0000:00:1f.3: snd_intel_dsp_find_config: no valid SSP found for HID ESSX8336, skipped Reported-by: Mauro Carvalho Chehab <mchehab@kernel.org> Tested-by: Mauro Carvalho Chehab <mchehab@kernel.org> Closes: https://github.com/thesofproject/linux/issues/4934 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> Message-ID: <20240426152818.38443-1-pierre-louis.bossart@linux.intel.com> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-06-12 11:11:28 +02:00
..
ac97
aoa	ALSA: aoa: Fix typos in PCM fix patch	2023-08-18 09:09:39 +02:00
arm
atmel
core	ALSA: Fix deadlocks with kctl removals at disconnection	2024-06-12 11:11:21 +02:00
drivers	ALSA: pcmtest: stop timer before buffer is released	2024-01-20 11:51:42 +01:00
firewire	ALSA: firewire-lib: handle quirk to calculate payload quadlets as data block counter	2024-04-13 13:07:35 +02:00
hda	ALSA: hda: intel-dsp-config: harden I2C/I2S codec detection	2024-06-12 11:11:28 +02:00
i2c
isa	ALSA: cs4231: Fix -Wformat-truncation warning for longname string	2023-09-15 13:23:01 +02:00
mips
oss
parisc
pci	ALSA: emu10k1: make E-MU FPGA writes potentially more reliable	2024-06-12 11:11:27 +02:00
pcmcia
ppc
sh	ALSA: sh: aica: reorder cleanup operations to avoid UAF bugs	2024-04-03 15:28:59 +02:00
soc	ASoC: da7219-aad: fix usage of device_get_named_child_node()	2024-06-12 11:11:28 +02:00
sparc
spi
synth
usb	ALSA: line6: Zero-initialize message buffers	2024-05-17 12:02:13 +02:00
virtio
x86
xen	ALSA: xen: Fix -Wformat-truncation warning	2023-09-15 13:21:35 +02:00
ac97_bus.c
Kconfig	This pull request contains the following changes for UML:	2023-09-04 11:32:21 -07:00
last.c
Makefile
sound_core.c