mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-20 17:41:09 +00:00
33b57e0cc7
Current max cgroup storage value size is 4k (PAGE_SIZE). The other local storages accept up to 64k (BPF_LOCAL_STORAGE_MAX_VALUE_SIZE). Let's align max cgroup value size with the other storages. For percpu, the max is 32k (PCPU_MIN_UNIT_SIZE) because percpu allocator is not happy about larger values. netcnt test is extended to exercise those maximum values (non-percpu max size is close to, but not real max). v4: * remove inner union (Andrii Nakryiko) * keep net_cnt on the stack (Andrii Nakryiko) v3: * refine SIZEOF_BPF_LOCAL_STORAGE_ELEM comment (Yonghong Song) * anonymous struct in percpu_net_cnt & net_cnt (Yonghong Song) * reorder free (Yonghong Song) v2: * cap max_value_size instead of BUILD_BUG_ON (Martin KaFai Lau) Signed-off-by: Stanislav Fomichev <sdf@google.com> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Acked-by: Martin KaFai Lau <kafai@fb.com> Link: https://lore.kernel.org/bpf/20210727222335.4029096-1-sdf@google.com
44 lines
910 B
C
44 lines
910 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
#ifndef __NETCNT_COMMON_H
|
|
#define __NETCNT_COMMON_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
#define MAX_PERCPU_PACKETS 32
|
|
|
|
/* sizeof(struct bpf_local_storage_elem):
|
|
*
|
|
* It really is about 128 bytes on x86_64, but allocate more to account for
|
|
* possible layout changes, different architectures, etc.
|
|
* The kernel will wrap up to PAGE_SIZE internally anyway.
|
|
*/
|
|
#define SIZEOF_BPF_LOCAL_STORAGE_ELEM 256
|
|
|
|
/* Try to estimate kernel's BPF_LOCAL_STORAGE_MAX_VALUE_SIZE: */
|
|
#define BPF_LOCAL_STORAGE_MAX_VALUE_SIZE (0xFFFF - \
|
|
SIZEOF_BPF_LOCAL_STORAGE_ELEM)
|
|
|
|
#define PCPU_MIN_UNIT_SIZE 32768
|
|
|
|
union percpu_net_cnt {
|
|
struct {
|
|
__u64 packets;
|
|
__u64 bytes;
|
|
|
|
__u64 prev_ts;
|
|
|
|
__u64 prev_packets;
|
|
__u64 prev_bytes;
|
|
};
|
|
__u8 data[PCPU_MIN_UNIT_SIZE];
|
|
};
|
|
|
|
union net_cnt {
|
|
struct {
|
|
__u64 packets;
|
|
__u64 bytes;
|
|
};
|
|
__u8 data[BPF_LOCAL_STORAGE_MAX_VALUE_SIZE];
|
|
};
|
|
|
|
#endif
|