mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
a0386bba70
The value returned by an spi driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Jérôme Pouiller <jerome.pouiller@silabs.com> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Acked-by: Claudius Heine <ch@denx.de> Acked-by: Stefan Schmidt <stefan@datenfreihafen.org> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-by: Ulf Hansson <ulf.hansson@linaro.org> # For MMC Acked-by: Marcus Folkesson <marcus.folkesson@gmail.com> Acked-by: Łukasz Stelmach <l.stelmach@samsung.com> Acked-by: Lee Jones <lee.jones@linaro.org> Link: https://lore.kernel.org/r/20220123175201.34839-6-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
57 lines
1.3 KiB
C
57 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
#include <linux/spi/spi.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/iio/iio.h>
|
|
#include <linux/module.h>
|
|
|
|
#include "bmg160.h"
|
|
|
|
static const struct regmap_config bmg160_regmap_spi_conf = {
|
|
.reg_bits = 8,
|
|
.val_bits = 8,
|
|
.max_register = 0x3f,
|
|
};
|
|
|
|
static int bmg160_spi_probe(struct spi_device *spi)
|
|
{
|
|
struct regmap *regmap;
|
|
const struct spi_device_id *id = spi_get_device_id(spi);
|
|
|
|
regmap = devm_regmap_init_spi(spi, &bmg160_regmap_spi_conf);
|
|
if (IS_ERR(regmap)) {
|
|
dev_err(&spi->dev, "Failed to register spi regmap: %pe\n",
|
|
regmap);
|
|
return PTR_ERR(regmap);
|
|
}
|
|
|
|
return bmg160_core_probe(&spi->dev, regmap, spi->irq, id->name);
|
|
}
|
|
|
|
static void bmg160_spi_remove(struct spi_device *spi)
|
|
{
|
|
bmg160_core_remove(&spi->dev);
|
|
}
|
|
|
|
static const struct spi_device_id bmg160_spi_id[] = {
|
|
{"bmg160", 0},
|
|
{"bmi055_gyro", 0},
|
|
{"bmi088_gyro", 0},
|
|
{}
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(spi, bmg160_spi_id);
|
|
|
|
static struct spi_driver bmg160_spi_driver = {
|
|
.driver = {
|
|
.name = "bmg160_spi",
|
|
.pm = &bmg160_pm_ops,
|
|
},
|
|
.probe = bmg160_spi_probe,
|
|
.remove = bmg160_spi_remove,
|
|
.id_table = bmg160_spi_id,
|
|
};
|
|
module_spi_driver(bmg160_spi_driver);
|
|
|
|
MODULE_AUTHOR("Markus Pargmann <mpa@pengutronix.de>");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_DESCRIPTION("BMG160 SPI Gyro driver");
|