Ido Schimmel 1e74500f99 bridge: Avoid infinite loop when suppressing NS messages with invalid options ... [ Upstream commit 53fc685243 ] When neighbor suppression is enabled the bridge device might reply to Neighbor Solicitation (NS) messages on behalf of remote hosts. In case the NS message includes the "Source link-layer address" option [1], the bridge device will use the specified address as the link-layer destination address in its reply. To avoid an infinite loop, break out of the options parsing loop when encountering an option with length zero and disregard the NS message. This is consistent with the IPv6 ndisc code and RFC 4886 which states that "Nodes MUST silently discard an ND packet that contains an option with length zero" [2]. [1] https://tools.ietf.org/html/rfc4861#section-4.3 [2] https://tools.ietf.org/html/rfc4861#section-4.6 Fixes: ed842faeb2 ("bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports") Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reported-by: Alla Segal <allas@mellanox.com> Tested-by: Alla Segal <allas@mellanox.com> Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-06-22 09:04:58 +02:00
..
6lowpan	6lowpan: Off by one handling ->nexthdr	2020-01-27 14:50:41 +01:00
9p	9p: Transport error uninitialized	2019-10-11 18:21:12 +02:00
802
8021q	vlan: vlan_changelink() should propagate errors	2020-01-12 12:17:28 +01:00
appletalk	appletalk: Set error code if register_snap_client failed	2019-12-13 08:52:59 +01:00
atm	net: use skb_queue_empty_lockless() in poll() handlers	2019-11-10 11:27:48 +01:00
ax25	ax25: fix setsockopt(SO_BINDTODEVICE)	2020-06-03 08:19:02 +02:00
batman-adv	batman-adv: Fix refcnt leak in batadv_v_ogm_process	2020-05-14 07:57:22 +02:00
bluetooth	Bluetooth: RFCOMM: fix ODEBUG bug in rfcomm_dev_ioctl	2020-04-13 10:45:14 +02:00
bpf
bpfilter	signal/bpfilter: Fix bpfilter_kernl to use send_sig not force_sig	2020-01-27 14:50:51 +01:00
bridge	bridge: Avoid infinite loop when suppressing NS messages with invalid options	2020-06-22 09:04:58 +02:00
caif	net: use skb_queue_empty_lockless() in poll() handlers	2019-11-10 11:27:48 +01:00
can	can: gw: Fix error path of cgw_module_init	2019-08-29 08:28:30 +02:00
ceph	libceph: ignore pool overlay and cache logic on redirects	2020-06-03 08:19:39 +02:00
core	__netif_receive_skb_core: pass skb by reference	2020-06-03 08:19:05 +02:00
dcb
dccp	net: ipv6: add net argument to ip6_dst_lookup_flow	2020-04-29 16:31:16 +02:00
decnet	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2020-01-04 19:13:37 +01:00
dns_resolver	KEYS: Don't write out to userspace while holding key semaphore	2020-04-23 10:30:24 +02:00
dsa	net: dsa: mt7530: fix roaming from DSA user ports	2020-06-03 08:19:03 +02:00
ethernet	net: add annotations on hh->hh_len lockless accesses	2020-01-09 10:19:09 +01:00
hsr	hsr: check protocol version in hsr_newlink()	2020-04-21 09:03:03 +02:00
ieee802154	nl802154: add missing attribute validation for dev_type	2020-03-18 07:14:15 +01:00
ife
ipv4	devinet: fix memleak in inetdev_init()	2020-06-10 21:34:58 +02:00
ipv6	ipv6: fix IPV6_ADDRFORM operation logic	2020-06-22 09:04:58 +02:00
iucv	net/af_iucv: always register net_device notifier	2020-01-27 14:50:56 +01:00
kcm
key	af_key: fix leaks in key_pol_get_resp and dump_sp.	2019-07-26 09:14:01 +02:00
l2tp	l2tp: do not use inet_hash()/inet_unhash()	2020-06-10 21:34:58 +02:00
l3mdev
lapb	lapb: fixed leak of control-blocks.	2019-06-22 08:15:13 +02:00
llc	llc: fix sk_buff refcounting in llc_conn_state_process()	2020-01-27 14:51:17 +01:00
mac80211	mac80211: mesh: fix discovery timer re-arming issue / crash	2020-06-03 08:19:43 +02:00
mac802154
mpls	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2020-04-29 16:31:17 +02:00
ncsi
netfilter	netfilter: nf_conntrack_pptp: fix compilation warning with W=1 build	2020-06-03 08:19:49 +02:00
netlabel	netlabel: cope with NULL catmap	2020-05-20 08:18:35 +02:00
netlink	netlink: Use netlink header as base to calculate bad attribute offset	2020-03-18 07:14:12 +01:00
netrom	net: netrom: Fix potential nr_neigh refcnt leak in nr_add_node	2020-04-29 16:31:21 +02:00
nfc	nfc: add missing attribute validation for vendor subcommand	2020-03-18 07:14:17 +01:00
nsh
openvswitch	openvswitch: support asymmetric conntrack	2019-12-21 10:57:14 +01:00
packet	net/packet: tpacket_rcv: avoid a producer race condition	2020-04-02 15:28:11 +02:00
phonet	net: use skb_queue_empty_lockless() in poll() handlers	2019-11-10 11:27:48 +01:00
psample	net: psample: fix skb_over_panic	2019-12-05 09:21:30 +01:00
qrtr	net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()	2020-06-03 08:19:12 +02:00
rds	net/rds: Fix 'ib_evt_handler_call' element in 'rds_ib_stat_names'	2020-01-27 14:51:13 +01:00
rfkill	rfkill: Fix incorrect check to avoid NULL pointer dereference	2020-01-12 12:17:17 +01:00
rose	net/rose: fix unbound loop in rose_loopback_timer()	2019-05-02 09:59:00 +02:00
rxrpc	rxrpc: Fix ack discard	2020-05-27 17:37:46 +02:00
sched	sch_sfq: validate silly quantum values	2020-05-14 07:57:18 +02:00
sctp	sctp: Start shutdown on association restart if in SHUTDOWN-SENT state and socket is closed	2020-06-03 08:19:23 +02:00
smc	net/smc: cancel event worker during device removal	2020-03-18 07:14:25 +01:00
strparser	net: strparser: partially revert "strparser: Call skb_unclone conditionally"	2019-05-16 19:41:27 +02:00
sunrpc	svcrdma: Fix leak of svc_rdma_recv_ctxt objects	2020-05-02 17:25:52 +02:00
switchdev
tipc	tipc: fix partial topology connection closure	2020-05-14 07:57:18 +02:00
tls	net/tls: Fix to avoid gettig invalid tls record	2020-03-05 16:42:17 +01:00
unix	af_unix: add compat_ioctl support	2020-01-17 19:47:07 +01:00
vmw_vsock	vsock: fix timeout in vsock_accept()	2020-06-10 21:34:59 +02:00
wimax
wireless	nl80211: fix NL80211_ATTR_CHANNEL_WIDTH attribute type	2020-04-02 15:28:17 +02:00
x25	net/x25: Fix x25_neigh refcnt leak when receiving frame	2020-04-29 16:31:21 +02:00
xdp	xsk: Add overflow check for u64 division, stored into u32	2020-06-03 08:19:48 +02:00
xfrm	xfrm: fix a NULL-ptr deref in xfrm_local_error	2020-06-03 08:19:45 +02:00
compat.c
Kconfig
Makefile
socket.c	compat_ioctl: handle SIOCOUTQNSD	2020-01-17 19:47:07 +01:00
sysctl_net.c