mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-01 22:54:01 +00:00
Code Issues Releases Wiki Activity
linux-stable/drivers/net/ethernet/amd
History
Arnd Bergmann bbe6418663 amd-xgbe: fix mismatched prototype 
The forward declaration was introduced with a prototype that does
not match the function definition:

drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c:2166:13: error: conflicting types for 'xgbe_phy_perform_ratechange' due to enum/integer mismatch; have 'void(struct xgbe_prv_data *, enum xgbe_mb_cmd,  enum xgbe_mb_subcmd)' [-Werror=enum-int-mismatch]
 2166 | static void xgbe_phy_perform_ratechange(struct xgbe_prv_data *pdata,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c:391:13: note: previous declaration of 'xgbe_phy_perform_ratechange' with type 'void(struct xgbe_prv_data *, unsigned int,  unsigned int)'
  391 | static void xgbe_phy_perform_ratechange(struct xgbe_prv_data *pdata,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Ideally there should not be any forward declarations here, which
would make it easier to show that there is no unbounded recursion.
I tried fixing this but could not figure out how to avoid the
recursive call.

As a hotfix, address only the broken prototype to fix the build
problem instead.

Fixes: 4f3b20bfbb ("amd-xgbe: add support for rx-adaptation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20230203121553.2871598-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-02-06 22:33:18 -08:00
..
xgbe amd-xgbe: fix mismatched prototype 2023-02-06 22:33:18 -08:00
7990.c
7990.h
a2065.c net: amd: Unified the comparison between pointers and NULL to the same writing 2022-09-16 10:27:47 +01:00
a2065.h
amd8111e.c net: amd: Switch and case should be at the same indent 2022-09-16 10:27:47 +01:00
amd8111e.h net: amd: Correct spelling errors 2022-09-16 10:27:47 +01:00
ariadne.c net: amd: Unified the comparison between pointers and NULL to the same writing 2022-09-16 10:27:47 +01:00
ariadne.h
atarilance.c net: amd: lance: don't call dev_kfree_skb() under spin_lock_irqsave() 2022-12-12 09:56:17 +00:00
au1000_eth.c net: amd: Unified the comparison between pointers and NULL to the same writing 2022-09-16 10:27:47 +01:00
au1000_eth.h au1000_eth: stop using virt_to_bus() 2022-06-08 11:32:02 -07:00
declance.c amd: declance: use eth_hw_addr_set() 2022-01-25 09:00:53 -08:00
hplance.c amd: hplance: use eth_hw_addr_set() 2021-11-19 11:05:20 +00:00
hplance.h
Kconfig eth: amd: remove NI6510 support (ni65) 2022-05-11 13:09:59 +01:00
lance.c net: amd: lance: don't call dev_kfree_skb() under spin_lock_irqsave() 2022-12-12 09:56:17 +00:00
Makefile eth: amd: remove NI6510 support (ni65) 2022-05-11 13:09:59 +01:00
mvme147.c amd: mvme147: use eth_hw_addr_set() 2021-11-19 11:05:20 +00:00
nmclan_cs.c net: amd: Switch and case should be at the same indent 2022-09-16 10:27:47 +01:00
pcnet32.c net: amd: Unified the comparison between pointers and NULL to the same writing 2022-09-16 10:27:47 +01:00
sun3lance.c net: amd: Unified the comparison between pointers and NULL to the same writing 2022-09-16 10:27:47 +01:00
sunlance.c net: amd: Unified the comparison between pointers and NULL to the same writing 2022-09-16 10:27:47 +01:00