linux-stable/drivers/net/ethernet/qualcomm
Zheng Wang 6b6bc5b8bd net: qcom/emac: Fix use after free bug in emac_remove due to race condition
In emac_probe, &adpt->work_thread is bound with
emac_work_thread. Then it will be started by timeout
handler emac_tx_timeout or a IRQ handler emac_isr.

If we remove the driver which will call emac_remove
  to make cleanup, there may be a unfinished work.

The possible sequence is as follows:

Fix it by finishing the work before cleanup in the emac_remove
and disable timeout response.

CPU0                  CPU1

                    |emac_work_thread
emac_remove         |
free_netdev         |
kfree(netdev);      |
                    |emac_reinit_locked
                    |emac_mac_down
                    |//use netdev
Fixes: b9b17debc6 ("net: emac: emac gigabit ethernet controller driver")
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>

Signed-off-by: David S. Miller <davem@davemloft.net>
2023-03-20 09:11:18 +00:00
..
emac net: qcom/emac: Fix use after free bug in emac_remove due to race condition 2023-03-20 09:11:18 +00:00
rmnet net: qualcomm: rmnet: add ethtool support for configuring tx aggregation 2023-01-13 10:23:52 +00:00
Kconfig
Makefile
qca_7k.c
qca_7k.h
qca_7k_common.c
qca_7k_common.h
qca_debug.c net: ethernet: move from strlcpy with unused retval to strscpy 2022-08-31 14:11:26 -07:00
qca_debug.h
qca_spi.c net: ethernet: Use netif_rx(). 2022-03-04 12:02:19 +00:00
qca_spi.h net: qca_spi: Introduce stat about bad signature 2021-05-10 14:29:18 -07:00
qca_uart.c net: ethernet: Use netif_rx(). 2022-03-04 12:02:19 +00:00