mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-19 17:11:03 +00:00
138060ba92
The current way of setting and getting posix acls through the generic xattr interface is error prone and type unsafe. The vfs needs to interpret and fixup posix acls before storing or reporting it to userspace. Various hacks exist to make this work. The code is hard to understand and difficult to maintain in it's current form. Instead of making this work by hacking posix acls through xattr handlers we are building a dedicated posix acl api around the get and set inode operations. This removes a lot of hackiness and makes the codepaths easier to maintain. A lot of background can be found in [1]. Since some filesystem rely on the dentry being available to them when setting posix acls (e.g., 9p and cifs) they cannot rely on set acl inode operation. But since ->set_acl() is required in order to use the generic posix acl xattr handlers filesystems that do not implement this inode operation cannot use the handler and need to implement their own dedicated posix acl handlers. Update the ->set_acl() inode method to take a dentry argument. This allows all filesystems to rely on ->set_acl(). As far as I can tell all codepaths can be switched to rely on the dentry instead of just the inode. Note that the original motivation for passing the dentry separate from the inode instead of just the dentry in the xattr handlers was because of security modules that call security_d_instantiate(). This hook is called during d_instantiate_new(), d_add(), __d_instantiate_anon(), and d_splice_alias() to initialize the inode's security context and possibly to set security.* xattrs. Since this only affects security.* xattrs this is completely irrelevant for posix acls. Link: https://lore.kernel.org/all/20220801145520.1532837-1-brauner@kernel.org [1] Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
78 lines
1.9 KiB
C
78 lines
1.9 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#include <linux/init.h>
|
|
#include <linux/posix_acl.h>
|
|
|
|
#define REISERFS_ACL_VERSION 0x0001
|
|
|
|
typedef struct {
|
|
__le16 e_tag;
|
|
__le16 e_perm;
|
|
__le32 e_id;
|
|
} reiserfs_acl_entry;
|
|
|
|
typedef struct {
|
|
__le16 e_tag;
|
|
__le16 e_perm;
|
|
} reiserfs_acl_entry_short;
|
|
|
|
typedef struct {
|
|
__le32 a_version;
|
|
} reiserfs_acl_header;
|
|
|
|
static inline size_t reiserfs_acl_size(int count)
|
|
{
|
|
if (count <= 4) {
|
|
return sizeof(reiserfs_acl_header) +
|
|
count * sizeof(reiserfs_acl_entry_short);
|
|
} else {
|
|
return sizeof(reiserfs_acl_header) +
|
|
4 * sizeof(reiserfs_acl_entry_short) +
|
|
(count - 4) * sizeof(reiserfs_acl_entry);
|
|
}
|
|
}
|
|
|
|
static inline int reiserfs_acl_count(size_t size)
|
|
{
|
|
ssize_t s;
|
|
size -= sizeof(reiserfs_acl_header);
|
|
s = size - 4 * sizeof(reiserfs_acl_entry_short);
|
|
if (s < 0) {
|
|
if (size % sizeof(reiserfs_acl_entry_short))
|
|
return -1;
|
|
return size / sizeof(reiserfs_acl_entry_short);
|
|
} else {
|
|
if (s % sizeof(reiserfs_acl_entry))
|
|
return -1;
|
|
return s / sizeof(reiserfs_acl_entry) + 4;
|
|
}
|
|
}
|
|
|
|
#ifdef CONFIG_REISERFS_FS_POSIX_ACL
|
|
struct posix_acl *reiserfs_get_acl(struct inode *inode, int type, bool rcu);
|
|
int reiserfs_set_acl(struct user_namespace *mnt_userns, struct dentry *dentry,
|
|
struct posix_acl *acl, int type);
|
|
int reiserfs_acl_chmod(struct dentry *dentry);
|
|
int reiserfs_inherit_default_acl(struct reiserfs_transaction_handle *th,
|
|
struct inode *dir, struct dentry *dentry,
|
|
struct inode *inode);
|
|
int reiserfs_cache_default_acl(struct inode *dir);
|
|
|
|
#else
|
|
|
|
#define reiserfs_cache_default_acl(inode) 0
|
|
#define reiserfs_get_acl NULL
|
|
#define reiserfs_set_acl NULL
|
|
|
|
static inline int reiserfs_acl_chmod(struct dentry *dentry)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int
|
|
reiserfs_inherit_default_acl(struct reiserfs_transaction_handle *th,
|
|
const struct inode *dir, struct dentry *dentry,
|
|
struct inode *inode)
|
|
{
|
|
return 0;
|
|
}
|
|
#endif
|