Randall Huang 1d295b32df f2fs: fix to avoid accessing xattr across the boundary ... commit 2777e65437 upstream. When we traverse xattr entries via __find_xattr(), if the raw filesystem content is faked or any hardware failure occurs, out-of-bound error can be detected by KASAN. Fix the issue by introducing boundary check. [ 38.402878] c7 1827 BUG: KASAN: slab-out-of-bounds in f2fs_getxattr+0x518/0x68c [ 38.402891] c7 1827 Read of size 4 at addr ffffffc0b6fb35dc by task [ 38.402935] c7 1827 Call trace: [ 38.402952] c7 1827 [<ffffff900809003c>] dump_backtrace+0x0/0x6bc [ 38.402966] c7 1827 [<ffffff9008090030>] show_stack+0x20/0x2c [ 38.402981] c7 1827 [<ffffff900871ab10>] dump_stack+0xfc/0x140 [ 38.402995] c7 1827 [<ffffff9008325c40>] print_address_description+0x80/0x2d8 [ 38.403009] c7 1827 [<ffffff900832629c>] kasan_report_error+0x198/0x1fc [ 38.403022] c7 1827 [<ffffff9008326104>] kasan_report_error+0x0/0x1fc [ 38.403037] c7 1827 [<ffffff9008325000>] __asan_load4+0x1b0/0x1b8 [ 38.403051] c7 1827 [<ffffff90085fcc44>] f2fs_getxattr+0x518/0x68c [ 38.403066] c7 1827 [<ffffff90085fc508>] f2fs_xattr_generic_get+0xb0/0xd0 [ 38.403080] c7 1827 [<ffffff9008395708>] __vfs_getxattr+0x1f4/0x1fc [ 38.403096] c7 1827 [<ffffff9008621bd0>] inode_doinit_with_dentry+0x360/0x938 [ 38.403109] c7 1827 [<ffffff900862d6cc>] selinux_d_instantiate+0x2c/0x38 [ 38.403123] c7 1827 [<ffffff900861b018>] security_d_instantiate+0x68/0x98 [ 38.403136] c7 1827 [<ffffff9008377db8>] d_splice_alias+0x58/0x348 [ 38.403149] c7 1827 [<ffffff900858d16c>] f2fs_lookup+0x608/0x774 [ 38.403163] c7 1827 [<ffffff900835eacc>] lookup_slow+0x1e0/0x2cc [ 38.403177] c7 1827 [<ffffff9008367fe0>] walk_component+0x160/0x520 [ 38.403190] c7 1827 [<ffffff9008369ef4>] path_lookupat+0x110/0x2b4 [ 38.403203] c7 1827 [<ffffff900835dd38>] filename_lookup+0x1d8/0x3a8 [ 38.403216] c7 1827 [<ffffff900835eeb0>] user_path_at_empty+0x54/0x68 [ 38.403229] c7 1827 [<ffffff9008395f44>] SyS_getxattr+0xb4/0x18c [ 38.403241] c7 1827 [<ffffff9008084200>] el0_svc_naked+0x34/0x38 Signed-off-by: Randall Huang <huangrandall@google.com> [Jaegeuk Kim: Fix wrong ending boundary] Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> [bwh: Backported to 4.14: adjust context] Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-05-20 08:17:04 +02:00
..
acl.c	f2fs: fix wrong return value of f2fs_acl_create	2019-02-12 19:46:00 +01:00
acl.h
checkpoint.c	f2fs: use generic EFSBADCRC/EFSCORRUPTED	2019-10-05 12:47:39 +02:00
data.c	f2fs: fix potential overflow	2020-01-17 19:45:52 +01:00
debug.c	f2fs: show available_nids in f2fs/status	2017-05-03 10:04:57 -07:00
dir.c	f2fs: fix to spread clear_cold_data()	2019-12-01 09:13:44 +01:00
extent_cache.c	f2fs: fix to check extent cache in f2fs_drop_extent_tree	2018-05-30 07:52:33 +02:00
f2fs.h	f2fs: use generic EFSBADCRC/EFSCORRUPTED	2019-10-05 12:47:39 +02:00
file.c	f2fs: fix potential overflow	2020-01-17 19:45:52 +01:00
gc.c	f2fs: fix to allow node segment for GC by ioctl path	2019-12-17 20:38:12 +01:00
gc.h	f2fs: fix potential overflow when adjusting GC cycle	2017-08-15 10:40:14 -07:00
hash.c	f2fs: check entire encrypted bigname when finding a dentry	2017-05-04 11:44:35 -04:00
inline.c	f2fs: use generic EFSBADCRC/EFSCORRUPTED	2019-10-05 12:47:39 +02:00
inode.c	f2fs: use generic EFSBADCRC/EFSCORRUPTED	2019-10-05 12:47:39 +02:00
Kconfig
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
namei.c	f2fs: fix to update dir's i_pino during cross_rename	2020-01-04 13:59:41 +01:00
node.c	f2fs: use generic EFSBADCRC/EFSCORRUPTED	2019-10-05 12:47:39 +02:00
node.h	f2fs: simplify the way of calulating next nat address	2017-07-04 02:11:34 -07:00
recovery.c	f2fs: mark inode dirty explicitly in recover_inode()	2019-11-20 18:00:45 +01:00
segment.c	f2fs: fix to spread clear_cold_data()	2019-12-01 09:13:44 +01:00
segment.h	f2fs: use generic EFSBADCRC/EFSCORRUPTED	2019-10-05 12:47:39 +02:00
shrinker.c	f2fs: fix sbi->extent_list corruption issue	2019-02-12 19:46:08 +01:00
super.c	f2fs: code cleanup for f2fs_statfs_project()	2020-02-14 16:32:12 -05:00
sysfs.c	f2fs: fix memleak of kobject	2020-02-28 16:36:05 +01:00
trace.c	f2fs: do not use mutex lock in atomic context	2019-04-05 22:31:27 +02:00
trace.h
xattr.c	f2fs: fix to avoid accessing xattr across the boundary	2020-05-20 08:17:04 +02:00
xattr.h	f2fs: fix to avoid accessing xattr across the boundary	2020-05-20 08:17:04 +02:00