mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
![Chris Lu](/assets/img/avatar_default.png)
There may be a potential kernel crash risk if 'skb->len - MTK_COREDUMP_END_LEN' value is less than 0 when doing memcmp in btmtk_process_coredump(). Check the value is valid before doing memcmp. [215.021695] Unable to handle kernel paging request at virtual address ffffff939fffd3c5 [215.021781] Mem abort info: [215.021805] ESR = 0x96000005 [215.021833] EC = 0x25: DABT (current EL), IL = 32 bits [215.021861] SET = 0, FnV = 0 [215.021875] EA = 0, S1PTW = 0 [215.021886] Data abort info: [215.021899] ISV = 0, ISS = 0x00000005 [215.021912] CM = 0, WnR = 0 [215.021929] swapper pgtable: 4k pages, 39-bit VAs, pgdp=00000000410de000 [215.021943] [ffffff939fffd3c5] pgd=0000000000000000, p4d=0000000000000000, pud=0000000000000000 [215.021979] Internal error: Oops: 96000005 [#1] PREEMPT SMP [215.022496] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.10.186#3 (HASH:ad23 4) [215.022511] Hardware name: MediaTek Tomato board (DT) [215.022530] pstate: 80400009 (Nzcv daif +PAN -UAO -TCO BTYPE=--) [215.022556] pc : __pi_memcmp+0xd0/0x1b8 [215.022579] lr : btmtk_process_coredump+0xb0/0x5f8 [btmtk] [215.022593] sp : ffffffc010003d40 [215.022607] x29: ffffffc010003d40 x28: 0000000000000006 [215.022633] x27: ffffffda696350c0 x26: 0000000000000002 [215.022659] x25: 00000000000003ff x24: ffffff9360cca804 [215.022685] x23: 0000000000000000 x22: ffffff9365638500 [215.022710] x21: ffffff9365638700 x20: 0000000000000000 [215.022736] x19: ffffff936002e000 x18: 0000000000000000 [215.022761] x17: 0000000000000180 x16: ffffffda6881b8b4 [215.022787] x15: 0000000000000001 x14: 0000000000002d00 [215.022812] x13: 0000000000060000 x12: 0000000000000181 [215.022837] x11: 0000000000000006 x10: fffffffffffffffd [215.022862] x9 : 0000000000000006 x8 : 0000000000000003 [215.022887] x7 : 0000000000000000 x6 : 0000000000000000 [215.022913] x5 : ffffff93656387b8 x4 : 0000000000000000 [215.022938] x3 : ffffffc010003c18 x2 : 0000000000000006 [215.022963] x1 : ffffffda09d4124a x0 : ffffff939fffd3c5 [215.022989] Call trace: [215.023012] __pi_memcmp+0xd0/0x1b8 [215.023053] btusb_recv_acl_mtk+0x64/0x90 [btusb (HASH:dc6b 5)] [215.023087] btusb_recv_bulk+0x118/0x170 [btusb (HASH:dc6b 5)] [215.023121] btusb_bulk_complete+0x8c/0x148 [btusb (HASH:dc6b 5)] [215.023144] __usb_hcd_giveback_urb+0xbc/0x148 [215.023164] usb_giveback_urb_bh+0xb4/0x190 [215.023184] tasklet_action_common+0x98/0x1a0 [215.023201] tasklet_action+0x2c/0x38 [215.023220] __do_softirq+0xe0/0x38c [215.023241] invoke_softirq+0x34/0x6c [215.023258] irq_exit+0x6c/0xb0 [215.023279] __handle_domain_irq+0x98/0xd4 [215.023296] gic_handle_irq+0x5c/0x11c [215.023313] el1_irq+0xd0/0x180 [215.023332] cpuidle_enter_state+0xac/0x338 [215.023349] cpuidle_enter+0x40/0x70 [215.023366] do_idle+0x150/0x278 [215.023384] cpu_startup_entry+0x2c/0x58 [215.023401] rest_init+0xdc/0xec [215.023419] arch_call_rest_init+0x18/0x24 [215.023435] start_kernel+0x334/0x400 [215.023460] Code: 91002129 eb09010a 9a89810b cb0b0042 (38401403) [215.023478] ---[ end trace 28668fd20c7a90cd ] Fixes: 2822cd0173ad ("Bluetooth: btusb: mediatek: add MediaTek devcoredump support") Signed-off-by: Chris Lu <chris.lu@mediatek.com> Co-developed-by: Sean Wang <sean.wang@mediatek.com> Signed-off-by: Sean Wang <sean.wang@mediatek.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
196 lines
3.9 KiB
C
196 lines
3.9 KiB
C
/* SPDX-License-Identifier: ISC */
|
|
/* Copyright (C) 2021 MediaTek Inc. */
|
|
|
|
#define FIRMWARE_MT7622 "mediatek/mt7622pr2h.bin"
|
|
#define FIRMWARE_MT7663 "mediatek/mt7663pr2h.bin"
|
|
#define FIRMWARE_MT7668 "mediatek/mt7668pr2h.bin"
|
|
#define FIRMWARE_MT7961 "mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin"
|
|
#define FIRMWARE_MT7925 "mediatek/mt7925/BT_RAM_CODE_MT7925_1_1_hdr.bin"
|
|
|
|
#define HCI_EV_WMT 0xe4
|
|
#define HCI_WMT_MAX_EVENT_SIZE 64
|
|
|
|
#define BTMTK_WMT_REG_WRITE 0x1
|
|
#define BTMTK_WMT_REG_READ 0x2
|
|
|
|
#define MT7921_BTSYS_RST 0x70002610
|
|
#define MT7921_BTSYS_RST_WITH_GPIO BIT(7)
|
|
|
|
#define MT7921_PINMUX_0 0x70005050
|
|
#define MT7921_PINMUX_1 0x70005054
|
|
|
|
#define MT7921_DLSTATUS 0x7c053c10
|
|
#define BT_DL_STATE BIT(1)
|
|
|
|
#define MTK_COREDUMP_SIZE (1024 * 1000)
|
|
#define MTK_COREDUMP_END "coredump end"
|
|
#define MTK_COREDUMP_END_LEN (sizeof(MTK_COREDUMP_END))
|
|
#define MTK_COREDUMP_NUM 255
|
|
|
|
enum {
|
|
BTMTK_WMT_PATCH_DWNLD = 0x1,
|
|
BTMTK_WMT_TEST = 0x2,
|
|
BTMTK_WMT_WAKEUP = 0x3,
|
|
BTMTK_WMT_HIF = 0x4,
|
|
BTMTK_WMT_FUNC_CTRL = 0x6,
|
|
BTMTK_WMT_RST = 0x7,
|
|
BTMTK_WMT_REGISTER = 0x8,
|
|
BTMTK_WMT_SEMAPHORE = 0x17,
|
|
};
|
|
|
|
enum {
|
|
BTMTK_WMT_INVALID,
|
|
BTMTK_WMT_PATCH_UNDONE,
|
|
BTMTK_WMT_PATCH_PROGRESS,
|
|
BTMTK_WMT_PATCH_DONE,
|
|
BTMTK_WMT_ON_UNDONE,
|
|
BTMTK_WMT_ON_DONE,
|
|
BTMTK_WMT_ON_PROGRESS,
|
|
};
|
|
|
|
struct btmtk_wmt_hdr {
|
|
u8 dir;
|
|
u8 op;
|
|
__le16 dlen;
|
|
u8 flag;
|
|
} __packed;
|
|
|
|
struct btmtk_hci_wmt_cmd {
|
|
struct btmtk_wmt_hdr hdr;
|
|
u8 data[];
|
|
} __packed;
|
|
|
|
struct btmtk_hci_wmt_evt {
|
|
struct hci_event_hdr hhdr;
|
|
struct btmtk_wmt_hdr whdr;
|
|
} __packed;
|
|
|
|
struct btmtk_hci_wmt_evt_funcc {
|
|
struct btmtk_hci_wmt_evt hwhdr;
|
|
__be16 status;
|
|
} __packed;
|
|
|
|
struct btmtk_hci_wmt_evt_reg {
|
|
struct btmtk_hci_wmt_evt hwhdr;
|
|
u8 rsv[2];
|
|
u8 num;
|
|
__le32 addr;
|
|
__le32 val;
|
|
} __packed;
|
|
|
|
struct btmtk_tci_sleep {
|
|
u8 mode;
|
|
__le16 duration;
|
|
__le16 host_duration;
|
|
u8 host_wakeup_pin;
|
|
u8 time_compensation;
|
|
} __packed;
|
|
|
|
struct btmtk_wakeon {
|
|
u8 mode;
|
|
u8 gpo;
|
|
u8 active_high;
|
|
__le16 enable_delay;
|
|
__le16 wakeup_delay;
|
|
} __packed;
|
|
|
|
struct btmtk_sco {
|
|
u8 clock_config;
|
|
u8 transmit_format_config;
|
|
u8 channel_format_config;
|
|
u8 channel_select_config;
|
|
} __packed;
|
|
|
|
struct reg_read_cmd {
|
|
u8 type;
|
|
u8 rsv;
|
|
u8 num;
|
|
__le32 addr;
|
|
} __packed;
|
|
|
|
struct reg_write_cmd {
|
|
u8 type;
|
|
u8 rsv;
|
|
u8 num;
|
|
__le32 addr;
|
|
__le32 data;
|
|
__le32 mask;
|
|
} __packed;
|
|
|
|
struct btmtk_hci_wmt_params {
|
|
u8 op;
|
|
u8 flag;
|
|
u16 dlen;
|
|
const void *data;
|
|
u32 *status;
|
|
};
|
|
|
|
typedef int (*btmtk_reset_sync_func_t)(struct hci_dev *, void *);
|
|
|
|
struct btmtk_coredump_info {
|
|
const char *driver_name;
|
|
u32 fw_version;
|
|
u16 cnt;
|
|
int state;
|
|
};
|
|
|
|
struct btmediatek_data {
|
|
u32 dev_id;
|
|
btmtk_reset_sync_func_t reset_sync;
|
|
struct btmtk_coredump_info cd_info;
|
|
};
|
|
|
|
typedef int (*wmt_cmd_sync_func_t)(struct hci_dev *,
|
|
struct btmtk_hci_wmt_params *);
|
|
|
|
#if IS_ENABLED(CONFIG_BT_MTK)
|
|
|
|
int btmtk_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr);
|
|
|
|
int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname,
|
|
wmt_cmd_sync_func_t wmt_cmd_sync);
|
|
|
|
int btmtk_setup_firmware(struct hci_dev *hdev, const char *fwname,
|
|
wmt_cmd_sync_func_t wmt_cmd_sync);
|
|
|
|
void btmtk_reset_sync(struct hci_dev *hdev);
|
|
|
|
int btmtk_register_coredump(struct hci_dev *hdev, const char *name,
|
|
u32 fw_version);
|
|
|
|
int btmtk_process_coredump(struct hci_dev *hdev, struct sk_buff *skb);
|
|
#else
|
|
|
|
static inline int btmtk_set_bdaddr(struct hci_dev *hdev,
|
|
const bdaddr_t *bdaddr)
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
static int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname,
|
|
wmt_cmd_sync_func_t wmt_cmd_sync)
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
static int btmtk_setup_firmware(struct hci_dev *hdev, const char *fwname,
|
|
wmt_cmd_sync_func_t wmt_cmd_sync)
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
static void btmtk_reset_sync(struct hci_dev *hdev)
|
|
{
|
|
}
|
|
|
|
static int btmtk_register_coredump(struct hci_dev *hdev, const char *name,
|
|
u32 fw_version)
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
static int btmtk_process_coredump(struct hci_dev *hdev, struct sk_buff *skb)
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
#endif
|