Riccardo Paolo Bestetti 4952c7df63 ipv4: ping: fix bind address validity check ... commit b4a028c4d0 upstream. Commit 8ff978b8b2 ("ipv4/raw: support binding to nonlocal addresses") introduced a helper function to fold duplicated validity checks of bind addresses into inet_addr_valid_or_nonlocal(). However, this caused an unintended regression in ping_check_bind_addr(), which previously would reject binding to multicast and broadcast addresses, but now these are both incorrectly allowed as reported in [1]. This patch restores the original check. A simple reordering is done to improve readability and make it evident that multicast and broadcast addresses should not be allowed. Also, add an early exit for INADDR_ANY which replaces lost behavior added by commit 0ce779a9f5 ("net: Avoid unnecessary inet_addr_type() call when addr is INADDR_ANY"). Furthermore, this patch introduces regression selftests to catch these specific cases. [1] https://lore.kernel.org/netdev/CANP3RGdkAcDyAZoT1h8Gtuu0saq+eOrrTiWbxnOs+5zn+cpyKg@mail.gmail.com/ Fixes: 8ff978b8b2 ("ipv4/raw: support binding to nonlocal addresses") Cc: Miaohe Lin <linmiaohe@huawei.com> Reported-by: Maciej Żenczykowski <maze@google.com> Signed-off-by: Carlos Llamas <cmllamas@google.com> Signed-off-by: Riccardo Paolo Bestetti <pbl@bestov.io> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-06-29 09:04:25 +02:00
..
accounting
arch	KVM: x86/speculation: Disable Fill buffer clear within guests	2022-06-16 13:32:05 +02:00
bootconfig
bpf	Networking fixes for 5.18-rc2, including fixes from bpf and netfilter	2022-04-07 19:01:47 -10:00
build	perf build: Fix btf__load_from_kernel_by_id() feature check	2022-06-09 10:30:38 +02:00
cgroup	tools/cgroup/slabinfo: update to work with struct slab	2022-02-21 11:34:49 +01:00
counter
debugging
edid
firewire
firmware
gpio
hv
iio	Kbuild updates for v5.18	2022-03-31 11:59:03 -07:00
include	x86/ftrace: Remove OBJECT_FILES_NON_STANDARD usage	2022-06-22 14:28:03 +02:00
io_uring
kvm/kvm_stat
laptop
leds
lib	libbpf: Fix logic for finding matching program for CO-RE relocation	2022-06-09 10:30:03 +02:00
memory-model	tools/memory-model/README: Update klitmus7 compat table	2022-06-06 08:48:56 +02:00
objtool	objtool: Mark __ubsan_handle_builtin_unreachable() as noreturn	2022-06-14 18:45:13 +02:00
pci
pcmcia
perf	perf c2c: Fix sorting in percent_rmt_hitm_cmp()	2022-06-14 18:45:00 +02:00
power	tools/power turbostat: fix ICX DRAM power numbers	2022-06-09 10:29:35 +02:00
rcu
scripts	Kbuild updates for v5.18	2022-03-31 11:59:03 -07:00
spi
testing	ipv4: ping: fix bind address validity check	2022-06-29 09:04:25 +02:00
thermal/tmon
time
tracing	rtla/Makefile: Properly handle dependencies	2022-06-14 18:45:03 +02:00
usb
virtio	tools/virtio: compile with -pthread	2022-03-28 16:52:59 -04:00
vm	tools/vm/page_owner_sort.c: remove -c option	2022-04-01 11:46:09 -07:00
wmi
Makefile