mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
![Kees Cook](/assets/img/avatar_default.png)
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc(). This patch replaces cases of: devm_kzalloc(handle, a * b, gfp) with: devm_kcalloc(handle, a * b, gfp) as well as handling cases of: devm_kzalloc(handle, a * b * c, gfp) with: devm_kzalloc(handle, array3_size(a, b, c), gfp) as it's slightly less ugly than: devm_kcalloc(handle, array_size(a, b), c, gfp) This does, however, attempt to ignore constant size factors like: devm_kzalloc(handle, 4 * 1024, gfp) though any constants defined via macros get caught up in the conversion. Any factors with a sizeof() of "unsigned char", "char", and "u8" were dropped, since they're redundant. Some manual whitespace fixes were needed in this patch, as Coccinelle really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...". The Coccinelle script used for this was: // Fix redundant parens around sizeof(). @@ expression HANDLE; type TYPE; expression THING, E; @@ ( devm_kzalloc(HANDLE, - (sizeof(TYPE)) * E + sizeof(TYPE) * E , ...) | devm_kzalloc(HANDLE, - (sizeof(THING)) * E + sizeof(THING) * E , ...) ) // Drop single-byte sizes and redundant parens. @@ expression HANDLE; expression COUNT; typedef u8; typedef __u8; @@ ( devm_kzalloc(HANDLE, - sizeof(u8) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(__u8) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(char) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(unsigned char) * (COUNT) + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(u8) * COUNT + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(__u8) * COUNT + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(char) * COUNT + COUNT , ...) | devm_kzalloc(HANDLE, - sizeof(unsigned char) * COUNT + COUNT , ...) ) // 2-factor product with sizeof(type/expression) and identifier or constant. @@ expression HANDLE; type TYPE; expression THING; identifier COUNT_ID; constant COUNT_CONST; @@ ( - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * (COUNT_ID) + COUNT_ID, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * COUNT_ID + COUNT_ID, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * (COUNT_CONST) + COUNT_CONST, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * COUNT_CONST + COUNT_CONST, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * (COUNT_ID) + COUNT_ID, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * COUNT_ID + COUNT_ID, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * (COUNT_CONST) + COUNT_CONST, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * COUNT_CONST + COUNT_CONST, sizeof(THING) , ...) ) // 2-factor product, only identifiers. @@ expression HANDLE; identifier SIZE, COUNT; @@ - devm_kzalloc + devm_kcalloc (HANDLE, - SIZE * COUNT + COUNT, SIZE , ...) // 3-factor product with 1 sizeof(type) or sizeof(expression), with // redundant parens removed. @@ expression HANDLE; expression THING; identifier STRIDE, COUNT; type TYPE; @@ ( devm_kzalloc(HANDLE, - sizeof(TYPE) * (COUNT) * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE) * (COUNT) * STRIDE + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE) * COUNT * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE) * COUNT * STRIDE + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * (COUNT) * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * (COUNT) * STRIDE + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * COUNT * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING) * COUNT * STRIDE + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) ) // 3-factor product with 2 sizeof(variable), with redundant parens removed. @@ expression HANDLE; expression THING1, THING2; identifier COUNT; type TYPE1, TYPE2; @@ ( devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(TYPE2) * COUNT + array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING1) * sizeof(THING2) * COUNT + array3_size(COUNT, sizeof(THING1), sizeof(THING2)) , ...) | devm_kzalloc(HANDLE, - sizeof(THING1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(THING1), sizeof(THING2)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(THING2) * COUNT + array3_size(COUNT, sizeof(TYPE1), sizeof(THING2)) , ...) | devm_kzalloc(HANDLE, - sizeof(TYPE1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(TYPE1), sizeof(THING2)) , ...) ) // 3-factor product, only identifiers, with redundant parens removed. @@ expression HANDLE; identifier STRIDE, SIZE, COUNT; @@ ( devm_kzalloc(HANDLE, - (COUNT) * STRIDE * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * (STRIDE) * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * STRIDE * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - (COUNT) * (STRIDE) * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * (STRIDE) * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - (COUNT) * STRIDE * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - (COUNT) * (STRIDE) * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | devm_kzalloc(HANDLE, - COUNT * STRIDE * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) ) // Any remaining multi-factor products, first at least 3-factor products, // when they're not all constants... @@ expression HANDLE; expression E1, E2, E3; constant C1, C2, C3; @@ ( devm_kzalloc(HANDLE, C1 * C2 * C3, ...) | devm_kzalloc(HANDLE, - (E1) * E2 * E3 + array3_size(E1, E2, E3) , ...) | devm_kzalloc(HANDLE, - (E1) * (E2) * E3 + array3_size(E1, E2, E3) , ...) | devm_kzalloc(HANDLE, - (E1) * (E2) * (E3) + array3_size(E1, E2, E3) , ...) | devm_kzalloc(HANDLE, - E1 * E2 * E3 + array3_size(E1, E2, E3) , ...) ) // And then all remaining 2 factors products when they're not all constants, // keeping sizeof() as the second factor argument. @@ expression HANDLE; expression THING, E1, E2; type TYPE; constant C1, C2, C3; @@ ( devm_kzalloc(HANDLE, sizeof(THING) * C2, ...) | devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...) | devm_kzalloc(HANDLE, C1 * C2 * C3, ...) | devm_kzalloc(HANDLE, C1 * C2, ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * (E2) + E2, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(TYPE) * E2 + E2, sizeof(TYPE) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * (E2) + E2, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - sizeof(THING) * E2 + E2, sizeof(THING) , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - (E1) * E2 + E1, E2 , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - (E1) * (E2) + E1, E2 , ...) | - devm_kzalloc + devm_kcalloc (HANDLE, - E1 * E2 + E1, E2 , ...) ) Signed-off-by: Kees Cook <keescook@chromium.org>
263 lines
6.6 KiB
C
263 lines
6.6 KiB
C
/*
|
|
* Copyright (C) 2017 Spreadtrum Communications Inc.
|
|
*
|
|
* This software is licensed under the terms of the GNU General Public
|
|
* License version 2, as published by the Free Software Foundation, and
|
|
* may be copied, distributed, and modified under those terms.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <linux/interrupt.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/mfd/core.h>
|
|
#include <linux/of_device.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/spi/spi.h>
|
|
|
|
#define SPRD_PMIC_INT_MASK_STATUS 0x0
|
|
#define SPRD_PMIC_INT_RAW_STATUS 0x4
|
|
#define SPRD_PMIC_INT_EN 0x8
|
|
|
|
#define SPRD_SC2731_IRQ_BASE 0x140
|
|
#define SPRD_SC2731_IRQ_NUMS 16
|
|
|
|
struct sprd_pmic {
|
|
struct regmap *regmap;
|
|
struct device *dev;
|
|
struct regmap_irq *irqs;
|
|
struct regmap_irq_chip irq_chip;
|
|
struct regmap_irq_chip_data *irq_data;
|
|
int irq;
|
|
};
|
|
|
|
struct sprd_pmic_data {
|
|
u32 irq_base;
|
|
u32 num_irqs;
|
|
};
|
|
|
|
/*
|
|
* Since different PMICs of SC27xx series can have different interrupt
|
|
* base address and irq number, we should save irq number and irq base
|
|
* in the device data structure.
|
|
*/
|
|
static const struct sprd_pmic_data sc2731_data = {
|
|
.irq_base = SPRD_SC2731_IRQ_BASE,
|
|
.num_irqs = SPRD_SC2731_IRQ_NUMS,
|
|
};
|
|
|
|
static const struct mfd_cell sprd_pmic_devs[] = {
|
|
{
|
|
.name = "sc27xx-wdt",
|
|
.of_compatible = "sprd,sc27xx-wdt",
|
|
}, {
|
|
.name = "sc27xx-rtc",
|
|
.of_compatible = "sprd,sc27xx-rtc",
|
|
}, {
|
|
.name = "sc27xx-charger",
|
|
.of_compatible = "sprd,sc27xx-charger",
|
|
}, {
|
|
.name = "sc27xx-chg-timer",
|
|
.of_compatible = "sprd,sc27xx-chg-timer",
|
|
}, {
|
|
.name = "sc27xx-fast-chg",
|
|
.of_compatible = "sprd,sc27xx-fast-chg",
|
|
}, {
|
|
.name = "sc27xx-chg-wdt",
|
|
.of_compatible = "sprd,sc27xx-chg-wdt",
|
|
}, {
|
|
.name = "sc27xx-typec",
|
|
.of_compatible = "sprd,sc27xx-typec",
|
|
}, {
|
|
.name = "sc27xx-flash",
|
|
.of_compatible = "sprd,sc27xx-flash",
|
|
}, {
|
|
.name = "sc27xx-eic",
|
|
.of_compatible = "sprd,sc27xx-eic",
|
|
}, {
|
|
.name = "sc27xx-efuse",
|
|
.of_compatible = "sprd,sc27xx-efuse",
|
|
}, {
|
|
.name = "sc27xx-thermal",
|
|
.of_compatible = "sprd,sc27xx-thermal",
|
|
}, {
|
|
.name = "sc27xx-adc",
|
|
.of_compatible = "sprd,sc27xx-adc",
|
|
}, {
|
|
.name = "sc27xx-audio-codec",
|
|
.of_compatible = "sprd,sc27xx-audio-codec",
|
|
}, {
|
|
.name = "sc27xx-regulator",
|
|
.of_compatible = "sprd,sc27xx-regulator",
|
|
}, {
|
|
.name = "sc27xx-vibrator",
|
|
.of_compatible = "sprd,sc27xx-vibrator",
|
|
}, {
|
|
.name = "sc27xx-keypad-led",
|
|
.of_compatible = "sprd,sc27xx-keypad-led",
|
|
}, {
|
|
.name = "sc27xx-bltc",
|
|
.of_compatible = "sprd,sc27xx-bltc",
|
|
}, {
|
|
.name = "sc27xx-fgu",
|
|
.of_compatible = "sprd,sc27xx-fgu",
|
|
}, {
|
|
.name = "sc27xx-7sreset",
|
|
.of_compatible = "sprd,sc27xx-7sreset",
|
|
}, {
|
|
.name = "sc27xx-poweroff",
|
|
.of_compatible = "sprd,sc27xx-poweroff",
|
|
}, {
|
|
.name = "sc27xx-syscon",
|
|
.of_compatible = "sprd,sc27xx-syscon",
|
|
},
|
|
};
|
|
|
|
static int sprd_pmic_spi_write(void *context, const void *data, size_t count)
|
|
{
|
|
struct device *dev = context;
|
|
struct spi_device *spi = to_spi_device(dev);
|
|
|
|
return spi_write(spi, data, count);
|
|
}
|
|
|
|
static int sprd_pmic_spi_read(void *context,
|
|
const void *reg, size_t reg_size,
|
|
void *val, size_t val_size)
|
|
{
|
|
struct device *dev = context;
|
|
struct spi_device *spi = to_spi_device(dev);
|
|
u32 rx_buf[2] = { 0 };
|
|
int ret;
|
|
|
|
/* Now we only support one PMIC register to read every time. */
|
|
if (reg_size != sizeof(u32) || val_size != sizeof(u32))
|
|
return -EINVAL;
|
|
|
|
/* Copy address to read from into first element of SPI buffer. */
|
|
memcpy(rx_buf, reg, sizeof(u32));
|
|
ret = spi_read(spi, rx_buf, 1);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
memcpy(val, rx_buf, val_size);
|
|
return 0;
|
|
}
|
|
|
|
static struct regmap_bus sprd_pmic_regmap = {
|
|
.write = sprd_pmic_spi_write,
|
|
.read = sprd_pmic_spi_read,
|
|
.reg_format_endian_default = REGMAP_ENDIAN_NATIVE,
|
|
.val_format_endian_default = REGMAP_ENDIAN_NATIVE,
|
|
};
|
|
|
|
static const struct regmap_config sprd_pmic_config = {
|
|
.reg_bits = 32,
|
|
.val_bits = 32,
|
|
.reg_stride = 4,
|
|
.max_register = 0xffff,
|
|
};
|
|
|
|
static int sprd_pmic_probe(struct spi_device *spi)
|
|
{
|
|
struct sprd_pmic *ddata;
|
|
const struct sprd_pmic_data *pdata;
|
|
int ret, i;
|
|
|
|
pdata = of_device_get_match_data(&spi->dev);
|
|
if (!pdata) {
|
|
dev_err(&spi->dev, "No matching driver data found\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
ddata = devm_kzalloc(&spi->dev, sizeof(*ddata), GFP_KERNEL);
|
|
if (!ddata)
|
|
return -ENOMEM;
|
|
|
|
ddata->regmap = devm_regmap_init(&spi->dev, &sprd_pmic_regmap,
|
|
&spi->dev, &sprd_pmic_config);
|
|
if (IS_ERR(ddata->regmap)) {
|
|
ret = PTR_ERR(ddata->regmap);
|
|
dev_err(&spi->dev, "Failed to allocate register map %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
spi_set_drvdata(spi, ddata);
|
|
ddata->dev = &spi->dev;
|
|
ddata->irq = spi->irq;
|
|
|
|
ddata->irq_chip.name = dev_name(&spi->dev);
|
|
ddata->irq_chip.status_base =
|
|
pdata->irq_base + SPRD_PMIC_INT_MASK_STATUS;
|
|
ddata->irq_chip.mask_base = pdata->irq_base + SPRD_PMIC_INT_EN;
|
|
ddata->irq_chip.ack_base = 0;
|
|
ddata->irq_chip.num_regs = 1;
|
|
ddata->irq_chip.num_irqs = pdata->num_irqs;
|
|
ddata->irq_chip.mask_invert = true;
|
|
|
|
ddata->irqs = devm_kcalloc(&spi->dev,
|
|
pdata->num_irqs, sizeof(struct regmap_irq),
|
|
GFP_KERNEL);
|
|
if (!ddata->irqs)
|
|
return -ENOMEM;
|
|
|
|
ddata->irq_chip.irqs = ddata->irqs;
|
|
for (i = 0; i < pdata->num_irqs; i++) {
|
|
ddata->irqs[i].reg_offset = i / pdata->num_irqs;
|
|
ddata->irqs[i].mask = BIT(i % pdata->num_irqs);
|
|
}
|
|
|
|
ret = devm_regmap_add_irq_chip(&spi->dev, ddata->regmap, ddata->irq,
|
|
IRQF_ONESHOT | IRQF_NO_SUSPEND, 0,
|
|
&ddata->irq_chip, &ddata->irq_data);
|
|
if (ret) {
|
|
dev_err(&spi->dev, "Failed to add PMIC irq chip %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
ret = devm_mfd_add_devices(&spi->dev, PLATFORM_DEVID_AUTO,
|
|
sprd_pmic_devs, ARRAY_SIZE(sprd_pmic_devs),
|
|
NULL, 0,
|
|
regmap_irq_get_domain(ddata->irq_data));
|
|
if (ret) {
|
|
dev_err(&spi->dev, "Failed to register device %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id sprd_pmic_match[] = {
|
|
{ .compatible = "sprd,sc2731", .data = &sc2731_data },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, sprd_pmic_match);
|
|
|
|
static struct spi_driver sprd_pmic_driver = {
|
|
.driver = {
|
|
.name = "sc27xx-pmic",
|
|
.bus = &spi_bus_type,
|
|
.of_match_table = sprd_pmic_match,
|
|
},
|
|
.probe = sprd_pmic_probe,
|
|
};
|
|
|
|
static int __init sprd_pmic_init(void)
|
|
{
|
|
return spi_register_driver(&sprd_pmic_driver);
|
|
}
|
|
subsys_initcall(sprd_pmic_init);
|
|
|
|
static void __exit sprd_pmic_exit(void)
|
|
{
|
|
spi_unregister_driver(&sprd_pmic_driver);
|
|
}
|
|
module_exit(sprd_pmic_exit);
|
|
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_DESCRIPTION("Spreadtrum SC27xx PMICs driver");
|
|
MODULE_AUTHOR("Baolin Wang <baolin.wang@spreadtrum.com>");
|