linux-stable/drivers/scsi/libsas
Jason Yan b90cd6f2b9 scsi: libsas: fix a race condition when smp task timeout
When the lldd is processing the complete sas task in interrupt and set the
task stat as SAS_TASK_STATE_DONE, the smp timeout timer is able to be
triggered at the same time. And smp_task_timedout() will complete the task
wheter the SAS_TASK_STATE_DONE is set or not. Then the sas task may freed
before lldd end the interrupt process. Thus a use-after-free will happen.

Fix this by calling the complete() only when SAS_TASK_STATE_DONE is not
set. And remove the check of the return value of the del_timer(). Once the
LLDD sets DONE, it must call task->done(), which will call
smp_task_done()->complete() and the task will be completed and freed
correctly.

Reported-by: chenxiang <chenxiang66@hisilicon.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
CC: John Garry <john.garry@huawei.com>
CC: Johannes Thumshirn <jthumshirn@suse.de>
CC: Ewan Milne <emilne@redhat.com>
CC: Christoph Hellwig <hch@lst.de>
CC: Tomas Henzl <thenzl@redhat.com>
CC: Dan Williams <dan.j.williams@intel.com>
CC: Hannes Reinecke <hare@suse.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: John Garry <john.garry@huawei.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-09-25 21:20:23 -04:00
..
Kconfig scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough 2017-08-29 21:51:45 -04:00
Makefile
sas_ata.c scsi: libsas: check the ata device status by ata_dev_enabled() 2018-09-25 21:20:23 -04:00
sas_discover.c scsi: libsas: make the lldd_port_deformed method optional 2018-09-25 21:20:23 -04:00
sas_dump.c scsi: libsas: kill useless ha_event and do some cleanup 2017-09-15 21:32:58 -04:00
sas_dump.h scsi: libsas: kill useless ha_event and do some cleanup 2017-09-15 21:32:58 -04:00
sas_event.c scsi: libsas: notify event PORTE_BROADCAST_RCVD in sas_enable_revalidation() 2018-01-10 23:24:54 -05:00
sas_expander.c scsi: libsas: fix a race condition when smp task timeout 2018-09-25 21:20:23 -04:00
sas_host_smp.c scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough 2017-08-29 21:51:45 -04:00
sas_init.c scsi: libsas: Fix kernel-doc headers 2018-02-27 21:15:16 -05:00
sas_internal.h scsi: libsas: direct call probe and destruct 2018-01-10 23:24:02 -05:00
sas_phy.c scsi: libsas: shut down the PHY if events reached the threshold 2018-01-08 21:59:28 -05:00
sas_port.c scsi: libsas: Fix kernel-doc headers 2018-02-27 21:15:16 -05:00
sas_scsi_host.c scsi: read host_busy via scsi_host_busy() 2018-06-26 12:53:26 -04:00
sas_task.c