mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 05:48:40 +00:00
![Robert Jarzmik](/assets/img/avatar_default.png)
Currently the LCD display (TD035S) on the cm-x300 platform is broken and remains blank. The TD0245S specification requires that the chipselect is toggled between commands sent to the panel. This was also the purpose of the former patch of commitf64dcac0b1
("backlight: tdo24m: ensure chip select changes between transfers"). Unfortunately, the "cs_change" field of a SPI transfer is misleading. Its true meaning is that for a SPI message holding multiple transfers, the chip select is toggled between each transfer, but for the last transfer it remains asserted. In this driver, all the SPI messages contain exactly one transfer, which means that each transfer is the last of its message, and as a consequence the chip select is never toggled. Actually, there was a second bug hidding the first one, hence the problem was not seen until v4.6. This problem was fixed by commita52db659c7
("spi: pxa2xx: Fix cs_change management") for PXA based boards. This fix makes the TD035S work again on a cm-x300 board. The same applies to other PXA boards, ie. corgi and tosa. Fixes:a52db659c7
("spi: pxa2xx: Fix cs_change management") Reported-by: Andrea Adami <andrea.adami@gmail.com> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org>
277 lines
5.5 KiB
C
277 lines
5.5 KiB
C
/*
|
|
* LCD / Backlight control code for Sharp SL-6000x (tosa)
|
|
*
|
|
* Copyright (c) 2005 Dirk Opfer
|
|
* Copyright (c) 2007,2008 Dmitry Baryshkov
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/device.h>
|
|
#include <linux/spi/spi.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/gpio.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/lcd.h>
|
|
#include <linux/fb.h>
|
|
|
|
#include <asm/mach/sharpsl_param.h>
|
|
|
|
#include <mach/tosa.h>
|
|
|
|
#define POWER_IS_ON(pwr) ((pwr) <= FB_BLANK_NORMAL)
|
|
|
|
#define TG_REG0_VQV 0x0001
|
|
#define TG_REG0_COLOR 0x0002
|
|
#define TG_REG0_UD 0x0004
|
|
#define TG_REG0_LR 0x0008
|
|
|
|
#define DAC_BASE 0x4e
|
|
|
|
struct tosa_lcd_data {
|
|
struct spi_device *spi;
|
|
struct lcd_device *lcd;
|
|
struct i2c_client *i2c;
|
|
|
|
int lcd_power;
|
|
bool is_vga;
|
|
};
|
|
|
|
static int tosa_tg_send(struct spi_device *spi, int adrs, uint8_t data)
|
|
{
|
|
u8 buf[1];
|
|
struct spi_message msg;
|
|
struct spi_transfer xfer = {
|
|
.len = 1,
|
|
.cs_change = 0,
|
|
.tx_buf = buf,
|
|
};
|
|
|
|
buf[0] = ((adrs & 0x07) << 5) | (data & 0x1f);
|
|
spi_message_init(&msg);
|
|
spi_message_add_tail(&xfer, &msg);
|
|
|
|
return spi_sync(spi, &msg);
|
|
}
|
|
|
|
int tosa_bl_enable(struct spi_device *spi, int enable)
|
|
{
|
|
/* bl_enable GP04=1 otherwise GP04=0*/
|
|
return tosa_tg_send(spi, TG_GPODR2, enable ? 0x01 : 0x00);
|
|
}
|
|
EXPORT_SYMBOL(tosa_bl_enable);
|
|
|
|
static void tosa_lcd_tg_init(struct tosa_lcd_data *data)
|
|
{
|
|
/* TG on */
|
|
gpio_set_value(TOSA_GPIO_TG_ON, 0);
|
|
|
|
mdelay(60);
|
|
|
|
/* delayed 0clk TCTL signal for VGA */
|
|
tosa_tg_send(data->spi, TG_TPOSCTL, 0x00);
|
|
/* GPOS0=powercontrol, GPOS1=GPIO, GPOS2=TCTL */
|
|
tosa_tg_send(data->spi, TG_GPOSR, 0x02);
|
|
}
|
|
|
|
static void tosa_lcd_tg_on(struct tosa_lcd_data *data)
|
|
{
|
|
struct spi_device *spi = data->spi;
|
|
int value = TG_REG0_COLOR | TG_REG0_UD | TG_REG0_LR;
|
|
|
|
if (data->is_vga)
|
|
value |= TG_REG0_VQV;
|
|
|
|
tosa_tg_send(spi, TG_PNLCTL, value);
|
|
|
|
/* TG LCD pannel power up */
|
|
tosa_tg_send(spi, TG_PINICTL, 0x4);
|
|
mdelay(50);
|
|
|
|
/* TG LCD GVSS */
|
|
tosa_tg_send(spi, TG_PINICTL, 0x0);
|
|
|
|
if (!data->i2c) {
|
|
/*
|
|
* after the pannel is powered up the first time,
|
|
* we can access the i2c bus so probe for the DAC
|
|
*/
|
|
struct i2c_adapter *adap = i2c_get_adapter(0);
|
|
struct i2c_board_info info = {
|
|
.type = "tosa-bl",
|
|
.addr = DAC_BASE,
|
|
.platform_data = data->spi,
|
|
};
|
|
data->i2c = i2c_new_device(adap, &info);
|
|
}
|
|
}
|
|
|
|
static void tosa_lcd_tg_off(struct tosa_lcd_data *data)
|
|
{
|
|
struct spi_device *spi = data->spi;
|
|
|
|
/* TG LCD VHSA off */
|
|
tosa_tg_send(spi, TG_PINICTL, 0x4);
|
|
mdelay(50);
|
|
|
|
/* TG LCD signal off */
|
|
tosa_tg_send(spi, TG_PINICTL, 0x6);
|
|
mdelay(50);
|
|
|
|
/* TG Off */
|
|
gpio_set_value(TOSA_GPIO_TG_ON, 1);
|
|
mdelay(100);
|
|
}
|
|
|
|
int tosa_lcd_set_power(struct lcd_device *lcd, int power)
|
|
{
|
|
struct tosa_lcd_data *data = lcd_get_data(lcd);
|
|
|
|
if (POWER_IS_ON(power) && !POWER_IS_ON(data->lcd_power))
|
|
tosa_lcd_tg_on(data);
|
|
|
|
if (!POWER_IS_ON(power) && POWER_IS_ON(data->lcd_power))
|
|
tosa_lcd_tg_off(data);
|
|
|
|
data->lcd_power = power;
|
|
return 0;
|
|
}
|
|
|
|
static int tosa_lcd_get_power(struct lcd_device *lcd)
|
|
{
|
|
struct tosa_lcd_data *data = lcd_get_data(lcd);
|
|
|
|
return data->lcd_power;
|
|
}
|
|
|
|
static int tosa_lcd_set_mode(struct lcd_device *lcd, struct fb_videomode *mode)
|
|
{
|
|
struct tosa_lcd_data *data = lcd_get_data(lcd);
|
|
|
|
if (mode->xres == 320 || mode->yres == 320)
|
|
data->is_vga = false;
|
|
else
|
|
data->is_vga = true;
|
|
|
|
if (POWER_IS_ON(data->lcd_power))
|
|
tosa_lcd_tg_on(data);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct lcd_ops tosa_lcd_ops = {
|
|
.set_power = tosa_lcd_set_power,
|
|
.get_power = tosa_lcd_get_power,
|
|
.set_mode = tosa_lcd_set_mode,
|
|
};
|
|
|
|
static int tosa_lcd_probe(struct spi_device *spi)
|
|
{
|
|
int ret;
|
|
struct tosa_lcd_data *data;
|
|
|
|
data = devm_kzalloc(&spi->dev, sizeof(struct tosa_lcd_data),
|
|
GFP_KERNEL);
|
|
if (!data)
|
|
return -ENOMEM;
|
|
|
|
data->is_vga = true; /* default to VGA mode */
|
|
|
|
/*
|
|
* bits_per_word cannot be configured in platform data
|
|
*/
|
|
spi->bits_per_word = 8;
|
|
|
|
ret = spi_setup(spi);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
data->spi = spi;
|
|
spi_set_drvdata(spi, data);
|
|
|
|
ret = devm_gpio_request_one(&spi->dev, TOSA_GPIO_TG_ON,
|
|
GPIOF_OUT_INIT_LOW, "tg #pwr");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
mdelay(60);
|
|
|
|
tosa_lcd_tg_init(data);
|
|
|
|
tosa_lcd_tg_on(data);
|
|
|
|
data->lcd = devm_lcd_device_register(&spi->dev, "tosa-lcd", &spi->dev,
|
|
data, &tosa_lcd_ops);
|
|
|
|
if (IS_ERR(data->lcd)) {
|
|
ret = PTR_ERR(data->lcd);
|
|
data->lcd = NULL;
|
|
goto err_register;
|
|
}
|
|
|
|
return 0;
|
|
|
|
err_register:
|
|
tosa_lcd_tg_off(data);
|
|
return ret;
|
|
}
|
|
|
|
static int tosa_lcd_remove(struct spi_device *spi)
|
|
{
|
|
struct tosa_lcd_data *data = spi_get_drvdata(spi);
|
|
|
|
if (data->i2c)
|
|
i2c_unregister_device(data->i2c);
|
|
|
|
tosa_lcd_tg_off(data);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
static int tosa_lcd_suspend(struct device *dev)
|
|
{
|
|
struct tosa_lcd_data *data = dev_get_drvdata(dev);
|
|
|
|
tosa_lcd_tg_off(data);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int tosa_lcd_resume(struct device *dev)
|
|
{
|
|
struct tosa_lcd_data *data = dev_get_drvdata(dev);
|
|
|
|
tosa_lcd_tg_init(data);
|
|
if (POWER_IS_ON(data->lcd_power))
|
|
tosa_lcd_tg_on(data);
|
|
else
|
|
tosa_lcd_tg_off(data);
|
|
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
static SIMPLE_DEV_PM_OPS(tosa_lcd_pm_ops, tosa_lcd_suspend, tosa_lcd_resume);
|
|
|
|
static struct spi_driver tosa_lcd_driver = {
|
|
.driver = {
|
|
.name = "tosa-lcd",
|
|
.pm = &tosa_lcd_pm_ops,
|
|
},
|
|
.probe = tosa_lcd_probe,
|
|
.remove = tosa_lcd_remove,
|
|
};
|
|
|
|
module_spi_driver(tosa_lcd_driver);
|
|
|
|
MODULE_AUTHOR("Dmitry Baryshkov");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_DESCRIPTION("LCD/Backlight control for Sharp SL-6000 PDA");
|
|
MODULE_ALIAS("spi:tosa-lcd");
|