mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
![Alexey Khoroshilov](/assets/img/avatar_default.png)
edac_init() does not deallocate already allocated resources on failure path. Found by Linux Driver Verification project (linuxtesting.org). [ Boris: The unwind path functions have __exit annotation but are being used in an __init function, leading to section mismatches. Drop the section annotation and make them normal functions. ] Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Link: http://lkml.kernel.org/r/1423203162-26368-1-git-send-email-khoroshilov@ispras.ru Signed-off-by: Borislav Petkov <bp@suse.de>
157 lines
3.1 KiB
C
157 lines
3.1 KiB
C
/*
|
|
* edac_module.c
|
|
*
|
|
* (C) 2007 www.softwarebitmaker.com
|
|
*
|
|
* This file is licensed under the terms of the GNU General Public
|
|
* License version 2. This program is licensed "as is" without any
|
|
* warranty of any kind, whether express or implied.
|
|
*
|
|
* Author: Doug Thompson <dougthompson@xmission.com>
|
|
*
|
|
*/
|
|
#include <linux/edac.h>
|
|
|
|
#include "edac_core.h"
|
|
#include "edac_module.h"
|
|
|
|
#define EDAC_VERSION "Ver: 3.0.0"
|
|
|
|
#ifdef CONFIG_EDAC_DEBUG
|
|
|
|
static int edac_set_debug_level(const char *buf, struct kernel_param *kp)
|
|
{
|
|
unsigned long val;
|
|
int ret;
|
|
|
|
ret = kstrtoul(buf, 0, &val);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (val > 4)
|
|
return -EINVAL;
|
|
|
|
return param_set_int(buf, kp);
|
|
}
|
|
|
|
/* Values of 0 to 4 will generate output */
|
|
int edac_debug_level = 2;
|
|
EXPORT_SYMBOL_GPL(edac_debug_level);
|
|
|
|
module_param_call(edac_debug_level, edac_set_debug_level, param_get_int,
|
|
&edac_debug_level, 0644);
|
|
MODULE_PARM_DESC(edac_debug_level, "EDAC debug level: [0-4], default: 2");
|
|
#endif
|
|
|
|
/* scope is to module level only */
|
|
struct workqueue_struct *edac_workqueue;
|
|
|
|
/*
|
|
* edac_op_state_to_string()
|
|
*/
|
|
char *edac_op_state_to_string(int opstate)
|
|
{
|
|
if (opstate == OP_RUNNING_POLL)
|
|
return "POLLED";
|
|
else if (opstate == OP_RUNNING_INTERRUPT)
|
|
return "INTERRUPT";
|
|
else if (opstate == OP_RUNNING_POLL_INTR)
|
|
return "POLL-INTR";
|
|
else if (opstate == OP_ALLOC)
|
|
return "ALLOC";
|
|
else if (opstate == OP_OFFLINE)
|
|
return "OFFLINE";
|
|
|
|
return "UNKNOWN";
|
|
}
|
|
|
|
/*
|
|
* edac_workqueue_setup
|
|
* initialize the edac work queue for polling operations
|
|
*/
|
|
static int edac_workqueue_setup(void)
|
|
{
|
|
edac_workqueue = create_singlethread_workqueue("edac-poller");
|
|
if (edac_workqueue == NULL)
|
|
return -ENODEV;
|
|
else
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* edac_workqueue_teardown
|
|
* teardown the edac workqueue
|
|
*/
|
|
static void edac_workqueue_teardown(void)
|
|
{
|
|
if (edac_workqueue) {
|
|
flush_workqueue(edac_workqueue);
|
|
destroy_workqueue(edac_workqueue);
|
|
edac_workqueue = NULL;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* edac_init
|
|
* module initialization entry point
|
|
*/
|
|
static int __init edac_init(void)
|
|
{
|
|
int err = 0;
|
|
|
|
edac_printk(KERN_INFO, EDAC_MC, EDAC_VERSION "\n");
|
|
|
|
/*
|
|
* Harvest and clear any boot/initialization PCI parity errors
|
|
*
|
|
* FIXME: This only clears errors logged by devices present at time of
|
|
* module initialization. We should also do an initial clear
|
|
* of each newly hotplugged device.
|
|
*/
|
|
edac_pci_clear_parity_errors();
|
|
|
|
err = edac_mc_sysfs_init();
|
|
if (err)
|
|
goto err_sysfs;
|
|
|
|
edac_debugfs_init();
|
|
|
|
err = edac_workqueue_setup();
|
|
if (err) {
|
|
edac_printk(KERN_ERR, EDAC_MC, "Failure initializing workqueue\n");
|
|
goto err_wq;
|
|
}
|
|
|
|
return 0;
|
|
|
|
err_wq:
|
|
edac_debugfs_exit();
|
|
edac_mc_sysfs_exit();
|
|
|
|
err_sysfs:
|
|
return err;
|
|
}
|
|
|
|
/*
|
|
* edac_exit()
|
|
* module exit/termination function
|
|
*/
|
|
static void __exit edac_exit(void)
|
|
{
|
|
edac_dbg(0, "\n");
|
|
|
|
/* tear down the various subsystems */
|
|
edac_workqueue_teardown();
|
|
edac_mc_sysfs_exit();
|
|
edac_debugfs_exit();
|
|
}
|
|
|
|
/*
|
|
* Inform the kernel of our entry and exit points
|
|
*/
|
|
subsys_initcall(edac_init);
|
|
module_exit(edac_exit);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Doug Thompson www.softwarebitmaker.com, et al");
|
|
MODULE_DESCRIPTION("Core library routines for EDAC reporting");
|