Arnd Bergmann a398e04363 media: s3c-camif: fix out-of-bounds array access ... While experimenting with older compiler versions, I ran into a warning that no longer shows up on gcc-4.8 or newer: drivers/media/platform/s3c-camif/camif-capture.c: In function '__camif_subdev_try_format': drivers/media/platform/s3c-camif/camif-capture.c:1265:25: error: array subscript is below array bounds This is an off-by-one bug, leading to an access before the start of the array, while newer compilers silently assume this undefined behavior cannot happen and leave the loop at index 0 if no other entry matches. As Sylvester explains, we actually need to ensure that the value is within the range, so this reworks the loop to be easier to parse correctly, and an additional check to fall back on the first format value for any unexpected input. I found an existing gcc bug for it and added a reduced version of the function there. Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69249#c3 Fixes: babde1c243 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>		2018-03-06 07:29:04 -05:00
..
camif-capture.c	media: s3c-camif: fix out-of-bounds array access	2018-03-06 07:29:04 -05:00
camif-core.c	media: s3c-camif: add missing description at s3c_camif_find_format()	2017-11-30 04:19:00 -05:00
camif-core.h	[media] media/platform: convert drivers to use the new vb2_queue dev field	2016-07-08 14:42:09 -03:00
camif-regs.c
camif-regs.h	[media] include/media: move driver interface headers to a separate dir	2015-11-17 06:57:29 -02:00
Makefile