mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-26 04:16:39 +00:00
0c7c7ba0c7
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). fsl_mc_err_remove() is used as callback in two drivers. So these have to be converted together to the void returning remove callback. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://lore.kernel.org/r/20231013100422.1382040-2-u.kleine-koenig@pengutronix.de
75 lines
1.7 KiB
C
75 lines
1.7 KiB
C
/*
|
|
* Freescale Memory Controller kernel module
|
|
*
|
|
* Author: York Sun <york.sun@nxp.com>
|
|
*
|
|
* Copyright 2016 NXP Semiconductor
|
|
*
|
|
* Derived from mpc85xx_edac.c
|
|
* Author: Dave Jiang <djiang@mvista.com>
|
|
*
|
|
* 2006-2007 (c) MontaVista Software, Inc. This file is licensed under
|
|
* the terms of the GNU General Public License version 2. This program
|
|
* is licensed "as is" without any warranty of any kind, whether express
|
|
* or implied.
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include "edac_module.h"
|
|
#include "fsl_ddr_edac.h"
|
|
|
|
static const struct of_device_id fsl_ddr_mc_err_of_match[] = {
|
|
{ .compatible = "fsl,qoriq-memory-controller", },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, fsl_ddr_mc_err_of_match);
|
|
|
|
static struct platform_driver fsl_ddr_mc_err_driver = {
|
|
.probe = fsl_mc_err_probe,
|
|
.remove_new = fsl_mc_err_remove,
|
|
.driver = {
|
|
.name = "fsl_ddr_mc_err",
|
|
.of_match_table = fsl_ddr_mc_err_of_match,
|
|
},
|
|
};
|
|
|
|
static int __init fsl_ddr_mc_init(void)
|
|
{
|
|
int res;
|
|
|
|
if (ghes_get_devices())
|
|
return -EBUSY;
|
|
|
|
/* make sure error reporting method is sane */
|
|
switch (edac_op_state) {
|
|
case EDAC_OPSTATE_POLL:
|
|
case EDAC_OPSTATE_INT:
|
|
break;
|
|
default:
|
|
edac_op_state = EDAC_OPSTATE_INT;
|
|
break;
|
|
}
|
|
|
|
res = platform_driver_register(&fsl_ddr_mc_err_driver);
|
|
if (res) {
|
|
pr_err("MC fails to register\n");
|
|
return res;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
module_init(fsl_ddr_mc_init);
|
|
|
|
static void __exit fsl_ddr_mc_exit(void)
|
|
{
|
|
platform_driver_unregister(&fsl_ddr_mc_err_driver);
|
|
}
|
|
|
|
module_exit(fsl_ddr_mc_exit);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("NXP Semiconductor");
|
|
module_param(edac_op_state, int, 0444);
|
|
MODULE_PARM_DESC(edac_op_state, "EDAC Error Reporting state: 0=Poll, 2=Interrupt");
|