mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
21a01abbe3
Currently we neatly track the crtc state, but forget to look at plane/connector state. When doing a nonblocking modeset, immediately followed by a setprop before the modeset completes, the setprop will see the modesets new state as the old state and free it. This has to be solved by waiting for hw_done on the connector, even if it's not assigned to a crtc. When a connector is unbound we take the last crtc commit, and when it stays unbound we create a new fake crtc commit for that gets signaled on hw_done for all the planes/connectors. We wait for it the same way as we do for crtc's, which will make sure we never run into a use-after-free situation. Changes since v1: - Only create a single disable commit. (danvet) - Fix leak in intel_legacy_cursor_update. Changes since v2: - Make reference counting in drm_atomic_helper_setup_commit more obvious. (pinchartl) - Call cleanup_done for fake commit. (danvet) - Add comments to drm_atomic_helper_setup_commit. (danvet, pinchartl) - Add comment to drm_atomic_helper_swap_state. (pinchartl) Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Testcase: kms_atomic_transition.plane-use-after-nonblocking-unbind* Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Link: https://patchwork.freedesktop.org/patch/msgid/20170904104838.23822-6-maarten.lankhorst@linux.intel.com Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
||
---|---|---|
.. | ||
bridge | ||
i2c | ||
tinydrm | ||
ttm | ||
ati_pcigart.h | ||
drm_agpsupport.h | ||
drm_atomic.h | ||
drm_atomic_helper.h | ||
drm_auth.h | ||
drm_blend.h | ||
drm_bridge.h | ||
drm_cache.h | ||
drm_color_mgmt.h | ||
drm_connector.h | ||
drm_crtc.h | ||
drm_crtc_helper.h | ||
drm_debugfs.h | ||
drm_debugfs_crc.h | ||
drm_device.h | ||
drm_displayid.h | ||
drm_dp_dual_mode_helper.h | ||
drm_dp_helper.h | ||
drm_dp_mst_helper.h | ||
drm_drv.h | ||
drm_edid.h | ||
drm_encoder.h | ||
drm_encoder_slave.h | ||
drm_fb_cma_helper.h | ||
drm_fb_helper.h | ||
drm_file.h | ||
drm_fixed.h | ||
drm_flip_work.h | ||
drm_fourcc.h | ||
drm_framebuffer.h | ||
drm_gem.h | ||
drm_gem_cma_helper.h | ||
drm_gem_framebuffer_helper.h | ||
drm_global.h | ||
drm_hashtab.h | ||
drm_ioctl.h | ||
drm_irq.h | ||
drm_legacy.h | ||
drm_mipi_dsi.h | ||
drm_mm.h | ||
drm_mode_config.h | ||
drm_mode_object.h | ||
drm_modes.h | ||
drm_modeset_helper.h | ||
drm_modeset_helper_vtables.h | ||
drm_modeset_lock.h | ||
drm_of.h | ||
drm_os_linux.h | ||
drm_panel.h | ||
drm_pci.h | ||
drm_pciids.h | ||
drm_plane.h | ||
drm_plane_helper.h | ||
drm_prime.h | ||
drm_print.h | ||
drm_property.h | ||
drm_rect.h | ||
drm_scdc_helper.h | ||
drm_simple_kms_helper.h | ||
drm_syncobj.h | ||
drm_sysfs.h | ||
drm_vblank.h | ||
drm_vma_manager.h | ||
drmP.h | ||
gma_drm.h | ||
i915_component.h | ||
i915_drm.h | ||
i915_pciids.h | ||
intel-gtt.h | ||
intel_lpe_audio.h |