mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
![Rafael J. Wysocki](/assets/img/avatar_default.png)
It is useful to know the reason why cpufreq_update_util() has just been called and that can be passed as flags to cpufreq_update_util() and to the ->func() callback in struct update_util_data. However, doing that in addition to passing the util and max arguments they already take would be clumsy, so avoid it. Instead, use the observation that the schedutil governor is part of the scheduler proper, so it can access scheduler data directly. This allows the util and max arguments of cpufreq_update_util() and the ->func() callback in struct update_util_data to be replaced with a flags one, but schedutil has to be modified to follow. Thus make the schedutil governor obtain the CFS utilization information from the scheduler and use the "RT" and "DL" flags instead of the special utilization value of ULONG_MAX to track updates from the RT and DL sched classes. Make it non-modular too to avoid having to export scheduler variables to modules at large. Next, update all of the other users of cpufreq_update_util() and the ->func() callback in struct update_util_data accordingly. Suggested-by: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
63 lines
2.2 KiB
C
63 lines
2.2 KiB
C
/*
|
|
* Scheduler code and data structures related to cpufreq.
|
|
*
|
|
* Copyright (C) 2016, Intel Corporation
|
|
* Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include "sched.h"
|
|
|
|
DEFINE_PER_CPU(struct update_util_data *, cpufreq_update_util_data);
|
|
|
|
/**
|
|
* cpufreq_add_update_util_hook - Populate the CPU's update_util_data pointer.
|
|
* @cpu: The CPU to set the pointer for.
|
|
* @data: New pointer value.
|
|
* @func: Callback function to set for the CPU.
|
|
*
|
|
* Set and publish the update_util_data pointer for the given CPU.
|
|
*
|
|
* The update_util_data pointer of @cpu is set to @data and the callback
|
|
* function pointer in the target struct update_util_data is set to @func.
|
|
* That function will be called by cpufreq_update_util() from RCU-sched
|
|
* read-side critical sections, so it must not sleep. @data will always be
|
|
* passed to it as the first argument which allows the function to get to the
|
|
* target update_util_data structure and its container.
|
|
*
|
|
* The update_util_data pointer of @cpu must be NULL when this function is
|
|
* called or it will WARN() and return with no effect.
|
|
*/
|
|
void cpufreq_add_update_util_hook(int cpu, struct update_util_data *data,
|
|
void (*func)(struct update_util_data *data, u64 time,
|
|
unsigned int flags))
|
|
{
|
|
if (WARN_ON(!data || !func))
|
|
return;
|
|
|
|
if (WARN_ON(per_cpu(cpufreq_update_util_data, cpu)))
|
|
return;
|
|
|
|
data->func = func;
|
|
rcu_assign_pointer(per_cpu(cpufreq_update_util_data, cpu), data);
|
|
}
|
|
EXPORT_SYMBOL_GPL(cpufreq_add_update_util_hook);
|
|
|
|
/**
|
|
* cpufreq_remove_update_util_hook - Clear the CPU's update_util_data pointer.
|
|
* @cpu: The CPU to clear the pointer for.
|
|
*
|
|
* Clear the update_util_data pointer for the given CPU.
|
|
*
|
|
* Callers must use RCU-sched callbacks to free any memory that might be
|
|
* accessed via the old update_util_data pointer or invoke synchronize_sched()
|
|
* right after this function to avoid use-after-free.
|
|
*/
|
|
void cpufreq_remove_update_util_hook(int cpu)
|
|
{
|
|
rcu_assign_pointer(per_cpu(cpufreq_update_util_data, cpu), NULL);
|
|
}
|
|
EXPORT_SYMBOL_GPL(cpufreq_remove_update_util_hook);
|