Jan Kara 22b106e535 block: fix bio_clone_blkg_association() to associate with proper blkcg_gq ... Commit d92c370a16 ("block: really clone the block cgroup in bio_clone_blkg_association") changed bio_clone_blkg_association() to just clone bio->bi_blkg reference from source to destination bio. This is however wrong if the source and destination bios are against different block devices because struct blkcg_gq is different for each bdev-blkcg pair. This will result in IOs being accounted (and throttled as a result) multiple times against the same device (src bdev) while throttling of the other device (dst bdev) is ignored. In case of BFQ the inconsistency can even result in crashes in bfq_bic_update_cgroup(). Fix the problem by looking up correct blkcg_gq for the cloned bio. Reported-by: Logan Gunthorpe <logang@deltatee.com> Reported-and-tested-by: Donald Buczek <buczek@molgen.mpg.de> Fixes: d92c370a16 ("block: really clone the block cgroup in bio_clone_blkg_association") CC: stable@vger.kernel.org Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20220602081242.7731-1-jack@suse.cz Signed-off-by: Jens Axboe <axboe@kernel.dk>		2022-06-02 02:15:05 -06:00
..
partitions	block/partitions/ldm: Remove redundant assignments	2022-04-23 07:15:26 -06:00
badblocks.c	block/badblocks: Remove redundant assignments	2022-04-23 07:15:26 -06:00
bdev.c	Merge branch 'akpm' (patches from Andrew)	2022-03-22 16:11:53 -07:00
bfq-cgroup.c	bfq: Make sure bfqg for which we are queueing requests is online	2022-04-17 19:34:32 -06:00
bfq-iosched.c	bfq: Remove bfq_requeue_request_body()	2022-05-19 06:52:36 -06:00
bfq-iosched.h	bfq: Relax waker detection for shared queues	2022-05-19 06:52:33 -06:00
bfq-wf2q.c	block, bfq: cleanup bfq_bfqq_to_bfqg()	2022-02-18 06:13:00 -07:00
bio-integrity.c	for-5.18/block-2022-03-18	2022-03-21 16:48:55 -07:00
bio.c	block: make bioset_exit() fully resilient against being called twice	2022-05-29 07:36:31 -06:00
blk-cgroup-fc-appid.c	blk-cgroup: move blkcg_{get,set}_fc_appid out of line	2022-05-02 14:06:20 -06:00
blk-cgroup-rwstat.c
blk-cgroup-rwstat.h	block: partition include/linux/blk-cgroup.h	2022-02-11 10:02:41 -07:00
blk-cgroup.c	block: fix bio_clone_blkg_association() to associate with proper blkcg_gq	2022-06-02 02:15:05 -06:00
blk-cgroup.h	blk-cgroup: always terminate io.stat lines	2022-05-17 06:11:17 -06:00
blk-core.c	block: use bio_queue_enter instead of blk_queue_enter in bio_poll	2022-05-28 06:14:35 -06:00
blk-crypto-fallback.c	block: remove superfluous calls to blkcg_bio_issue_init	2022-05-04 18:29:52 -06:00
blk-crypto-internal.h	blk-crypto: show crypto capabilities in sysfs	2022-02-28 06:40:23 -07:00
blk-crypto-profile.c	blk-crypto: remove blk_crypto_unregister()	2021-11-29 06:38:51 -07:00
blk-crypto-sysfs.c	blk-crypto: show crypto capabilities in sysfs	2022-02-28 06:40:23 -07:00
blk-crypto.c	blk-crypto: show crypto capabilities in sysfs	2022-02-28 06:40:23 -07:00
blk-flush.c	block: pass a block_device and opf to bio_init	2022-02-02 07:49:59 -07:00
blk-ia-ranges.c	block: fix memory leak in disk_register_independent_access_ranges	2022-01-23 09:13:09 -07:00
blk-integrity.c	blk-crypto: remove blk_crypto_unregister()	2021-11-29 06:38:51 -07:00
blk-ioc.c	block: restore the old set_task_ioprio() behaviour wrt PF_EXITING	2022-03-28 06:34:11 -06:00
blk-iocost.c	blk-cgroup: always terminate io.stat lines	2022-05-17 06:11:17 -06:00
blk-iolatency.c	blk-iolatency: Fix inflight count imbalances and IO hangs on offline	2022-05-26 11:43:00 -06:00
blk-ioprio.c	block: partition include/linux/blk-cgroup.h	2022-02-11 10:02:41 -07:00
blk-ioprio.h
blk-lib.c	block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD	2022-04-17 19:49:59 -06:00
blk-map.c	block/blk-map: Remove redundant assignment	2022-04-23 07:15:26 -06:00
blk-merge.c	for-5.18/write-streams-2022-03-18	2022-03-26 11:51:46 -07:00
blk-mq-cpumap.c
blk-mq-debugfs-zoned.c
blk-mq-debugfs.c	block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD	2022-04-17 19:49:59 -06:00
blk-mq-debugfs.h	blk-mq: manage hctx map via xarray	2022-03-08 19:39:38 -07:00
blk-mq-pci.c
blk-mq-rdma.c
blk-mq-sched.c	block: limit request dispatch loop duration	2022-03-17 20:31:43 -06:00
blk-mq-sched.h	block: move blk_mq_sched_assign_ioc to blk-ioc.c	2021-11-29 06:41:29 -07:00
blk-mq-sysfs.c	blk-mq: prepare for implementing hctx table via xarray	2022-03-08 17:57:19 -07:00
blk-mq-tag.c	block: remove useless BUG_ON() in blk_mq_put_tag()	2022-06-02 02:05:56 -06:00
blk-mq-tag.h	blk-mq: Delete busy_iter_fn	2021-12-06 13:18:47 -07:00
blk-mq-virtio.c
blk-mq.c	blk-mq: do not update io_ticks with passthrough requests	2022-05-30 07:13:12 -06:00
blk-mq.h	blk-mq: manage hctx map via xarray	2022-03-08 19:39:38 -07:00
blk-pm.c	scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()	2021-12-22 23:38:29 -05:00
blk-pm.h
blk-rq-qos.c
blk-rq-qos.h	block: fix rq-qos breakage from skipping rq_qos_done_bio()	2022-03-14 14:23:13 -06:00
blk-settings.c	block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD	2022-04-17 19:49:59 -06:00
blk-stat.c	block: make queue stat accounting a reference	2021-12-14 17:23:05 -07:00
blk-stat.h	block: make queue stat accounting a reference	2021-12-14 17:23:05 -07:00
blk-sysfs.c	SCSI misc on 20220324	2022-03-24 19:37:53 -07:00
blk-throttle.c	blk-throttle: Set BIO_THROTTLED when bio has been throttled	2022-05-17 19:32:10 -06:00
blk-throttle.h	block: cancel all throttled bios in del_gendisk()	2022-03-18 09:57:56 -06:00
blk-timeout.c
blk-wbt.c	blk-wbt: prevent NULL pointer dereference in wb_timer_fn	2021-10-19 06:13:41 -06:00
blk-wbt.h	blk-wbt: remove wbt_track stub	2022-03-31 12:58:38 -06:00
blk-zoned.c	SCSI misc on 20220324	2022-03-24 19:37:53 -07:00
blk.h	block: refactor discard bio size limiting	2022-04-17 19:49:59 -06:00
bounce.c	block: remove superfluous calls to blkcg_bio_issue_init	2022-05-04 18:29:52 -06:00
bsg-lib.c	block: remove the gendisk argument to blk_execute_rq	2021-11-29 06:41:29 -07:00
bsg.c	scsi: bsg: Fix device unregistration	2021-09-14 00:22:15 -04:00
disk-events.c	block: remove genhd.h	2022-02-02 07:49:59 -07:00
elevator.c	for-5.18/block-2022-03-18	2022-03-21 16:48:55 -07:00
elevator.h	block: move elevator.h to block/	2021-10-18 06:17:01 -06:00
fops.c	block: ignore RWF_HIPRI hint for sync dio	2022-05-02 10:07:42 -06:00
genhd.c	block: remove queue_discard_alignment	2022-04-17 19:49:59 -06:00
holder.c	block: remove genhd.h	2022-02-02 07:49:59 -07:00
ioctl.c	block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD	2022-04-17 19:49:59 -06:00
ioprio.c	for-5.17/block-2022-01-11	2022-01-12 10:26:52 -08:00
Kconfig	block: add pi for extended integrity	2022-03-07 12:48:35 -07:00
Kconfig.iosched	block: only build the icq tracking code when needed	2021-12-16 10:59:02 -07:00
kyber-iosched.c	block: make queue stat accounting a reference	2021-12-14 17:23:05 -07:00
Makefile	blk-cgroup: move blkcg_{get,set}_fc_appid out of line	2022-05-02 14:06:20 -06:00
mq-deadline.c	block: fix async_depth sysfs interface for mq-deadline	2022-01-20 10:54:02 -07:00
opal_proto.h
sed-opal.c	block: remove genhd.h	2022-02-02 07:49:59 -07:00
t10-pi.c	block: add pi for extended integrity	2022-03-07 12:48:35 -07:00