mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 05:44:11 +00:00
a68e9da485
Since commit2f1e8ea726("net: dsa: link interfaces with the DSA master to get rid of lockdep warnings"), DSA gained a requirement which it did not fulfill, which is to unlink itself from the DSA master at shutdown time. Since the Arrow SpeedChips XRS700x driver was introduced after the bad commit, it has never worked with DSA masters which decide to unregister their net_device on shutdown, effectively hanging the reboot process. To fix that, we need to call dsa_switch_shutdown. These devices can be connected by I2C or by MDIO, and if I search for I2C or MDIO bus drivers that implement their ->shutdown by redirecting it to ->remove I don't see any, however this does not mean it would not be possible. To be compatible with that pattern, it is necessary to implement an "if this then not that" scheme, to avoid ->remove and ->shutdown from being called both for the same struct device. Fixes:ee00b24f32("net: dsa: add Arrow SpeedChips XRS700x driver") Link: https://lore.kernel.org/netdev/20210909095324.12978-1-LinoSanfilippo@gmx.de/ Reported-by: Lino Sanfilippo <LinoSanfilippo@gmx.de> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: George McCollister <george.mccollister@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
43 lines
1.1 KiB
C
43 lines
1.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#include <linux/device.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/workqueue.h>
|
|
#include <linux/u64_stats_sync.h>
|
|
#include <uapi/linux/if_link.h>
|
|
|
|
struct xrs700x_info {
|
|
unsigned int id;
|
|
const char *name;
|
|
size_t num_ports;
|
|
};
|
|
|
|
extern const struct xrs700x_info xrs7003e_info;
|
|
extern const struct xrs700x_info xrs7003f_info;
|
|
extern const struct xrs700x_info xrs7004e_info;
|
|
extern const struct xrs700x_info xrs7004f_info;
|
|
|
|
struct xrs700x_port {
|
|
struct mutex mib_mutex; /* protects mib_data */
|
|
u64 *mib_data;
|
|
struct rtnl_link_stats64 stats64;
|
|
struct u64_stats_sync syncp;
|
|
};
|
|
|
|
struct xrs700x {
|
|
struct dsa_switch *ds;
|
|
struct device *dev;
|
|
void *priv;
|
|
struct regmap *regmap;
|
|
struct regmap_field *ps_forward;
|
|
struct regmap_field *ps_management;
|
|
struct regmap_field *ps_sel_speed;
|
|
struct regmap_field *ps_cur_speed;
|
|
struct delayed_work mib_work;
|
|
struct xrs700x_port *ports;
|
|
};
|
|
|
|
struct xrs700x *xrs700x_switch_alloc(struct device *base, void *devpriv);
|
|
int xrs700x_switch_register(struct xrs700x *priv);
|
|
void xrs700x_switch_remove(struct xrs700x *priv);
|
|
void xrs700x_switch_shutdown(struct xrs700x *priv);
|