linux-stable/drivers/net/wireless/iwmc3200wifi
Julia Lawall 9f9857bb5e drivers/net/wireless: introduce missing kfree
Error handling code following a kzalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-08-03 16:31:23 -04:00
..
bus.h
cfg80211.c iwmc3200wifi: fix fragmentation threshold setting 2009-06-03 14:05:10 -04:00
cfg80211.h
commands.c drivers/net/wireless: introduce missing kfree 2009-08-03 16:31:23 -04:00
commands.h
debug.h
debugfs.c
eeprom.c
eeprom.h
fw.c iwmc3200wifi: fix printk format 2009-06-03 14:05:10 -04:00
fw.h
hal.c
hal.h
iwm.h iwmc3200wifi: add a mutex to protect iwm_reset_worker 2009-06-19 11:50:16 -04:00
Kconfig iwmc3200wifi: add Kconfig help 2009-07-07 12:55:27 -04:00
lmac.h
main.c iwmc3200wifi: add a mutex to protect iwm_reset_worker 2009-06-19 11:50:16 -04:00
Makefile iwm: port to new cfg80211 rfkill 2009-06-03 14:06:14 -04:00
netdev.c wireless: ERR_PTR vs null 2009-07-27 15:19:35 -04:00
rx.c
rx.h
sdio.c iwmc3200wifi: fix potential kernel oops on module removal 2009-06-19 11:50:16 -04:00
sdio.h
tx.c
umac.h
wext.c