mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-28 15:20:41 +00:00
272725c7db
Replace uses of fb->bits_per_pixel with fb->format->cpp[0]*8. Less duplicated information is a good thing. Note that I didn't put parens around the cpp*8 in the below cocci script, on account of not wanting spurious parens all over the place. Instead I did the unsafe way, and tried to look over the entire diff to spot if any dangerous expressions were produced. I didn't see any. There are some cases where previously the code did X*bpp/8, so the division happened after the multiplication. Those are now just X*cpp so the division effectively happens before the multiplication, but that is perfectly fine since bpp is always a multiple of 8. @@ struct drm_framebuffer *FB; expression E; @@ drm_helper_mode_fill_fb_struct(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer *FB; expression E; @@ i9xx_get_initial_plane_config(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer *FB; expression E; @@ ironlake_get_initial_plane_config(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer *FB; expression E; @@ skylake_get_initial_plane_config(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer FB; expression E; @@ ( - E * FB.bits_per_pixel / 8 + E * FB.format->cpp[0] | - FB.bits_per_pixel / 8 + FB.format->cpp[0] | - E * FB.bits_per_pixel >> 3 + E * FB.format->cpp[0] | - FB.bits_per_pixel >> 3 + FB.format->cpp[0] | - (FB.bits_per_pixel + 7) / 8 + FB.format->cpp[0] | - FB.bits_per_pixel + FB.format->cpp[0] * 8 | - FB.format->cpp[0] * 8 != 8 + FB.format->cpp[0] != 1 ) @@ struct drm_framebuffer *FB; expression E; @@ ( - E * FB->bits_per_pixel / 8 + E * FB->format->cpp[0] | - FB->bits_per_pixel / 8 + FB->format->cpp[0] | - E * FB->bits_per_pixel >> 3 + E * FB->format->cpp[0] | - FB->bits_per_pixel >> 3 + FB->format->cpp[0] | - (FB->bits_per_pixel + 7) / 8 + FB->format->cpp[0] | - FB->bits_per_pixel + FB->format->cpp[0] * 8 | - FB->format->cpp[0] * 8 != 8 + FB->format->cpp[0] != 1 ) @@ struct drm_plane_state *state; expression E; @@ ( - E * state->fb->bits_per_pixel / 8 + E * state->fb->format->cpp[0] | - state->fb->bits_per_pixel / 8 + state->fb->format->cpp[0] | - E * state->fb->bits_per_pixel >> 3 + E * state->fb->format->cpp[0] | - state->fb->bits_per_pixel >> 3 + state->fb->format->cpp[0] | - (state->fb->bits_per_pixel + 7) / 8 + state->fb->format->cpp[0] | - state->fb->bits_per_pixel + state->fb->format->cpp[0] * 8 | - state->fb->format->cpp[0] * 8 != 8 + state->fb->format->cpp[0] != 1 ) @@ @@ - (8 * 8) + 8 * 8 @@ struct drm_framebuffer FB; @@ - (FB.format->cpp[0]) + FB.format->cpp[0] @@ struct drm_framebuffer *FB; @@ - (FB->format->cpp[0]) + FB->format->cpp[0] @@ @@ struct drm_framebuffer { ... - int bits_per_pixel; ... }; v2: Clean up the 'cpp*8 != 8' and '(8 * 8)' cases (Laurent) v3: Adjusted the semantic patch a bit and regenerated due to code changes Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> (v1) Link: http://patchwork.freedesktop.org/patch/msgid/1481751140-18352-1-git-send-email-ville.syrjala@linux.intel.com |
||
---|---|---|
.. | ||
dispnv04 | ||
include | ||
nvif | ||
nvkm | ||
Kbuild | ||
Kconfig | ||
nouveau_abi16.c | ||
nouveau_abi16.h | ||
nouveau_acpi.c | ||
nouveau_acpi.h | ||
nouveau_backlight.c | ||
nouveau_bios.c | ||
nouveau_bios.h | ||
nouveau_bo.c | ||
nouveau_bo.h | ||
nouveau_chan.c | ||
nouveau_chan.h | ||
nouveau_connector.c | ||
nouveau_connector.h | ||
nouveau_crtc.h | ||
nouveau_debugfs.c | ||
nouveau_debugfs.h | ||
nouveau_display.c | ||
nouveau_display.h | ||
nouveau_dma.c | ||
nouveau_dma.h | ||
nouveau_dp.c | ||
nouveau_drm.c | ||
nouveau_drv.h | ||
nouveau_encoder.h | ||
nouveau_fbcon.c | ||
nouveau_fbcon.h | ||
nouveau_fence.c | ||
nouveau_fence.h | ||
nouveau_gem.c | ||
nouveau_gem.h | ||
nouveau_hwmon.c | ||
nouveau_hwmon.h | ||
nouveau_ioc32.c | ||
nouveau_ioctl.h | ||
nouveau_led.c | ||
nouveau_led.h | ||
nouveau_nvif.c | ||
nouveau_platform.c | ||
nouveau_platform.h | ||
nouveau_prime.c | ||
nouveau_reg.h | ||
nouveau_sgdma.c | ||
nouveau_ttm.c | ||
nouveau_ttm.h | ||
nouveau_usif.c | ||
nouveau_usif.h | ||
nouveau_vga.c | ||
nouveau_vga.h | ||
nv04_fbcon.c | ||
nv04_fence.c | ||
nv10_fence.c | ||
nv10_fence.h | ||
nv17_fence.c | ||
nv50_display.c | ||
nv50_display.h | ||
nv50_fbcon.c | ||
nv50_fence.c | ||
nv84_fence.c | ||
nvc0_fbcon.c | ||
nvc0_fence.c |