mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-27 14:45:19 +00:00
297d716f62
Change the ownership of power_supply structure from each driver
implementing the class to the power supply core.
The patch changes power_supply_register() function thus all drivers
implementing power supply class are adjusted.
Each driver provides the implementation of power supply. However it
should not be the owner of power supply class instance because it is
exposed by core to other subsystems with power_supply_get_by_name().
These other subsystems have no knowledge when the driver will unregister
the power supply. This leads to several issues when driver is unbound -
mostly because user of power supply accesses freed memory.
Instead let the core own the instance of struct 'power_supply'. Other
users of this power supply will still access valid memory because it
will be freed when device reference count reaches 0. Currently this
means "it will leak" but power_supply_put() call in next patches will
solve it.
This solves invalid memory references in following race condition
scenario:
Thread 1: charger manager
Thread 2: power supply driver, used by charger manager
THREAD 1 (charger manager) THREAD 2 (power supply driver)
========================== ==============================
psy = power_supply_get_by_name()
Driver unbind, .remove
power_supply_unregister()
Device fully removed
psy->get_property()
The 'get_property' call is executed in invalid context because the driver was
unbound and struct 'power_supply' memory was freed.
This could be observed easily with charger manager driver (here compiled
with max17040 fuel gauge):
$ cat /sys/devices/virtual/power_supply/cm-battery/capacity &
$ echo "1-0036" > /sys/bus/i2c/drivers/max17040/unbind
[ 55.725123] Unable to handle kernel NULL pointer dereference at virtual address 00000000
[ 55.732584] pgd = d98d4000
[ 55.734060] [00000000] *pgd=5afa2831, *pte=00000000, *ppte=00000000
[ 55.740318] Internal error: Oops: 80000007 [#1] PREEMPT SMP ARM
[ 55.746210] Modules linked in:
[ 55.749259] CPU: 1 PID: 2936 Comm: cat Tainted: G W 3.19.0-rc1-next-20141226-00048-gf79f475f3c44-dirty #1496
[ 55.760190] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
[ 55.766270] task: d9b76f00 ti: daf54000 task.ti: daf54000
[ 55.771647] PC is at 0x0
[ 55.774182] LR is at charger_get_property+0x2f4/0x36c
[ 55.779201] pc : [<00000000>] lr : [<c034b0b4>] psr: 60000013
[ 55.779201] sp : daf55e90 ip : 00000003 fp : 00000000
[ 55.790657] r10: 00000000 r9 : c06e2878 r8 : d9b26c68
[ 55.795865] r7 : dad81610 r6 : daec7410 r5 : daf55ebc r4 : 00000000
[ 55.802367] r3 : 00000000 r2 : daf55ebc r1 : 0000002a r0 : d9b26c68
[ 55.808879] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user
[ 55.815994] Control: 10c5387d Table: 598d406a DAC: 00000015
[ 55.821723] Process cat (pid: 2936, stack limit = 0xdaf54210)
[ 55.827451] Stack: (0xdaf55e90 to 0xdaf56000)
[ 55.831795] 5e80: 60000013 c01459c4 0000002a c06f8ef8
[ 55.839956] 5ea0: db651000 c06f8ef8 daebac00 c04cb668 daebac08 c0346864 00000000 c01459c4
[ 55.848115] 5ec0: d99eaa80 c06f8ef8 00000fff 00001000 db651000 c027f25c c027f240 d99eaa80
[ 55.856274] 5ee0: d9a06c00 c0146218 daf55f18 00001000 d99eaa80 db4c18c0 00000001 00000001
[ 55.864468] 5f00: daf55f80 c0144c78 c0144c54 c0107f90 00015000 d99eaab0 00000000 00000000
[ 55.872603] 5f20: 000051c7 00000000 db4c18c0 c04a9370 00015000 00001000 daf55f80 00001000
[ 55.880763] 5f40: daf54000 00015000 00000000 c00e53dc db4c18c0 c00e548c 0000000d 00008124
[ 55.888937] 5f60: 00000001 00000000 00000000 db4c18c0 db4c18c0 00001000 00015000 c00e5550
[ 55.897099] 5f80: 00000000 00000000 00001000 00001000 00015000 00000003 00000003 c000f364
[ 55.905239] 5fa0: 00000000 c000f1a0 00001000 00015000 00000003 00015000 00001000 0001333c
[ 55.913399] 5fc0: 00001000 00015000 00000003 00000003 00000002 00000000 00000000 00000000
[ 55.921560] 5fe0: 7fffe000 be999850 0000a225 b6f3c19c 60000010 00000003 00000000 00000000
[ 55.929744] [<c034b0b4>] (charger_get_property) from [<c0346864>] (power_supply_show_property+0x48/0x20c)
[ 55.939286] [<c0346864>] (power_supply_show_property) from [<c027f25c>] (dev_attr_show+0x1c/0x48)
[ 55.948130] [<c027f25c>] (dev_attr_show) from [<c0146218>] (sysfs_kf_seq_show+0x84/0x104)
[ 55.956298] [<c0146218>] (sysfs_kf_seq_show) from [<c0144c78>] (kernfs_seq_show+0x24/0x28)
[ 55.964536] [<c0144c78>] (kernfs_seq_show) from [<c0107f90>] (seq_read+0x1b0/0x484)
[ 55.972172] [<c0107f90>] (seq_read) from [<c00e53dc>] (__vfs_read+0x18/0x4c)
[ 55.979188] [<c00e53dc>] (__vfs_read) from [<c00e548c>] (vfs_read+0x7c/0x100)
[ 55.986304] [<c00e548c>] (vfs_read) from [<c00e5550>] (SyS_read+0x40/0x8c)
[ 55.993164] [<c00e5550>] (SyS_read) from [<c000f1a0>] (ret_fast_syscall+0x0/0x48)
[ 56.000626] Code: bad PC value
[ 56.011652] ---[ end trace 7b64343fbdae8ef1 ]---
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
[for the nvec part]
Reviewed-by: Marc Dietrich <marvin24@gmx.de>
[for compal-laptop.c]
Acked-by: Darren Hart <dvhart@linux.intel.com>
[for the mfd part]
Acked-by: Lee Jones <lee.jones@linaro.org>
[for the hid part]
Acked-by: Jiri Kosina <jkosina@suse.cz>
[for the acpi part]
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
154 lines
6.1 KiB
C
154 lines
6.1 KiB
C
/*
|
|
* drivers/input/tablet/wacom.h
|
|
*
|
|
* USB Wacom tablet support
|
|
*
|
|
* Copyright (c) 2000-2004 Vojtech Pavlik <vojtech@ucw.cz>
|
|
* Copyright (c) 2000 Andreas Bach Aaen <abach@stofanet.dk>
|
|
* Copyright (c) 2000 Clifford Wolf <clifford@clifford.at>
|
|
* Copyright (c) 2000 Sam Mosel <sam.mosel@computer.org>
|
|
* Copyright (c) 2000 James E. Blair <corvus@gnu.org>
|
|
* Copyright (c) 2000 Daniel Egger <egger@suse.de>
|
|
* Copyright (c) 2001 Frederic Lepied <flepied@mandrakesoft.com>
|
|
* Copyright (c) 2004 Panagiotis Issaris <panagiotis.issaris@mech.kuleuven.ac.be>
|
|
* Copyright (c) 2002-2011 Ping Cheng <pingc@wacom.com>
|
|
* Copyright (c) 2014 Benjamin Tissoires <benjamin.tissoires@redhat.com>
|
|
*
|
|
* ChangeLog:
|
|
* v0.1 (vp) - Initial release
|
|
* v0.2 (aba) - Support for all buttons / combinations
|
|
* v0.3 (vp) - Support for Intuos added
|
|
* v0.4 (sm) - Support for more Intuos models, menustrip
|
|
* relative mode, proximity.
|
|
* v0.5 (vp) - Big cleanup, nifty features removed,
|
|
* they belong in userspace
|
|
* v1.8 (vp) - Submit URB only when operating, moved to CVS,
|
|
* use input_report_key instead of report_btn and
|
|
* other cleanups
|
|
* v1.11 (vp) - Add URB ->dev setting for new kernels
|
|
* v1.11 (jb) - Add support for the 4D Mouse & Lens
|
|
* v1.12 (de) - Add support for two more inking pen IDs
|
|
* v1.14 (vp) - Use new USB device id probing scheme.
|
|
* Fix Wacom Graphire mouse wheel
|
|
* v1.18 (vp) - Fix mouse wheel direction
|
|
* Make mouse relative
|
|
* v1.20 (fl) - Report tool id for Intuos devices
|
|
* - Multi tools support
|
|
* - Corrected Intuos protocol decoding (airbrush, 4D mouse, lens cursor...)
|
|
* - Add PL models support
|
|
* - Fix Wacom Graphire mouse wheel again
|
|
* v1.21 (vp) - Removed protocol descriptions
|
|
* - Added MISC_SERIAL for tool serial numbers
|
|
* (gb) - Identify version on module load.
|
|
* v1.21.1 (fl) - added Graphire2 support
|
|
* v1.21.2 (fl) - added Intuos2 support
|
|
* - added all the PL ids
|
|
* v1.21.3 (fl) - added another eraser id from Neil Okamoto
|
|
* - added smooth filter for Graphire from Peri Hankey
|
|
* - added PenPartner support from Olaf van Es
|
|
* - new tool ids from Ole Martin Bjoerndalen
|
|
* v1.29 (pc) - Add support for more tablets
|
|
* - Fix pressure reporting
|
|
* v1.30 (vp) - Merge 2.4 and 2.5 drivers
|
|
* - Since 2.5 now has input_sync(), remove MSC_SERIAL abuse
|
|
* - Cleanups here and there
|
|
* v1.30.1 (pi) - Added Graphire3 support
|
|
* v1.40 (pc) - Add support for several new devices, fix eraser reporting, ...
|
|
* v1.43 (pc) - Added support for Cintiq 21UX
|
|
* - Fixed a Graphire bug
|
|
* - Merged wacom_intuos3_irq into wacom_intuos_irq
|
|
* v1.44 (pc) - Added support for Graphire4, Cintiq 710, Intuos3 6x11, etc.
|
|
* - Report Device IDs
|
|
* v1.45 (pc) - Added support for DTF 521, Intuos3 12x12 and 12x19
|
|
* - Minor data report fix
|
|
* v1.46 (pc) - Split wacom.c into wacom_sys.c and wacom_wac.c,
|
|
* - where wacom_sys.c deals with system specific code,
|
|
* - and wacom_wac.c deals with Wacom specific code
|
|
* - Support Intuos3 4x6
|
|
* v1.47 (pc) - Added support for Bamboo
|
|
* v1.48 (pc) - Added support for Bamboo1, BambooFun, and Cintiq 12WX
|
|
* v1.49 (pc) - Added support for USB Tablet PC (0x90, 0x93, and 0x9A)
|
|
* v1.50 (pc) - Fixed a TabletPC touch bug in 2.6.28
|
|
* v1.51 (pc) - Added support for Intuos4
|
|
* v1.52 (pc) - Query Wacom data upon system resume
|
|
* - add defines for features->type
|
|
* - add new devices (0x9F, 0xE2, and 0XE3)
|
|
* v2.00 (bt) - conversion to a HID driver
|
|
* - integration of the Bluetooth devices
|
|
*/
|
|
|
|
/*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*/
|
|
#ifndef WACOM_H
|
|
#define WACOM_H
|
|
#include <linux/kernel.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/module.h>
|
|
#include <linux/mod_devicetable.h>
|
|
#include <linux/hid.h>
|
|
#include <linux/usb/input.h>
|
|
#include <linux/power_supply.h>
|
|
#include <asm/unaligned.h>
|
|
|
|
/*
|
|
* Version Information
|
|
*/
|
|
#define DRIVER_VERSION "v2.00"
|
|
#define DRIVER_AUTHOR "Vojtech Pavlik <vojtech@ucw.cz>"
|
|
#define DRIVER_DESC "USB Wacom tablet driver"
|
|
#define DRIVER_LICENSE "GPL"
|
|
|
|
#define USB_VENDOR_ID_WACOM 0x056a
|
|
#define USB_VENDOR_ID_LENOVO 0x17ef
|
|
|
|
struct wacom {
|
|
struct usb_device *usbdev;
|
|
struct usb_interface *intf;
|
|
struct wacom_wac wacom_wac;
|
|
struct hid_device *hdev;
|
|
struct mutex lock;
|
|
struct work_struct work;
|
|
struct wacom_led {
|
|
u8 select[2]; /* status led selector (0..3) */
|
|
u8 llv; /* status led brightness no button (1..127) */
|
|
u8 hlv; /* status led brightness button pressed (1..127) */
|
|
u8 img_lum; /* OLED matrix display brightness */
|
|
} led;
|
|
bool led_initialized;
|
|
struct power_supply *battery;
|
|
struct power_supply *ac;
|
|
struct power_supply_desc battery_desc;
|
|
struct power_supply_desc ac_desc;
|
|
};
|
|
|
|
static inline void wacom_schedule_work(struct wacom_wac *wacom_wac)
|
|
{
|
|
struct wacom *wacom = container_of(wacom_wac, struct wacom, wacom_wac);
|
|
schedule_work(&wacom->work);
|
|
}
|
|
|
|
static inline void wacom_notify_battery(struct wacom_wac *wacom_wac)
|
|
{
|
|
struct wacom *wacom = container_of(wacom_wac, struct wacom, wacom_wac);
|
|
|
|
power_supply_changed(wacom->battery);
|
|
}
|
|
|
|
extern const struct hid_device_id wacom_ids[];
|
|
|
|
void wacom_wac_irq(struct wacom_wac *wacom_wac, size_t len);
|
|
void wacom_setup_device_quirks(struct wacom_features *features);
|
|
int wacom_setup_pentouch_input_capabilities(struct input_dev *input_dev,
|
|
struct wacom_wac *wacom_wac);
|
|
int wacom_setup_pad_input_capabilities(struct input_dev *input_dev,
|
|
struct wacom_wac *wacom_wac);
|
|
void wacom_wac_usage_mapping(struct hid_device *hdev,
|
|
struct hid_field *field, struct hid_usage *usage);
|
|
int wacom_wac_event(struct hid_device *hdev, struct hid_field *field,
|
|
struct hid_usage *usage, __s32 value);
|
|
void wacom_wac_report(struct hid_device *hdev, struct hid_report *report);
|
|
#endif
|