linux-stable/sound/usb/line6
Takashi Iwai 2a4340c577 ALSA: line6: Add a sanity check for invalid EPs
As syzkaller spotted, currently line6 drivers submit a URB with the
fixed EP without checking whether it's actually available, which may
result in a kernel warning like:
  usb 1-1: BOGUS urb xfer, pipe 3 != type 1
  ------------[ cut here ]------------
  WARNING: CPU: 0 PID: 24 at drivers/usb/core/urb.c:449
  usb_submit_urb+0xf8a/0x11d0
  Modules linked in:
  CPU: 0 PID: 24 Comm: kworker/0:1 Not tainted 4.14.0-rc2-42613-g1488251d1a98 #238
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
  Workqueue: usb_hub_wq hub_event
  Call Trace:
   line6_start_listen+0x55f/0x9e0 sound/usb/line6/driver.c:82
   line6_init_cap_control sound/usb/line6/driver.c:690
   line6_probe+0x7c9/0x1310 sound/usb/line6/driver.c:764
   podhd_probe+0x64/0x70 sound/usb/line6/podhd.c:474
   usb_probe_interface+0x35d/0x8e0 drivers/usb/core/driver.c:361
   ....

This patch adds a sanity check of validity of EPs at the device
initialization phase for avoiding the call with an invalid EP.

Reported-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2017-10-11 15:14:50 +02:00
..
capture.c ALSA: line6: Add LINE6_CAP_IN_NEEDS_OUT, a void playback stream during capture 2016-09-19 23:00:37 +02:00
capture.h ALSA: line6: Reorganize PCM stream handling 2015-01-28 07:22:36 +01:00
driver.c ALSA: line6: Add a sanity check for invalid EPs 2017-10-11 15:14:50 +02:00
driver.h ALSA: line6: remove unnecessary initialization to PODHD500X 2017-06-20 07:51:22 +02:00
Kconfig ALSA: line6: snd-usb-line6 depends on CONFIG_SND_HWDEP 2016-09-21 14:36:22 +02:00
Makefile ALSA: line6: Reorganize card resource handling 2015-01-20 08:17:16 +01:00
midi.c ALSA: usb: Constify snd_rawmidi_ops 2017-01-12 12:50:48 +01:00
midi.h ALSA: line6: Tidy up and typo fixes in comments 2015-01-28 20:54:43 +01:00
midibuf.c ALSA: line6: Remove unused line6_midibuf_skip_message() 2015-02-01 09:35:25 +01:00
midibuf.h ALSA: line6: Remove unused line6_midibuf_skip_message() 2015-02-01 09:35:25 +01:00
pcm.c ALSA: usb-line6: constify snd_kcontrol_new strucutre array 2017-04-14 08:57:56 +02:00
pcm.h ALSA: line6: Add LINE6_CAP_IN_NEEDS_OUT, a void playback stream during capture 2016-09-19 23:00:37 +02:00
playback.c ALSA: line6: Allow different channel numbers for in/out 2016-09-19 23:00:16 +02:00
playback.h ALSA: line6: Reorganize PCM stream handling 2015-01-28 07:22:36 +01:00
pod.c ALSA: line6: constify snd_kcontrol_new structures 2017-04-12 15:35:16 +02:00
podhd.c ALSA: line6: remove unnecessary initialization to PODHD500X 2017-06-20 07:51:22 +02:00
toneport.c ALSA: line6: constify snd_kcontrol_new structures 2017-04-12 15:35:16 +02:00
variax.c ALSA: line6: Distinguish device init (ctrl EP) and MIDI data transfer (int EP) 2016-09-19 23:00:47 +02:00