mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 01:41:39 +00:00
938835aa90
A struct device is a dynamic structure, with reference counting.
"Tricking" the kernel to make a dynamic structure static, by working
around the driver core release detection logic, is not nice.
Because of this, this code has been used as an example for others on
"how to do things", which is just about the worst thing possible to have
happen.
Fix this all up by making the platform device dynamic and providing a
real release function.
Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
Cc: Vishwanath Somayaji <vishwanath.somayaji@intel.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
Cc: Rajat Jain <rajatja@google.com>
Cc: platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reported-by: Maximilian Luz <luzmaximilian@gmail.com>
Fixes: b02f6a2ef0 ("platform/x86: intel_pmc_core: Attach using APCI HID "INT33A1"")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Rajat Jain <rajatja@google.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
80 lines
2.4 KiB
C
80 lines
2.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
/*
|
|
* Intel PMC Core platform init
|
|
* Copyright (c) 2019, Google Inc.
|
|
* Author - Rajat Jain
|
|
*
|
|
* This code instantiates platform devices for intel_pmc_core driver, only
|
|
* on supported platforms that may not have the ACPI devices in the ACPI tables.
|
|
* No new platforms should be added here, because we expect that new platforms
|
|
* should all have the ACPI device, which is the preferred way of enumeration.
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <asm/cpu_device_id.h>
|
|
#include <asm/intel-family.h>
|
|
|
|
static void intel_pmc_core_release(struct device *dev)
|
|
{
|
|
kfree(dev);
|
|
}
|
|
|
|
static struct platform_device *pmc_core_device;
|
|
|
|
/*
|
|
* intel_pmc_core_platform_ids is the list of platforms where we want to
|
|
* instantiate the platform_device if not already instantiated. This is
|
|
* different than intel_pmc_core_ids in intel_pmc_core.c which is the
|
|
* list of platforms that the driver supports for pmc_core device. The
|
|
* other list may grow, but this list should not.
|
|
*/
|
|
static const struct x86_cpu_id intel_pmc_core_platform_ids[] = {
|
|
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_L, &pmc_core_device),
|
|
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE, &pmc_core_device),
|
|
X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE_L, &pmc_core_device),
|
|
X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE, &pmc_core_device),
|
|
X86_MATCH_INTEL_FAM6_MODEL(CANNONLAKE_L, &pmc_core_device),
|
|
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_L, &pmc_core_device),
|
|
X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE, &pmc_core_device),
|
|
X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE_L, &pmc_core_device),
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_platform_ids);
|
|
|
|
static int __init pmc_core_platform_init(void)
|
|
{
|
|
int retval;
|
|
|
|
/* Skip creating the platform device if ACPI already has a device */
|
|
if (acpi_dev_present("INT33A1", NULL, -1))
|
|
return -ENODEV;
|
|
|
|
if (!x86_match_cpu(intel_pmc_core_platform_ids))
|
|
return -ENODEV;
|
|
|
|
pmc_core_device = kzalloc(sizeof(*pmc_core_device), GFP_KERNEL);
|
|
if (!pmc_core_device)
|
|
return -ENOMEM;
|
|
|
|
pmc_core_device->name = "intel_pmc_core";
|
|
pmc_core_device->dev.release = intel_pmc_core_release;
|
|
|
|
retval = platform_device_register(pmc_core_device);
|
|
if (retval)
|
|
kfree(pmc_core_device);
|
|
|
|
return retval;
|
|
}
|
|
|
|
static void __exit pmc_core_platform_exit(void)
|
|
{
|
|
platform_device_unregister(pmc_core_device);
|
|
}
|
|
|
|
module_init(pmc_core_platform_init);
|
|
module_exit(pmc_core_platform_exit);
|
|
MODULE_LICENSE("GPL v2");
|