mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-14 06:35:12 +00:00
3370db3519
Registering real device entries (struct device) for the mode
muxes as well as for the orientation switches.
The Type-C mux code was deliberately attempting to avoid
creation of separate device entries for the orientation
switch and the mode switch (alternate modes) because they
are not physical devices. They are functions of a single
physical multiplexer/demultiplexer switch device.
Unfortunately because of the dependency we still have on the
underlying mux device driver, we had to put in hacks like
the one in the commit 3e3b81965c ("usb: typec: mux: Take
care of driver module reference counting") to make sure the
driver does not disappear from underneath us. Even with
those hacks we were still left with a potential NUll pointer
dereference scenario, so just creating the device entries,
and letting the core take care of the dependencies. No more
hacks needed.
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
53 lines
1.2 KiB
C
53 lines
1.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
|
|
#ifndef __USB_TYPEC_ALTMODE_H__
|
|
#define __USB_TYPEC_ALTMODE_H__
|
|
|
|
#include <linux/usb/typec_altmode.h>
|
|
#include <linux/usb/typec_mux.h>
|
|
|
|
struct bus_type;
|
|
|
|
struct altmode {
|
|
unsigned int id;
|
|
struct typec_altmode adev;
|
|
struct typec_mux *mux;
|
|
|
|
enum typec_port_data roles;
|
|
|
|
struct attribute *attrs[5];
|
|
char group_name[8];
|
|
struct attribute_group group;
|
|
const struct attribute_group *groups[2];
|
|
|
|
struct altmode *partner;
|
|
struct altmode *plug[2];
|
|
|
|
struct blocking_notifier_head nh;
|
|
};
|
|
|
|
#define to_altmode(d) container_of(d, struct altmode, adev)
|
|
|
|
extern struct bus_type typec_bus;
|
|
extern const struct device_type typec_altmode_dev_type;
|
|
extern const struct device_type typec_port_dev_type;
|
|
|
|
#define is_typec_altmode(_dev_) (_dev_->type == &typec_altmode_dev_type)
|
|
#define is_typec_port(_dev_) (_dev_->type == &typec_port_dev_type)
|
|
|
|
extern struct class typec_mux_class;
|
|
|
|
struct typec_switch {
|
|
struct device dev;
|
|
typec_switch_set_fn_t set;
|
|
};
|
|
|
|
struct typec_mux {
|
|
struct device dev;
|
|
typec_mux_set_fn_t set;
|
|
};
|
|
|
|
#define to_typec_switch(_dev_) container_of(_dev_, struct typec_switch, dev)
|
|
#define to_typec_mux(_dev_) container_of(_dev_, struct typec_mux, dev)
|
|
|
|
#endif /* __USB_TYPEC_ALTMODE_H__ */
|