mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-31 08:28:13 +00:00
8c300fe282
When unloading omap2430, we can get the following splat:
WARNING: CPU: 1 PID: 295 at kernel/irq/manage.c:1478 __free_irq+0xa8/0x2c8
Trying to free already-free IRQ 4
...
[<c01a8b78>] (free_irq) from [<bf0aea84>]
(musbhs_dma_controller_destroy+0x28/0xb0 [musb_hdrc])
[<bf0aea84>] (musbhs_dma_controller_destroy [musb_hdrc]) from
[<bf09f88c>] (musb_remove+0xf0/0x12c [musb_hdrc])
[<bf09f88c>] (musb_remove [musb_hdrc]) from [<c056a384>]
(platform_drv_remove+0x24/0x3c)
...
This is because the irq number in use is 260 nowadays, and the dma
controller is using u8 instead of int.
Fixes: 6995eb68aa ("USB: musb: enable low level DMA operation for Blackfin")
Signed-off-by: Tony Lindgren <tony@atomide.com>
[b-liu@ti.com: added Fixes tag]
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
161 lines
4.9 KiB
C
161 lines
4.9 KiB
C
/*
|
|
* MUSB OTG driver - support for Mentor's DMA controller
|
|
*
|
|
* Copyright 2005 Mentor Graphics Corporation
|
|
* Copyright (C) 2005-2007 by Texas Instruments
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* version 2 as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
|
|
* 02110-1301 USA
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED
|
|
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
|
|
* NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
|
|
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
|
|
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
*/
|
|
|
|
#ifndef CONFIG_BLACKFIN
|
|
|
|
#define MUSB_HSDMA_BASE 0x200
|
|
#define MUSB_HSDMA_INTR (MUSB_HSDMA_BASE + 0)
|
|
#define MUSB_HSDMA_CONTROL 0x4
|
|
#define MUSB_HSDMA_ADDRESS 0x8
|
|
#define MUSB_HSDMA_COUNT 0xc
|
|
|
|
#define MUSB_HSDMA_CHANNEL_OFFSET(_bchannel, _offset) \
|
|
(MUSB_HSDMA_BASE + (_bchannel << 4) + _offset)
|
|
|
|
#define musb_read_hsdma_addr(mbase, bchannel) \
|
|
musb_readl(mbase, \
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_ADDRESS))
|
|
|
|
#define musb_write_hsdma_addr(mbase, bchannel, addr) \
|
|
musb_writel(mbase, \
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_ADDRESS), \
|
|
addr)
|
|
|
|
#define musb_read_hsdma_count(mbase, bchannel) \
|
|
musb_readl(mbase, \
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_COUNT))
|
|
|
|
#define musb_write_hsdma_count(mbase, bchannel, len) \
|
|
musb_writel(mbase, \
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_COUNT), \
|
|
len)
|
|
#else
|
|
|
|
#define MUSB_HSDMA_BASE 0x400
|
|
#define MUSB_HSDMA_INTR (MUSB_HSDMA_BASE + 0)
|
|
#define MUSB_HSDMA_CONTROL 0x04
|
|
#define MUSB_HSDMA_ADDR_LOW 0x08
|
|
#define MUSB_HSDMA_ADDR_HIGH 0x0C
|
|
#define MUSB_HSDMA_COUNT_LOW 0x10
|
|
#define MUSB_HSDMA_COUNT_HIGH 0x14
|
|
|
|
#define MUSB_HSDMA_CHANNEL_OFFSET(_bchannel, _offset) \
|
|
(MUSB_HSDMA_BASE + (_bchannel * 0x20) + _offset)
|
|
|
|
static inline u32 musb_read_hsdma_addr(void __iomem *mbase, u8 bchannel)
|
|
{
|
|
u32 addr = musb_readw(mbase,
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_ADDR_HIGH));
|
|
|
|
addr = addr << 16;
|
|
|
|
addr |= musb_readw(mbase,
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_ADDR_LOW));
|
|
|
|
return addr;
|
|
}
|
|
|
|
static inline void musb_write_hsdma_addr(void __iomem *mbase,
|
|
u8 bchannel, dma_addr_t dma_addr)
|
|
{
|
|
musb_writew(mbase,
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_ADDR_LOW),
|
|
dma_addr);
|
|
musb_writew(mbase,
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_ADDR_HIGH),
|
|
(dma_addr >> 16));
|
|
}
|
|
|
|
static inline u32 musb_read_hsdma_count(void __iomem *mbase, u8 bchannel)
|
|
{
|
|
u32 count = musb_readw(mbase,
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_COUNT_HIGH));
|
|
|
|
count = count << 16;
|
|
|
|
count |= musb_readw(mbase,
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_COUNT_LOW));
|
|
|
|
return count;
|
|
}
|
|
|
|
static inline void musb_write_hsdma_count(void __iomem *mbase,
|
|
u8 bchannel, u32 len)
|
|
{
|
|
musb_writew(mbase,
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_COUNT_LOW),len);
|
|
musb_writew(mbase,
|
|
MUSB_HSDMA_CHANNEL_OFFSET(bchannel, MUSB_HSDMA_COUNT_HIGH),
|
|
(len >> 16));
|
|
}
|
|
|
|
#endif /* CONFIG_BLACKFIN */
|
|
|
|
/* control register (16-bit): */
|
|
#define MUSB_HSDMA_ENABLE_SHIFT 0
|
|
#define MUSB_HSDMA_TRANSMIT_SHIFT 1
|
|
#define MUSB_HSDMA_MODE1_SHIFT 2
|
|
#define MUSB_HSDMA_IRQENABLE_SHIFT 3
|
|
#define MUSB_HSDMA_ENDPOINT_SHIFT 4
|
|
#define MUSB_HSDMA_BUSERROR_SHIFT 8
|
|
#define MUSB_HSDMA_BURSTMODE_SHIFT 9
|
|
#define MUSB_HSDMA_BURSTMODE (3 << MUSB_HSDMA_BURSTMODE_SHIFT)
|
|
#define MUSB_HSDMA_BURSTMODE_UNSPEC 0
|
|
#define MUSB_HSDMA_BURSTMODE_INCR4 1
|
|
#define MUSB_HSDMA_BURSTMODE_INCR8 2
|
|
#define MUSB_HSDMA_BURSTMODE_INCR16 3
|
|
|
|
#define MUSB_HSDMA_CHANNELS 8
|
|
|
|
struct musb_dma_controller;
|
|
|
|
struct musb_dma_channel {
|
|
struct dma_channel channel;
|
|
struct musb_dma_controller *controller;
|
|
u32 start_addr;
|
|
u32 len;
|
|
u16 max_packet_sz;
|
|
u8 idx;
|
|
u8 epnum;
|
|
u8 transmit;
|
|
};
|
|
|
|
struct musb_dma_controller {
|
|
struct dma_controller controller;
|
|
struct musb_dma_channel channel[MUSB_HSDMA_CHANNELS];
|
|
void *private_data;
|
|
void __iomem *base;
|
|
u8 channel_count;
|
|
u8 used_channels;
|
|
int irq;
|
|
};
|