mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-28 20:02:17 +00:00
![Linus Torvalds](/assets/img/avatar_default.png)
Commit c724c866bb
("linux/types.h: remove unnecessary __bitwise__")
was right that there are no users of __bitwise__ in the kernel, but it
turns out there are user space users of it that do expect it.
It is, after all, in the uapi directory, so user space usage is to be
expected.
Instead of reverting the commit completely, let's just clarify the
situation so that it doesn't happen again, and have some in-code
explanations for why that "__bitwise__" still exists.
Reported-by: Jiri Slaby <jirislaby@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>
Link: https://lore.kernel.org/all/b5c0a68d-8387-4909-beea-f70ab9e6e3d5@kernel.org/
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
58 lines
1.8 KiB
C
58 lines
1.8 KiB
C
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
|
|
#ifndef _UAPI_LINUX_TYPES_H
|
|
#define _UAPI_LINUX_TYPES_H
|
|
|
|
#include <asm/types.h>
|
|
|
|
#ifndef __ASSEMBLY__
|
|
#ifndef __KERNEL__
|
|
#ifndef __EXPORTED_HEADERS__
|
|
#warning "Attempt to use kernel headers from user space, see https://kernelnewbies.org/KernelHeaders"
|
|
#endif /* __EXPORTED_HEADERS__ */
|
|
#endif
|
|
|
|
#include <linux/posix_types.h>
|
|
|
|
|
|
/*
|
|
* Below are truly Linux-specific types that should never collide with
|
|
* any application/library that wants linux/types.h.
|
|
*/
|
|
|
|
/* sparse defines __CHECKER__; see Documentation/dev-tools/sparse.rst */
|
|
#ifdef __CHECKER__
|
|
#define __bitwise __attribute__((bitwise))
|
|
#else
|
|
#define __bitwise
|
|
#endif
|
|
|
|
/* The kernel doesn't use this legacy form, but user space does */
|
|
#define __bitwise__ __bitwise
|
|
|
|
typedef __u16 __bitwise __le16;
|
|
typedef __u16 __bitwise __be16;
|
|
typedef __u32 __bitwise __le32;
|
|
typedef __u32 __bitwise __be32;
|
|
typedef __u64 __bitwise __le64;
|
|
typedef __u64 __bitwise __be64;
|
|
|
|
typedef __u16 __bitwise __sum16;
|
|
typedef __u32 __bitwise __wsum;
|
|
|
|
/*
|
|
* aligned_u64 should be used in defining kernel<->userspace ABIs to avoid
|
|
* common 32/64-bit compat problems.
|
|
* 64-bit values align to 4-byte boundaries on x86_32 (and possibly other
|
|
* architectures) and to 8-byte boundaries on 64-bit architectures. The new
|
|
* aligned_64 type enforces 8-byte alignment so that structs containing
|
|
* aligned_64 values have the same alignment on 32-bit and 64-bit architectures.
|
|
* No conversions are necessary between 32-bit user-space and a 64-bit kernel.
|
|
*/
|
|
#define __aligned_u64 __u64 __attribute__((aligned(8)))
|
|
#define __aligned_be64 __be64 __attribute__((aligned(8)))
|
|
#define __aligned_le64 __le64 __attribute__((aligned(8)))
|
|
|
|
typedef unsigned __bitwise __poll_t;
|
|
|
|
#endif /* __ASSEMBLY__ */
|
|
#endif /* _UAPI_LINUX_TYPES_H */
|