mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-28 20:02:17 +00:00
![Christian Brauner](/assets/img/avatar_default.png)
The posix acl permission checking helpers determine whether a caller is privileged over an inode according to the acls associated with the inode. Add helpers that make it possible to handle acls on idmapped mounts. The vfs and the filesystems targeted by this first iteration make use of posix_acl_fix_xattr_from_user() and posix_acl_fix_xattr_to_user() to translate basic posix access and default permissions such as the ACL_USER and ACL_GROUP type according to the initial user namespace (or the superblock's user namespace) to and from the caller's current user namespace. Adapt these two helpers to handle idmapped mounts whereby we either map from or into the mount's user namespace depending on in which direction we're translating. Similarly, cap_convert_nscap() is used by the vfs to translate user namespace and non-user namespace aware filesystem capabilities from the superblock's user namespace to the caller's user namespace. Enable it to handle idmapped mounts by accounting for the mount's user namespace. In addition the fileystems targeted in the first iteration of this patch series make use of the posix_acl_chmod() and, posix_acl_update_mode() helpers. Both helpers perform permission checks on the target inode. Let them handle idmapped mounts. These two helpers are called when posix acls are set by the respective filesystems to handle this case we extend the ->set() method to take an additional user namespace argument to pass the mount's user namespace down. Link: https://lore.kernel.org/r/20210121131959.646623-9-christian.brauner@ubuntu.com Cc: Christoph Hellwig <hch@lst.de> Cc: David Howells <dhowells@redhat.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: linux-fsdevel@vger.kernel.org Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
153 lines
3.1 KiB
C
153 lines
3.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* linux/fs/hfs/attr.c
|
|
*
|
|
* (C) 2003 Ardis Technologies <roman@ardistech.com>
|
|
*
|
|
* Export hfs data via xattr
|
|
*/
|
|
|
|
|
|
#include <linux/fs.h>
|
|
#include <linux/xattr.h>
|
|
|
|
#include "hfs_fs.h"
|
|
#include "btree.h"
|
|
|
|
enum hfs_xattr_type {
|
|
HFS_TYPE,
|
|
HFS_CREATOR,
|
|
};
|
|
|
|
static int __hfs_setxattr(struct inode *inode, enum hfs_xattr_type type,
|
|
const void *value, size_t size, int flags)
|
|
{
|
|
struct hfs_find_data fd;
|
|
hfs_cat_rec rec;
|
|
struct hfs_cat_file *file;
|
|
int res;
|
|
|
|
if (!S_ISREG(inode->i_mode) || HFS_IS_RSRC(inode))
|
|
return -EOPNOTSUPP;
|
|
|
|
res = hfs_find_init(HFS_SB(inode->i_sb)->cat_tree, &fd);
|
|
if (res)
|
|
return res;
|
|
fd.search_key->cat = HFS_I(inode)->cat_key;
|
|
res = hfs_brec_find(&fd);
|
|
if (res)
|
|
goto out;
|
|
hfs_bnode_read(fd.bnode, &rec, fd.entryoffset,
|
|
sizeof(struct hfs_cat_file));
|
|
file = &rec.file;
|
|
|
|
switch (type) {
|
|
case HFS_TYPE:
|
|
if (size == 4)
|
|
memcpy(&file->UsrWds.fdType, value, 4);
|
|
else
|
|
res = -ERANGE;
|
|
break;
|
|
|
|
case HFS_CREATOR:
|
|
if (size == 4)
|
|
memcpy(&file->UsrWds.fdCreator, value, 4);
|
|
else
|
|
res = -ERANGE;
|
|
break;
|
|
}
|
|
|
|
if (!res)
|
|
hfs_bnode_write(fd.bnode, &rec, fd.entryoffset,
|
|
sizeof(struct hfs_cat_file));
|
|
out:
|
|
hfs_find_exit(&fd);
|
|
return res;
|
|
}
|
|
|
|
static ssize_t __hfs_getxattr(struct inode *inode, enum hfs_xattr_type type,
|
|
void *value, size_t size)
|
|
{
|
|
struct hfs_find_data fd;
|
|
hfs_cat_rec rec;
|
|
struct hfs_cat_file *file;
|
|
ssize_t res = 0;
|
|
|
|
if (!S_ISREG(inode->i_mode) || HFS_IS_RSRC(inode))
|
|
return -EOPNOTSUPP;
|
|
|
|
if (size) {
|
|
res = hfs_find_init(HFS_SB(inode->i_sb)->cat_tree, &fd);
|
|
if (res)
|
|
return res;
|
|
fd.search_key->cat = HFS_I(inode)->cat_key;
|
|
res = hfs_brec_find(&fd);
|
|
if (res)
|
|
goto out;
|
|
hfs_bnode_read(fd.bnode, &rec, fd.entryoffset,
|
|
sizeof(struct hfs_cat_file));
|
|
}
|
|
file = &rec.file;
|
|
|
|
switch (type) {
|
|
case HFS_TYPE:
|
|
if (size >= 4) {
|
|
memcpy(value, &file->UsrWds.fdType, 4);
|
|
res = 4;
|
|
} else
|
|
res = size ? -ERANGE : 4;
|
|
break;
|
|
|
|
case HFS_CREATOR:
|
|
if (size >= 4) {
|
|
memcpy(value, &file->UsrWds.fdCreator, 4);
|
|
res = 4;
|
|
} else
|
|
res = size ? -ERANGE : 4;
|
|
break;
|
|
}
|
|
|
|
out:
|
|
if (size)
|
|
hfs_find_exit(&fd);
|
|
return res;
|
|
}
|
|
|
|
static int hfs_xattr_get(const struct xattr_handler *handler,
|
|
struct dentry *unused, struct inode *inode,
|
|
const char *name, void *value, size_t size)
|
|
{
|
|
return __hfs_getxattr(inode, handler->flags, value, size);
|
|
}
|
|
|
|
static int hfs_xattr_set(const struct xattr_handler *handler,
|
|
struct user_namespace *mnt_userns,
|
|
struct dentry *unused, struct inode *inode,
|
|
const char *name, const void *value, size_t size,
|
|
int flags)
|
|
{
|
|
if (!value)
|
|
return -EOPNOTSUPP;
|
|
|
|
return __hfs_setxattr(inode, handler->flags, value, size, flags);
|
|
}
|
|
|
|
static const struct xattr_handler hfs_creator_handler = {
|
|
.name = "hfs.creator",
|
|
.flags = HFS_CREATOR,
|
|
.get = hfs_xattr_get,
|
|
.set = hfs_xattr_set,
|
|
};
|
|
|
|
static const struct xattr_handler hfs_type_handler = {
|
|
.name = "hfs.type",
|
|
.flags = HFS_TYPE,
|
|
.get = hfs_xattr_get,
|
|
.set = hfs_xattr_set,
|
|
};
|
|
|
|
const struct xattr_handler *hfs_xattr_handlers[] = {
|
|
&hfs_creator_handler,
|
|
&hfs_type_handler,
|
|
NULL
|
|
};
|