Eric Dumazet 2ed0edf909 tcp: cubic: fix overflow error in bictcp_update() ... commit 17a6e9f1aa ("tcp_cubic: fix clock dependency") added an overflow error in bictcp_update() in following code : /* change the unit from HZ to bictcp_HZ */ t = ((tcp_time_stamp + msecs_to_jiffies(ca->delay_min>>3) - ca->epoch_start) << BICTCP_HZ) / HZ; Because msecs_to_jiffies() being unsigned long, compiler does implicit type promotion. We really want to constrain (tcp_time_stamp - ca->epoch_start) to a signed 32bit value, or else 't' has unexpected high values. This bugs triggers an increase of retransmit rates ~24 days after boot [1], as the high order bit of tcp_time_stamp flips. [1] for hosts with HZ=1000 Big thanks to Van Jacobson for spotting this problem. Diagnosed-by: Van Jacobson <vanj@google.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Neal Cardwell <ncardwell@google.com> Cc: Yuchung Cheng <ycheng@google.com> Cc: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Neal Cardwell <ncardwell@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2013-08-07 10:35:05 -07:00
..
9p	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-07-13 17:42:22 -07:00
802	net/802/mrp: fix lockdep splat	2013-05-14 13:02:30 -07:00
8021q	vlan: make vlan_dev_real_dev work over stacked vlans	2013-08-05 12:17:42 -07:00
appletalk	net: pass info struct via netdevice notifier	2013-05-28 13:11:01 -07:00
atm	net: always pass struct netdev_notifier_info to netdevice notifiers	2013-05-28 21:58:54 -07:00
ax25	net: Convert uses of typedef ctl_table to struct ctl_table	2013-06-13 02:36:09 -07:00
batman-adv	net: Unmap fragment page once iterator is done	2013-06-24 01:46:01 -07:00
bluetooth	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth	2013-07-31 15:11:50 -04:00
bridge	bridge: don't try to update timers in case of broken MLD queries	2013-08-05 15:43:39 -07:00
caif	net: pass info struct via netdevice notifier	2013-05-28 13:11:01 -07:00
can	net: pass info struct via netdevice notifier	2013-05-28 13:11:01 -07:00
ceph	libceph: call r_unsafe_callback when unsafe reply is received	2013-07-03 15:32:58 -07:00
core	neighbour: populate neigh_parms on alloc before calling ndo_neigh_setup	2013-08-05 15:19:04 -07:00
dcb	rtnetlink: Remove passing of attributes into rtnl_doit functions	2013-03-22 10:31:16 -04:00
dccp	tcp: Remove TCPCT	2013-03-17 14:35:13 -04:00
decnet	net: Convert uses of typedef ctl_table to struct ctl_table	2013-06-13 02:36:09 -07:00
dns_resolver	net: strict_strtoul is obsolete, use kstrtoul instead	2013-07-12 16:09:14 -07:00
dsa	dsa: fix freeing of sparse port allocation	2013-03-25 12:23:41 -04:00
ethernet	net: Fix sysfs_format_mac() code duplication.	2013-07-16 17:09:22 -07:00
ieee802154	net: pass info struct via netdevice notifier	2013-05-28 13:11:01 -07:00
ipv4	tcp: cubic: fix overflow error in bictcp_update()	2013-08-07 10:35:05 -07:00
ipv6	net: esp{4,6}: fix potential MTU calculation overflows	2013-08-05 12:26:50 -07:00
ipx	net: pass info struct via netdevice notifier	2013-05-28 13:11:01 -07:00
irda	net/irda: fixed style issues in irlan_eth	2013-07-16 12:16:03 -07:00
iucv	net: delete __cpuinit usage from all net files	2013-07-14 19:36:58 -04:00
key	af_key: more info leaks in pfkey messages	2013-07-30 16:26:16 -07:00
l2tp	l2tp: make datapath resilient to packet loss when sequence numbers enabled	2013-07-02 16:33:25 -07:00
lapb
llc	llc: Fix missing msg_namelen update in llc_ui_recvmsg()	2013-04-07 16:28:01 -04:00
mac80211	mac80211: fix monitor interface suspend crash regression	2013-07-23 14:02:08 +02:00
mac802154	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-04-30 03:55:20 -04:00
mpls	MPLS: Add limited GSO support	2013-05-27 22:50:59 -07:00
netfilter	netfilter: xt_socket: fix broken v0 support	2013-07-15 11:15:21 +02:00
netlabel	netlabel: use domain based selectors when address based selectors are not available	2013-08-02 16:57:01 -07:00
netlink	genetlink: fix usage of NLM_F_EXCL or NLM_F_REPLACE	2013-07-30 16:43:19 -07:00
netrom	net: Convert uses of typedef ctl_table to struct ctl_table	2013-06-13 02:36:09 -07:00
nfc	NFC: netlink: Rename CMD_FW_UPLOAD to CMD_FW_DOWNLOAD	2013-07-31 01:19:43 +02:00
openvswitch	openvswitch: Add Kconfig dependency on GRE-DEMUX.	2013-07-01 13:19:43 -07:00
packet	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-06-19 16:49:39 -07:00
phonet	net: Convert uses of typedef ctl_table to struct ctl_table	2013-06-13 02:36:09 -07:00
rds	net: Convert uses of typedef ctl_table to struct ctl_table	2013-06-13 02:36:09 -07:00
rfkill	Merge branch 'for-john' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next	2013-04-22 14:58:14 -04:00
rose	net: Convert uses of typedef ctl_table to struct ctl_table	2013-06-13 02:36:09 -07:00
rxrpc	Driver core patches for 3.9-rc1	2013-02-21 12:05:51 -08:00
sched	net_sched: make dev_trans_start return vlan's real dev trans_start	2013-08-05 12:17:42 -07:00
sctp	net: sctp: confirm route during forward progress	2013-07-09 12:49:56 -07:00
sunrpc	svcrpc: set cr_gss_mech from gss-proxy as well as legacy upcall	2013-08-01 08:42:01 -04:00
tipc	tipc: fix oops when creating server socket fails	2013-08-01 15:54:33 -07:00
unix	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2013-07-09 18:24:39 -07:00
vmw_vsock	net/vmw_vsock/af_vsock.c: drop unneeded semicolon	2013-08-05 11:07:44 -07:00
wimax
wireless	regulatory: use correct regulatory initiator on wiphy register	2013-07-25 09:52:46 +02:00
x25	x25: Fix broken locking in ioctl error paths.	2013-07-01 18:15:25 -07:00
xfrm	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2013-06-26 13:23:13 -07:00
compat.c	net: Unbreak compat_sys_{send,recv}msg	2013-06-06 11:52:14 -07:00
Kconfig	net: rename CONFIG_NET_LL_RX_POLL to CONFIG_NET_RX_BUSY_POLL	2013-08-01 15:11:17 -07:00
Makefile	MPLS: Add limited GSO support	2013-05-27 22:50:59 -07:00
nonet.c
socket.c	net: rename CONFIG_NET_LL_RX_POLL to CONFIG_NET_RX_BUSY_POLL	2013-08-01 15:11:17 -07:00
sysctl_net.c