linux-stable/drivers/staging
Takashi Iwai 2eed19b99c staging: bcm2835-audio: Fix draining behavior regression
The PCM draining behavior got broken since the recent refactoring, and
this turned out to be the incorrect expectation of the firmware
behavior regarding "draining".  While I expected the "drain" flag at
the stop operation would do processing the queued samples, it seems
rather dropping the samples.

As a quick fix, just drop the SNDRV_PCM_INFO_DRAIN_TRIGGER flag, so
that the driver uses the normal PCM draining procedure.  Also, put
some caution comment to the function for future readers not to fall
into the same pitfall.

Fixes: d7ca3a7154 ("staging: bcm2835-audio: Operate non-atomic PCM ops")
BugLink: https://github.com/raspberrypi/linux/issues/2983
Cc: stable@vger.kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20190914152405.7416-1-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-10-01 08:22:44 +02:00
..
android mm: introduce page_size() 2019-09-24 15:54:08 -07:00
axis-fifo
board
clocking-wizard
comedi staging: comedi: ni_mio_common: Fix a typo in ni_mio_common.c 2019-08-21 05:44:07 -07:00
emxx_udc staging: emxx_udc: remove local TRUE/FALSE definition 2019-09-12 10:35:51 +01:00
exfat staging: exfat: Fix a typo in Kconfig 2019-10-01 08:16:04 +02:00
fbtft staging/fbtft: Remove flexfb 2019-10-01 08:22:44 +02:00
fieldbus dt-bindings: anybus-controller: move to staging/ tree 2019-09-12 10:35:51 +01:00
fsl-dpaa2 staging: fsl-dpaa2/ethsw: do not force user to bring interface down 2019-08-14 16:46:25 +02:00
fwserial
gasket Staging: gasket: Use temporaries to reduce line length. 2019-09-12 10:38:45 +01:00
gdm724x
goldfish staging: Remove dev_err() usage after platform_get_irq() 2019-07-30 20:50:04 +02:00
greybus staging: greybus: light: fix a couple double frees 2019-09-03 09:39:10 +02:00
gs_fpgaboot
iio staging: iio: accel: adis16240: Improve readability on write_raw function 2019-08-18 20:12:52 +01:00
isdn Staging/IIO driver patches for 5.4-rc1 2019-09-18 11:05:34 -07:00
kpc2000 staging: kpc2000: Fix long constant sparse warning 2019-09-03 09:39:48 +02:00
ks7010
media Staging/IIO driver patches for 5.4-rc1 2019-09-18 11:05:34 -07:00
most staging: most: sound: Fix error path of audio_init 2019-08-28 22:22:13 +02:00
mt7621-dma staging: Remove dev_err() usage after platform_get_irq() 2019-07-30 20:50:04 +02:00
mt7621-dts staging: mt7621-dts: add support for second network interface 2019-07-03 18:28:29 +02:00
mt7621-pci staging: mt7621-pci: avoid use 'err' local variable 2019-07-25 09:58:26 +02:00
mt7621-pci-phy
mt7621-pinctrl staging: mt7621-pinctrl: Add of_node_put() before return 2019-07-22 07:34:15 +02:00
netlogic
nvec staging: nvec: make use of devm_platform_ioremap_resource 2019-09-12 10:35:50 +01:00
octeon staging: octeon: Use "(uintptr_t)" to cast from pointer to int 2019-10-01 08:22:43 +02:00
octeon-usb usb: add a HCD_DMA flag instead of guestimating DMA capabilities 2019-08-21 10:03:35 -07:00
olpc_dcon staging: olpc_dcon: Remove TODO item 2019-07-30 09:52:04 +02:00
pi433 staging: pi433: Fix typo in documentation 2019-09-06 18:20:33 +02:00
qlge qlge: Fix build error without CONFIG_ETHERNET 2019-07-24 14:12:40 -07:00
ralink-gdma staging: Remove dev_err() usage after platform_get_irq() 2019-07-30 20:50:04 +02:00
rtl8188eu staging: rtl8188eu: make two arrays static const, makes object smaller 2019-09-12 10:35:52 +01:00
rtl8192e staging: rtl8192e: remove unnecessary blank line 2019-09-05 09:37:31 +02:00
rtl8192u staging: rtl8192u: Fix indentation 2019-08-28 22:22:13 +02:00
rtl8712 staging: rtl8712: wifi: checkpatch style fix 2019-08-27 19:01:26 +02:00
rtl8723bs staging: rtl8723bs: core: Remove Macro "IS_MAC_ADDRESS_BROADCAST" 2019-09-12 10:35:52 +01:00
rts5208 staging: rts5208: Fix checkpath warning 2019-09-03 09:36:29 +02:00
sm750fb staging: sm750fb: fix odd license text 2019-08-15 14:43:57 +02:00
speakup
unisys Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2019-08-19 11:54:03 -07:00
uwb USB: Move wusbcore and UWB to staging as it is obsolete 2019-08-08 07:52:01 +02:00
vc04_services staging: bcm2835-audio: Fix draining behavior regression 2019-10-01 08:22:44 +02:00
vme
vt6655
vt6656 staging: vt6656: change alignment to match parenthesis 2019-07-22 07:34:15 +02:00
wilc1000 staging: wilc1000: avoid twice IRQ handler execution for each single interrupt 2019-09-12 10:37:26 +01:00
wlan-ng staging: wlan-ng: Remove function prism2mib_excludeunencrypted() 2019-08-02 13:55:38 +02:00
wusbcore staging: wusbcore: Fix build error without CONFIG_USB 2019-08-09 14:56:57 +02:00
Kconfig Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next 2019-09-18 12:34:53 -07:00
Makefile Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next 2019-09-18 12:34:53 -07:00