mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
![Lv Zheng](/assets/img/avatar_default.png)
ACPICA doesn't include protections around address space checking, Linux build tests always complain increased sparse warnings around ACPICA internal acpi_os_map/unmap_memory() invocations. This patch tries to fix this issue permanently. There are 2 choices left for us to solve this issue: 1. Add __iomem address space awareness into ACPICA. 2. Remove sparse checker of __iomem from ACPICA source code. This patch chooses solution 2, because: 1. Most of the acpi_os_map/unmap_memory() invocations are used for ACPICA. table mappings, which in fact are not IO addresses. 2. The only IO addresses usage is for "system memory space" mapping code in: drivers/acpi/acpica/exregion.c drivers/acpi/acpica/evrgnini.c drivers/acpi/acpica/exregion.c The mapped address is accessed in the handler of "system memory space" - acpi_ex_system_memory_space_handler(). This function in fact can be changed to invoke acpi_os_read/write_memory() so that __iomem can always be type-casted in the OSL layer. According to the above investigation, we drew the following conclusion: It is not a good idea to introduce __iomem address space awareness into ACPICA mostly in order to protect non-IO addresses. We can simply remove __iomem for acpi_os_map/unmap_memory() to remove __iomem checker for ACPICA code. Then we need to enforce external usages to invoke other APIs that are aware of __iomem address space. The external usages are: drivers/acpi/apei/einj.c drivers/acpi/acpi_extlog.c drivers/char/tpm/tpm_acpi.c drivers/acpi/nvs.c This patch thus performs cleanups in this way: 1. Add acpi_os_map/unmap_iomem() to be invoked by non-ACPICA code. 2. Remove __iomem from acpi_os_map/unmap_memory(). Signed-off-by: Lv Zheng <lv.zheng@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
303 lines
7.9 KiB
C
303 lines
7.9 KiB
C
/*
|
|
* Extended Error Log driver
|
|
*
|
|
* Copyright (C) 2013 Intel Corp.
|
|
* Author: Chen, Gong <gong.chen@intel.com>
|
|
*
|
|
* This file is licensed under GPLv2.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/acpi.h>
|
|
#include <linux/cper.h>
|
|
#include <linux/ratelimit.h>
|
|
#include <linux/edac.h>
|
|
#include <asm/cpu.h>
|
|
#include <asm/mce.h>
|
|
|
|
#include "apei/apei-internal.h"
|
|
|
|
#define EXT_ELOG_ENTRY_MASK GENMASK_ULL(51, 0) /* elog entry address mask */
|
|
|
|
#define EXTLOG_DSM_REV 0x0
|
|
#define EXTLOG_FN_ADDR 0x1
|
|
|
|
#define FLAG_OS_OPTIN BIT(0)
|
|
#define ELOG_ENTRY_VALID (1ULL<<63)
|
|
#define ELOG_ENTRY_LEN 0x1000
|
|
|
|
#define EMCA_BUG \
|
|
"Can not request iomem region <0x%016llx-0x%016llx> - eMCA disabled\n"
|
|
|
|
struct extlog_l1_head {
|
|
u32 ver; /* Header Version */
|
|
u32 hdr_len; /* Header Length */
|
|
u64 total_len; /* entire L1 Directory length including this header */
|
|
u64 elog_base; /* MCA Error Log Directory base address */
|
|
u64 elog_len; /* MCA Error Log Directory length */
|
|
u32 flags; /* bit 0 - OS/VMM Opt-in */
|
|
u8 rev0[12];
|
|
u32 entries; /* Valid L1 Directory entries per logical processor */
|
|
u8 rev1[12];
|
|
};
|
|
|
|
static int old_edac_report_status;
|
|
|
|
static u8 extlog_dsm_uuid[] __initdata = "663E35AF-CC10-41A4-88EA-5470AF055295";
|
|
|
|
/* L1 table related physical address */
|
|
static u64 elog_base;
|
|
static size_t elog_size;
|
|
static u64 l1_dirbase;
|
|
static size_t l1_size;
|
|
|
|
/* L1 table related virtual address */
|
|
static void __iomem *extlog_l1_addr;
|
|
static void __iomem *elog_addr;
|
|
|
|
static void *elog_buf;
|
|
|
|
static u64 *l1_entry_base;
|
|
static u32 l1_percpu_entry;
|
|
|
|
#define ELOG_IDX(cpu, bank) \
|
|
(cpu_physical_id(cpu) * l1_percpu_entry + (bank))
|
|
|
|
#define ELOG_ENTRY_DATA(idx) \
|
|
(*(l1_entry_base + (idx)))
|
|
|
|
#define ELOG_ENTRY_ADDR(phyaddr) \
|
|
(phyaddr - elog_base + (u8 *)elog_addr)
|
|
|
|
static struct acpi_generic_status *extlog_elog_entry_check(int cpu, int bank)
|
|
{
|
|
int idx;
|
|
u64 data;
|
|
struct acpi_generic_status *estatus;
|
|
|
|
WARN_ON(cpu < 0);
|
|
idx = ELOG_IDX(cpu, bank);
|
|
data = ELOG_ENTRY_DATA(idx);
|
|
if ((data & ELOG_ENTRY_VALID) == 0)
|
|
return NULL;
|
|
|
|
data &= EXT_ELOG_ENTRY_MASK;
|
|
estatus = (struct acpi_generic_status *)ELOG_ENTRY_ADDR(data);
|
|
|
|
/* if no valid data in elog entry, just return */
|
|
if (estatus->block_status == 0)
|
|
return NULL;
|
|
|
|
return estatus;
|
|
}
|
|
|
|
static void __print_extlog_rcd(const char *pfx,
|
|
struct acpi_generic_status *estatus, int cpu)
|
|
{
|
|
static atomic_t seqno;
|
|
unsigned int curr_seqno;
|
|
char pfx_seq[64];
|
|
|
|
if (!pfx) {
|
|
if (estatus->error_severity <= CPER_SEV_CORRECTED)
|
|
pfx = KERN_INFO;
|
|
else
|
|
pfx = KERN_ERR;
|
|
}
|
|
curr_seqno = atomic_inc_return(&seqno);
|
|
snprintf(pfx_seq, sizeof(pfx_seq), "%s{%u}", pfx, curr_seqno);
|
|
printk("%s""Hardware error detected on CPU%d\n", pfx_seq, cpu);
|
|
cper_estatus_print(pfx_seq, estatus);
|
|
}
|
|
|
|
static int print_extlog_rcd(const char *pfx,
|
|
struct acpi_generic_status *estatus, int cpu)
|
|
{
|
|
/* Not more than 2 messages every 5 seconds */
|
|
static DEFINE_RATELIMIT_STATE(ratelimit_corrected, 5*HZ, 2);
|
|
static DEFINE_RATELIMIT_STATE(ratelimit_uncorrected, 5*HZ, 2);
|
|
struct ratelimit_state *ratelimit;
|
|
|
|
if (estatus->error_severity == CPER_SEV_CORRECTED ||
|
|
(estatus->error_severity == CPER_SEV_INFORMATIONAL))
|
|
ratelimit = &ratelimit_corrected;
|
|
else
|
|
ratelimit = &ratelimit_uncorrected;
|
|
if (__ratelimit(ratelimit)) {
|
|
__print_extlog_rcd(pfx, estatus, cpu);
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int extlog_print(struct notifier_block *nb, unsigned long val,
|
|
void *data)
|
|
{
|
|
struct mce *mce = (struct mce *)data;
|
|
int bank = mce->bank;
|
|
int cpu = mce->extcpu;
|
|
struct acpi_generic_status *estatus;
|
|
int rc;
|
|
|
|
estatus = extlog_elog_entry_check(cpu, bank);
|
|
if (estatus == NULL)
|
|
return NOTIFY_DONE;
|
|
|
|
memcpy(elog_buf, (void *)estatus, ELOG_ENTRY_LEN);
|
|
/* clear record status to enable BIOS to update it again */
|
|
estatus->block_status = 0;
|
|
|
|
rc = print_extlog_rcd(NULL, (struct acpi_generic_status *)elog_buf, cpu);
|
|
|
|
return NOTIFY_STOP;
|
|
}
|
|
|
|
static bool __init extlog_get_l1addr(void)
|
|
{
|
|
u8 uuid[16];
|
|
acpi_handle handle;
|
|
union acpi_object *obj;
|
|
|
|
acpi_str_to_uuid(extlog_dsm_uuid, uuid);
|
|
|
|
if (ACPI_FAILURE(acpi_get_handle(NULL, "\\_SB", &handle)))
|
|
return false;
|
|
if (!acpi_check_dsm(handle, uuid, EXTLOG_DSM_REV, 1 << EXTLOG_FN_ADDR))
|
|
return false;
|
|
obj = acpi_evaluate_dsm_typed(handle, uuid, EXTLOG_DSM_REV,
|
|
EXTLOG_FN_ADDR, NULL, ACPI_TYPE_INTEGER);
|
|
if (!obj) {
|
|
return false;
|
|
} else {
|
|
l1_dirbase = obj->integer.value;
|
|
ACPI_FREE(obj);
|
|
}
|
|
|
|
/* Spec says L1 directory must be 4K aligned, bail out if it isn't */
|
|
if (l1_dirbase & ((1 << 12) - 1)) {
|
|
pr_warn(FW_BUG "L1 Directory is invalid at physical %llx\n",
|
|
l1_dirbase);
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
static struct notifier_block extlog_mce_dec = {
|
|
.notifier_call = extlog_print,
|
|
};
|
|
|
|
static int __init extlog_init(void)
|
|
{
|
|
struct extlog_l1_head *l1_head;
|
|
void __iomem *extlog_l1_hdr;
|
|
size_t l1_hdr_size;
|
|
struct resource *r;
|
|
u64 cap;
|
|
int rc;
|
|
|
|
if (get_edac_report_status() == EDAC_REPORTING_FORCE) {
|
|
pr_warn("Not loading eMCA, error reporting force-enabled through EDAC.\n");
|
|
return -EPERM;
|
|
}
|
|
|
|
rc = -ENODEV;
|
|
rdmsrl(MSR_IA32_MCG_CAP, cap);
|
|
if (!(cap & MCG_ELOG_P))
|
|
return rc;
|
|
|
|
if (!extlog_get_l1addr())
|
|
return rc;
|
|
|
|
rc = -EINVAL;
|
|
/* get L1 header to fetch necessary information */
|
|
l1_hdr_size = sizeof(struct extlog_l1_head);
|
|
r = request_mem_region(l1_dirbase, l1_hdr_size, "L1 DIR HDR");
|
|
if (!r) {
|
|
pr_warn(FW_BUG EMCA_BUG,
|
|
(unsigned long long)l1_dirbase,
|
|
(unsigned long long)l1_dirbase + l1_hdr_size);
|
|
goto err;
|
|
}
|
|
|
|
extlog_l1_hdr = acpi_os_map_iomem(l1_dirbase, l1_hdr_size);
|
|
l1_head = (struct extlog_l1_head *)extlog_l1_hdr;
|
|
l1_size = l1_head->total_len;
|
|
l1_percpu_entry = l1_head->entries;
|
|
elog_base = l1_head->elog_base;
|
|
elog_size = l1_head->elog_len;
|
|
acpi_os_unmap_iomem(extlog_l1_hdr, l1_hdr_size);
|
|
release_mem_region(l1_dirbase, l1_hdr_size);
|
|
|
|
/* remap L1 header again based on completed information */
|
|
r = request_mem_region(l1_dirbase, l1_size, "L1 Table");
|
|
if (!r) {
|
|
pr_warn(FW_BUG EMCA_BUG,
|
|
(unsigned long long)l1_dirbase,
|
|
(unsigned long long)l1_dirbase + l1_size);
|
|
goto err;
|
|
}
|
|
extlog_l1_addr = acpi_os_map_iomem(l1_dirbase, l1_size);
|
|
l1_entry_base = (u64 *)((u8 *)extlog_l1_addr + l1_hdr_size);
|
|
|
|
/* remap elog table */
|
|
r = request_mem_region(elog_base, elog_size, "Elog Table");
|
|
if (!r) {
|
|
pr_warn(FW_BUG EMCA_BUG,
|
|
(unsigned long long)elog_base,
|
|
(unsigned long long)elog_base + elog_size);
|
|
goto err_release_l1_dir;
|
|
}
|
|
elog_addr = acpi_os_map_iomem(elog_base, elog_size);
|
|
|
|
rc = -ENOMEM;
|
|
/* allocate buffer to save elog record */
|
|
elog_buf = kmalloc(ELOG_ENTRY_LEN, GFP_KERNEL);
|
|
if (elog_buf == NULL)
|
|
goto err_release_elog;
|
|
|
|
/*
|
|
* eMCA event report method has higher priority than EDAC method,
|
|
* unless EDAC event report method is mandatory.
|
|
*/
|
|
old_edac_report_status = get_edac_report_status();
|
|
set_edac_report_status(EDAC_REPORTING_DISABLED);
|
|
mce_register_decode_chain(&extlog_mce_dec);
|
|
/* enable OS to be involved to take over management from BIOS */
|
|
((struct extlog_l1_head *)extlog_l1_addr)->flags |= FLAG_OS_OPTIN;
|
|
|
|
return 0;
|
|
|
|
err_release_elog:
|
|
if (elog_addr)
|
|
acpi_os_unmap_iomem(elog_addr, elog_size);
|
|
release_mem_region(elog_base, elog_size);
|
|
err_release_l1_dir:
|
|
if (extlog_l1_addr)
|
|
acpi_os_unmap_iomem(extlog_l1_addr, l1_size);
|
|
release_mem_region(l1_dirbase, l1_size);
|
|
err:
|
|
pr_warn(FW_BUG "Extended error log disabled because of problems parsing f/w tables\n");
|
|
return rc;
|
|
}
|
|
|
|
static void __exit extlog_exit(void)
|
|
{
|
|
set_edac_report_status(old_edac_report_status);
|
|
mce_unregister_decode_chain(&extlog_mce_dec);
|
|
((struct extlog_l1_head *)extlog_l1_addr)->flags &= ~FLAG_OS_OPTIN;
|
|
if (extlog_l1_addr)
|
|
acpi_os_unmap_iomem(extlog_l1_addr, l1_size);
|
|
if (elog_addr)
|
|
acpi_os_unmap_iomem(elog_addr, elog_size);
|
|
release_mem_region(elog_base, elog_size);
|
|
release_mem_region(l1_dirbase, l1_size);
|
|
kfree(elog_buf);
|
|
}
|
|
|
|
module_init(extlog_init);
|
|
module_exit(extlog_exit);
|
|
|
|
MODULE_AUTHOR("Chen, Gong <gong.chen@intel.com>");
|
|
MODULE_DESCRIPTION("Extended MCA Error Log Driver");
|
|
MODULE_LICENSE("GPL");
|