Vasily Averin 05aae468d3 ipc/util.c: sysvipc_find_ipc() incorrectly updates position index ... [ Upstream commit 5e698222c7 ] Commit 89163f93c6 ("ipc/util.c: sysvipc_find_ipc() should increase position index") is causing this bug (seen on 5.6.8): # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages # ipcmk -Q Message queue id: 0 # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages 0x82db8127 0 root 644 0 0 # ipcmk -Q Message queue id: 1 # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages 0x82db8127 0 root 644 0 0 0x76d1fb2a 1 root 644 0 0 # ipcrm -q 0 # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages 0x76d1fb2a 1 root 644 0 0 0x76d1fb2a 1 root 644 0 0 # ipcmk -Q Message queue id: 2 # ipcrm -q 2 # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages 0x76d1fb2a 1 root 644 0 0 0x76d1fb2a 1 root 644 0 0 # ipcmk -Q Message queue id: 3 # ipcrm -q 1 # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages 0x7c982867 3 root 644 0 0 0x7c982867 3 root 644 0 0 0x7c982867 3 root 644 0 0 0x7c982867 3 root 644 0 0 Whenever an IPC item with a low id is deleted, the items with higher ids are duplicated, as if filling a hole. new_pos should jump through hole of unused ids, pos can be updated inside "for" cycle. Fixes: 89163f93c6 ("ipc/util.c: sysvipc_find_ipc() should increase position index") Reported-by: Andreas Schwab <schwab@suse.de> Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: Waiman Long <longman@redhat.com> Cc: NeilBrown <neilb@suse.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Peter Oberparleiter <oberpar@linux.ibm.com> Cc: Davidlohr Bueso <dave@stgolabs.net> Cc: Manfred Spraul <manfred@colorfullife.com> Cc: <stable@vger.kernel.org> Link: http://lkml.kernel.org/r/4921fe9b-9385-a2b4-1dc4-1099be6d2e39@virtuozzo.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-05-20 08:20:16 +02:00
..
compat.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ipc_sysctl.c	proc/sysctl: add shared variables for range check	2019-07-18 17:08:07 -07:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mq_sysctl.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
mqueue.c	ipc/mqueue.c: change __do_notify() to bypass check_kill_permission()	2020-05-14 07:58:26 +02:00
msg.c	ipc/msg.c: consolidate all xxxctl_down() functions	2020-02-11 04:35:07 -08:00
msgutil.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 52	2019-05-24 17:36:42 +02:00
namespace.c	ipc: Convert mqueue fs to fs_context	2019-02-28 03:29:29 -05:00
sem.c	Revert "ipc,sem: remove uneeded sem_undo_list lock usage in exit_sem()"	2020-02-28 17:22:20 +01:00
shm.c	ipc: rename old-style shmctl/semctl/msgctl syscalls	2019-01-25 17:22:50 +01:00
syscall.c	ipc: rename old-style shmctl/semctl/msgctl syscalls	2019-01-25 17:22:50 +01:00
util.c	ipc/util.c: sysvipc_find_ipc() incorrectly updates position index	2020-05-20 08:20:16 +02:00
util.h	ipc: fix sparc64 ipc() wrapper	2019-09-07 21:42:25 +02:00