Kwangjin Ko 9bd1891cac cxl/core: Fix initialization of mbox_cmd.size_out in get event ... [ Upstream commit f7c52345cc ] Since mbox_cmd.size_out is overwritten with the actual output size in the function below, it needs to be initialized every time. cxl_internal_send_cmd -> __cxl_pci_mbox_send_cmd Problem scenario: 1) The size_out variable is initially set to the size of the mailbox. 2) Read an event. - size_out is set to 160 bytes(header 32B + one event 128B). - Two event are created while reading. 3) Read the new *two* events. - size_out is still set to 160 bytes. - Although the value of out_len is 288 bytes, only 160 bytes are copied from the mailbox register to the local variable. - record_count is set to 2. - Accessing records[1] will result in reading incorrect data. Fixes: 6ebe28f9ec ("cxl/mem: Read, trace, and clear events on driver load") Tested-by: Ira Weiny <ira.weiny@intel.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Kwangjin Ko <kwangjin.ko@sk.com> Signed-off-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-04-17 11:19:27 +02:00
..
core	cxl/core: Fix initialization of mbox_cmd.size_out in get event	2024-04-17 11:19:27 +02:00
Kconfig	cxl: fix CONFIG_FW_LOADER dependency	2023-07-14 14:32:22 -06:00
Makefile	cxl/pmem: Introduce nvdimm_security_ops with ->get_flags() operation	2022-11-30 16:30:47 -08:00
acpi.c	cxl/acpi: Fix load failures due to single window creation failure	2024-03-01 13:34:59 +01:00
cxl.h	cxl/port: Fix missing target list lock	2024-01-25 15:35:55 -08:00
cxlmem.h	cxl/memdev: Fix sanitize vs decoder setup locking	2023-11-20 11:59:30 +01:00
cxlpci.h	cxl/pci: Find and register CXL PMU devices	2023-05-30 11:20:35 -07:00
mem.c	Merge branch 'for-6.5/cxl-rch-eh' into for-6.5/cxl	2023-06-25 18:56:13 -07:00
pci.c	cxl/core/regs: Rename @dev to @host in struct cxl_register_map	2023-11-20 11:59:31 +01:00
pmem.c	cxl/mbox: Move mailbox related driver state to its own data structure	2023-06-25 14:31:08 -07:00
pmu.h	cxl/pci: Find and register CXL PMU devices	2023-05-30 11:20:35 -07:00
port.c	Merge branch 'for-6.5/cxl-rch-eh' into for-6.5/cxl	2023-06-25 18:56:13 -07:00
security.c	Merge branch 'for-6.5/cxl-type-2' into for-6.5/cxl	2023-06-25 17:16:51 -07:00