linux-stable/net/batman-adv
Sven Eckelmann ff90a4c6ed batman-adv: Hold rtnl lock during MTU update via netlink
commit 987aae75fc upstream.

The automatic recalculation of the maximum allowed MTU is usually triggered
by code sections which are already rtnl lock protected by callers outside
of batman-adv. But when the fragmentation setting is changed via
batman-adv's own batadv genl family, then the rtnl lock is not yet taken.

But dev_set_mtu requires that the caller holds the rtnl lock because it
uses netdevice notifiers. And this code will then fail the check for this
lock:

  RTNL: assertion failed at net/core/dev.c (1953)

Cc: stable@vger.kernel.org
Reported-by: syzbot+f8812454d9b3ac00d282@syzkaller.appspotmail.com
Fixes: c6a953cce8 ("batman-adv: Trigger events for auto adjusted MTU")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20230821-batadv-missing-mtu-rtnl-lock-v1-1-1c5a7bfe861e@narfation.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-08-30 16:18:18 +02:00
..
bat_algo.c
bat_algo.h
bat_iv_ogm.c
bat_iv_ogm.h
bat_v.c
bat_v.h
bat_v_elp.c batman-adv: Do not get eth header before batadv_check_management_packet 2023-08-30 16:18:17 +02:00
bat_v_elp.h
bat_v_ogm.c batman-adv: Fix batadv_v_ogm_aggr_send memory leak 2023-08-30 16:18:17 +02:00
bat_v_ogm.h
bitarray.c
bitarray.h
bridge_loop_avoidance.c batman-adv: Use netif_rx_any_context() any. 2022-07-29 17:25:07 +02:00
bridge_loop_avoidance.h
distributed-arp-table.c batman-adv: Broken sync while rescheduling delayed work 2023-06-14 11:13:04 +02:00
distributed-arp-table.h
fragmentation.c batman-adv: Don't skb_split skbuffs with frag_list 2022-05-18 10:26:47 +02:00
fragmentation.h
gateway_client.c
gateway_client.h
gateway_common.c
gateway_common.h
hard-interface.c batman-adv: Don't increase MTU when set by user 2023-08-30 16:18:17 +02:00
hard-interface.h
hash.c
hash.h
Kconfig
log.c
log.h
main.c net: batman-adv: fix error handling 2021-10-26 14:47:12 +01:00
main.h
Makefile
multicast.c ipv6: make mc_forwarding atomic 2022-04-13 20:59:03 +02:00
multicast.h batman-adv: mcast: don't send link-local multicast to mcast routers 2022-01-11 15:35:14 +01:00
netlink.c batman-adv: Hold rtnl lock during MTU update via netlink 2023-08-30 16:18:18 +02:00
netlink.h
network-coding.c net: batman-adv: fix error handling 2021-10-26 14:47:12 +01:00
network-coding.h
originator.c
originator.h
routing.c
routing.h
send.c
send.h
soft-interface.c batman-adv: Don't increase MTU when set by user 2023-08-30 16:18:17 +02:00
soft-interface.h
tp_meter.c
tp_meter.h
trace.c
trace.h
translation-table.c batman-adv: Fix TT global entry leak when client roamed back 2023-08-30 16:18:17 +02:00
translation-table.h
tvlv.c
tvlv.h
types.h batman-adv: Don't increase MTU when set by user 2023-08-30 16:18:17 +02:00