mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
409c69be43
The driver was checking for non-NULL address of struct's members: - s3c_audio_pdata->type (union), - s3c_audio_pdata->type.i2s (embedded struct). This is pointless as these will be always non-NULL. The 's3c_audio_pdata' is always initialized in static memory so it will be zeroed. Additionally the 'type' member was an union with only one member. It is safe to reorganize the structures to get rid of useless union and checks for addresses to fix the coccinelle warning: >> sound/soc/samsung/i2s.c:1270:2-4: ERROR: test of a variable/field address Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Mark Brown <broonie@kernel.org>
51 lines
1.5 KiB
C
51 lines
1.5 KiB
C
/*
|
|
* Copyright (c) 2009 Samsung Electronics Co. Ltd
|
|
* Author: Jaswinder Singh <jassi.brar@samsung.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
/* The machine init code calls s3c*_ac97_setup_gpio with
|
|
* one of these defines in order to select appropriate bank
|
|
* of GPIO for AC97 pins
|
|
*/
|
|
#define S3C64XX_AC97_GPD 0
|
|
#define S3C64XX_AC97_GPE 1
|
|
|
|
#include <linux/dmaengine.h>
|
|
|
|
extern void s3c64xx_ac97_setup_gpio(int);
|
|
|
|
struct samsung_i2s_type {
|
|
/* If the Primary DAI has 5.1 Channels */
|
|
#define QUIRK_PRI_6CHAN (1 << 0)
|
|
/* If the I2S block has a Stereo Overlay Channel */
|
|
#define QUIRK_SEC_DAI (1 << 1)
|
|
/*
|
|
* If the I2S block has no internal prescalar or MUX (I2SMOD[10] bit)
|
|
* The Machine driver must provide suitably set clock to the I2S block.
|
|
*/
|
|
#define QUIRK_NO_MUXPSR (1 << 2)
|
|
#define QUIRK_NEED_RSTCLR (1 << 3)
|
|
#define QUIRK_SUPPORTS_TDM (1 << 4)
|
|
#define QUIRK_SUPPORTS_IDMA (1 << 5)
|
|
/* Quirks of the I2S controller */
|
|
u32 quirks;
|
|
dma_addr_t idma_addr;
|
|
};
|
|
|
|
/**
|
|
* struct s3c_audio_pdata - common platform data for audio device drivers
|
|
* @cfg_gpio: Callback function to setup mux'ed pins in I2S/PCM/AC97 mode
|
|
*/
|
|
struct s3c_audio_pdata {
|
|
int (*cfg_gpio)(struct platform_device *);
|
|
dma_filter_fn dma_filter;
|
|
void *dma_playback;
|
|
void *dma_capture;
|
|
void *dma_play_sec;
|
|
void *dma_capture_mic;
|
|
struct samsung_i2s_type type;
|
|
};
|