mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
![Kees Cook](/assets/img/avatar_default.png)
The kzalloc() function has a 2-factor argument form, kcalloc(). This patch replaces cases of: kzalloc(a * b, gfp) with: kcalloc(a * b, gfp) as well as handling cases of: kzalloc(a * b * c, gfp) with: kzalloc(array3_size(a, b, c), gfp) as it's slightly less ugly than: kzalloc_array(array_size(a, b), c, gfp) This does, however, attempt to ignore constant size factors like: kzalloc(4 * 1024, gfp) though any constants defined via macros get caught up in the conversion. Any factors with a sizeof() of "unsigned char", "char", and "u8" were dropped, since they're redundant. The Coccinelle script used for this was: // Fix redundant parens around sizeof(). @@ type TYPE; expression THING, E; @@ ( kzalloc( - (sizeof(TYPE)) * E + sizeof(TYPE) * E , ...) | kzalloc( - (sizeof(THING)) * E + sizeof(THING) * E , ...) ) // Drop single-byte sizes and redundant parens. @@ expression COUNT; typedef u8; typedef __u8; @@ ( kzalloc( - sizeof(u8) * (COUNT) + COUNT , ...) | kzalloc( - sizeof(__u8) * (COUNT) + COUNT , ...) | kzalloc( - sizeof(char) * (COUNT) + COUNT , ...) | kzalloc( - sizeof(unsigned char) * (COUNT) + COUNT , ...) | kzalloc( - sizeof(u8) * COUNT + COUNT , ...) | kzalloc( - sizeof(__u8) * COUNT + COUNT , ...) | kzalloc( - sizeof(char) * COUNT + COUNT , ...) | kzalloc( - sizeof(unsigned char) * COUNT + COUNT , ...) ) // 2-factor product with sizeof(type/expression) and identifier or constant. @@ type TYPE; expression THING; identifier COUNT_ID; constant COUNT_CONST; @@ ( - kzalloc + kcalloc ( - sizeof(TYPE) * (COUNT_ID) + COUNT_ID, sizeof(TYPE) , ...) | - kzalloc + kcalloc ( - sizeof(TYPE) * COUNT_ID + COUNT_ID, sizeof(TYPE) , ...) | - kzalloc + kcalloc ( - sizeof(TYPE) * (COUNT_CONST) + COUNT_CONST, sizeof(TYPE) , ...) | - kzalloc + kcalloc ( - sizeof(TYPE) * COUNT_CONST + COUNT_CONST, sizeof(TYPE) , ...) | - kzalloc + kcalloc ( - sizeof(THING) * (COUNT_ID) + COUNT_ID, sizeof(THING) , ...) | - kzalloc + kcalloc ( - sizeof(THING) * COUNT_ID + COUNT_ID, sizeof(THING) , ...) | - kzalloc + kcalloc ( - sizeof(THING) * (COUNT_CONST) + COUNT_CONST, sizeof(THING) , ...) | - kzalloc + kcalloc ( - sizeof(THING) * COUNT_CONST + COUNT_CONST, sizeof(THING) , ...) ) // 2-factor product, only identifiers. @@ identifier SIZE, COUNT; @@ - kzalloc + kcalloc ( - SIZE * COUNT + COUNT, SIZE , ...) // 3-factor product with 1 sizeof(type) or sizeof(expression), with // redundant parens removed. @@ expression THING; identifier STRIDE, COUNT; type TYPE; @@ ( kzalloc( - sizeof(TYPE) * (COUNT) * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | kzalloc( - sizeof(TYPE) * (COUNT) * STRIDE + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | kzalloc( - sizeof(TYPE) * COUNT * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | kzalloc( - sizeof(TYPE) * COUNT * STRIDE + array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...) | kzalloc( - sizeof(THING) * (COUNT) * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | kzalloc( - sizeof(THING) * (COUNT) * STRIDE + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | kzalloc( - sizeof(THING) * COUNT * (STRIDE) + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) | kzalloc( - sizeof(THING) * COUNT * STRIDE + array3_size(COUNT, STRIDE, sizeof(THING)) , ...) ) // 3-factor product with 2 sizeof(variable), with redundant parens removed. @@ expression THING1, THING2; identifier COUNT; type TYPE1, TYPE2; @@ ( kzalloc( - sizeof(TYPE1) * sizeof(TYPE2) * COUNT + array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2)) , ...) | kzalloc( - sizeof(TYPE1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2)) , ...) | kzalloc( - sizeof(THING1) * sizeof(THING2) * COUNT + array3_size(COUNT, sizeof(THING1), sizeof(THING2)) , ...) | kzalloc( - sizeof(THING1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(THING1), sizeof(THING2)) , ...) | kzalloc( - sizeof(TYPE1) * sizeof(THING2) * COUNT + array3_size(COUNT, sizeof(TYPE1), sizeof(THING2)) , ...) | kzalloc( - sizeof(TYPE1) * sizeof(THING2) * (COUNT) + array3_size(COUNT, sizeof(TYPE1), sizeof(THING2)) , ...) ) // 3-factor product, only identifiers, with redundant parens removed. @@ identifier STRIDE, SIZE, COUNT; @@ ( kzalloc( - (COUNT) * STRIDE * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | kzalloc( - COUNT * (STRIDE) * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | kzalloc( - COUNT * STRIDE * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | kzalloc( - (COUNT) * (STRIDE) * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) | kzalloc( - COUNT * (STRIDE) * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | kzalloc( - (COUNT) * STRIDE * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | kzalloc( - (COUNT) * (STRIDE) * (SIZE) + array3_size(COUNT, STRIDE, SIZE) , ...) | kzalloc( - COUNT * STRIDE * SIZE + array3_size(COUNT, STRIDE, SIZE) , ...) ) // Any remaining multi-factor products, first at least 3-factor products, // when they're not all constants... @@ expression E1, E2, E3; constant C1, C2, C3; @@ ( kzalloc(C1 * C2 * C3, ...) | kzalloc( - (E1) * E2 * E3 + array3_size(E1, E2, E3) , ...) | kzalloc( - (E1) * (E2) * E3 + array3_size(E1, E2, E3) , ...) | kzalloc( - (E1) * (E2) * (E3) + array3_size(E1, E2, E3) , ...) | kzalloc( - E1 * E2 * E3 + array3_size(E1, E2, E3) , ...) ) // And then all remaining 2 factors products when they're not all constants, // keeping sizeof() as the second factor argument. @@ expression THING, E1, E2; type TYPE; constant C1, C2, C3; @@ ( kzalloc(sizeof(THING) * C2, ...) | kzalloc(sizeof(TYPE) * C2, ...) | kzalloc(C1 * C2 * C3, ...) | kzalloc(C1 * C2, ...) | - kzalloc + kcalloc ( - sizeof(TYPE) * (E2) + E2, sizeof(TYPE) , ...) | - kzalloc + kcalloc ( - sizeof(TYPE) * E2 + E2, sizeof(TYPE) , ...) | - kzalloc + kcalloc ( - sizeof(THING) * (E2) + E2, sizeof(THING) , ...) | - kzalloc + kcalloc ( - sizeof(THING) * E2 + E2, sizeof(THING) , ...) | - kzalloc + kcalloc ( - (E1) * E2 + E1, E2 , ...) | - kzalloc + kcalloc ( - (E1) * (E2) + E1, E2 , ...) | - kzalloc + kcalloc ( - E1 * E2 + E1, E2 , ...) ) Signed-off-by: Kees Cook <keescook@chromium.org>
143 lines
3.9 KiB
C
143 lines
3.9 KiB
C
/*
|
|
* Copyright © 2007 Eugene Konev <ejka@openwrt.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*
|
|
* TI AR7 flash partition table.
|
|
* Based on ar7 map by Felix Fietkau <nbd@openwrt.org>
|
|
*
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/mtd/mtd.h>
|
|
#include <linux/mtd/partitions.h>
|
|
#include <linux/bootmem.h>
|
|
#include <linux/module.h>
|
|
|
|
#include <uapi/linux/magic.h>
|
|
|
|
#define AR7_PARTS 4
|
|
#define ROOT_OFFSET 0xe0000
|
|
|
|
#define LOADER_MAGIC1 le32_to_cpu(0xfeedfa42)
|
|
#define LOADER_MAGIC2 le32_to_cpu(0xfeed1281)
|
|
|
|
struct ar7_bin_rec {
|
|
unsigned int checksum;
|
|
unsigned int length;
|
|
unsigned int address;
|
|
};
|
|
|
|
static int create_mtd_partitions(struct mtd_info *master,
|
|
const struct mtd_partition **pparts,
|
|
struct mtd_part_parser_data *data)
|
|
{
|
|
struct ar7_bin_rec header;
|
|
unsigned int offset;
|
|
size_t len;
|
|
unsigned int pre_size = master->erasesize, post_size = 0;
|
|
unsigned int root_offset = ROOT_OFFSET;
|
|
|
|
int retries = 10;
|
|
struct mtd_partition *ar7_parts;
|
|
|
|
ar7_parts = kcalloc(AR7_PARTS, sizeof(*ar7_parts), GFP_KERNEL);
|
|
if (!ar7_parts)
|
|
return -ENOMEM;
|
|
ar7_parts[0].name = "loader";
|
|
ar7_parts[0].offset = 0;
|
|
ar7_parts[0].size = master->erasesize;
|
|
ar7_parts[0].mask_flags = MTD_WRITEABLE;
|
|
|
|
ar7_parts[1].name = "config";
|
|
ar7_parts[1].offset = 0;
|
|
ar7_parts[1].size = master->erasesize;
|
|
ar7_parts[1].mask_flags = 0;
|
|
|
|
do { /* Try 10 blocks starting from master->erasesize */
|
|
offset = pre_size;
|
|
mtd_read(master, offset, sizeof(header), &len,
|
|
(uint8_t *)&header);
|
|
if (!strncmp((char *)&header, "TIENV0.8", 8))
|
|
ar7_parts[1].offset = pre_size;
|
|
if (header.checksum == LOADER_MAGIC1)
|
|
break;
|
|
if (header.checksum == LOADER_MAGIC2)
|
|
break;
|
|
pre_size += master->erasesize;
|
|
} while (retries--);
|
|
|
|
pre_size = offset;
|
|
|
|
if (!ar7_parts[1].offset) {
|
|
ar7_parts[1].offset = master->size - master->erasesize;
|
|
post_size = master->erasesize;
|
|
}
|
|
|
|
switch (header.checksum) {
|
|
case LOADER_MAGIC1:
|
|
while (header.length) {
|
|
offset += sizeof(header) + header.length;
|
|
mtd_read(master, offset, sizeof(header), &len,
|
|
(uint8_t *)&header);
|
|
}
|
|
root_offset = offset + sizeof(header) + 4;
|
|
break;
|
|
case LOADER_MAGIC2:
|
|
while (header.length) {
|
|
offset += sizeof(header) + header.length;
|
|
mtd_read(master, offset, sizeof(header), &len,
|
|
(uint8_t *)&header);
|
|
}
|
|
root_offset = offset + sizeof(header) + 4 + 0xff;
|
|
root_offset &= ~(uint32_t)0xff;
|
|
break;
|
|
default:
|
|
printk(KERN_WARNING "Unknown magic: %08x\n", header.checksum);
|
|
break;
|
|
}
|
|
|
|
mtd_read(master, root_offset, sizeof(header), &len, (u8 *)&header);
|
|
if (header.checksum != SQUASHFS_MAGIC) {
|
|
root_offset += master->erasesize - 1;
|
|
root_offset &= ~(master->erasesize - 1);
|
|
}
|
|
|
|
ar7_parts[2].name = "linux";
|
|
ar7_parts[2].offset = pre_size;
|
|
ar7_parts[2].size = master->size - pre_size - post_size;
|
|
ar7_parts[2].mask_flags = 0;
|
|
|
|
ar7_parts[3].name = "rootfs";
|
|
ar7_parts[3].offset = root_offset;
|
|
ar7_parts[3].size = master->size - root_offset - post_size;
|
|
ar7_parts[3].mask_flags = 0;
|
|
|
|
*pparts = ar7_parts;
|
|
return AR7_PARTS;
|
|
}
|
|
|
|
static struct mtd_part_parser ar7_parser = {
|
|
.parse_fn = create_mtd_partitions,
|
|
.name = "ar7part",
|
|
};
|
|
module_mtd_part_parser(ar7_parser);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR( "Felix Fietkau <nbd@openwrt.org>, "
|
|
"Eugene Konev <ejka@openwrt.org>");
|
|
MODULE_DESCRIPTION("MTD partitioning for TI AR7");
|