mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
![Steven Whitehouse](/assets/img/avatar_default.png)
Due to the design of the VFS, it is quite usual for operations on GFS2 to consist of a lookup (requiring a shared lock) followed by an operation requiring an exclusive lock. If a remote node has cached an exclusive lock, then it will receive two demote events in rapid succession firstly for a shared lock and then to unlocked. The existing min hold time code was triggering in this case, even if the node was otherwise idle since the state change time was being updated by the initial demote. This patch introduces logic to skip the min hold timer in the case that a "double demote" of this kind has occurred. The min hold timer will still be used in all other cases. A new glock flag is introduced which is used to keep track of whether there have been any newly queued holders since the last glock state change. The min hold time is only applied if the flag is set. Signed-off-by: Steven Whitehouse <swhiteho@redhat.com> Tested-by: Abhijith Das <adas@redhat.com>
408 lines
11 KiB
C
408 lines
11 KiB
C
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM gfs2
|
|
|
|
#if !defined(_TRACE_GFS2_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_GFS2_H
|
|
|
|
#include <linux/tracepoint.h>
|
|
|
|
#include <linux/fs.h>
|
|
#include <linux/buffer_head.h>
|
|
#include <linux/dlmconstants.h>
|
|
#include <linux/gfs2_ondisk.h>
|
|
#include "incore.h"
|
|
#include "glock.h"
|
|
|
|
#define dlm_state_name(nn) { DLM_LOCK_##nn, #nn }
|
|
#define glock_trace_name(x) __print_symbolic(x, \
|
|
dlm_state_name(IV), \
|
|
dlm_state_name(NL), \
|
|
dlm_state_name(CR), \
|
|
dlm_state_name(CW), \
|
|
dlm_state_name(PR), \
|
|
dlm_state_name(PW), \
|
|
dlm_state_name(EX))
|
|
|
|
#define block_state_name(x) __print_symbolic(x, \
|
|
{ GFS2_BLKST_FREE, "free" }, \
|
|
{ GFS2_BLKST_USED, "used" }, \
|
|
{ GFS2_BLKST_DINODE, "dinode" }, \
|
|
{ GFS2_BLKST_UNLINKED, "unlinked" })
|
|
|
|
#define show_glock_flags(flags) __print_flags(flags, "", \
|
|
{(1UL << GLF_LOCK), "l" }, \
|
|
{(1UL << GLF_DEMOTE), "D" }, \
|
|
{(1UL << GLF_PENDING_DEMOTE), "d" }, \
|
|
{(1UL << GLF_DEMOTE_IN_PROGRESS), "p" }, \
|
|
{(1UL << GLF_DIRTY), "y" }, \
|
|
{(1UL << GLF_LFLUSH), "f" }, \
|
|
{(1UL << GLF_INVALIDATE_IN_PROGRESS), "i" }, \
|
|
{(1UL << GLF_REPLY_PENDING), "r" }, \
|
|
{(1UL << GLF_INITIAL), "I" }, \
|
|
{(1UL << GLF_FROZEN), "F" }, \
|
|
{(1UL << GLF_QUEUED), "q" })
|
|
|
|
#ifndef NUMPTY
|
|
#define NUMPTY
|
|
static inline u8 glock_trace_state(unsigned int state)
|
|
{
|
|
switch(state) {
|
|
case LM_ST_SHARED:
|
|
return DLM_LOCK_PR;
|
|
case LM_ST_DEFERRED:
|
|
return DLM_LOCK_CW;
|
|
case LM_ST_EXCLUSIVE:
|
|
return DLM_LOCK_EX;
|
|
}
|
|
return DLM_LOCK_NL;
|
|
}
|
|
#endif
|
|
|
|
/* Section 1 - Locking
|
|
*
|
|
* Objectives:
|
|
* Latency: Remote demote request to state change
|
|
* Latency: Local lock request to state change
|
|
* Latency: State change to lock grant
|
|
* Correctness: Ordering of local lock state vs. I/O requests
|
|
* Correctness: Responses to remote demote requests
|
|
*/
|
|
|
|
/* General glock state change (DLM lock request completes) */
|
|
TRACE_EVENT(gfs2_glock_state_change,
|
|
|
|
TP_PROTO(const struct gfs2_glock *gl, unsigned int new_state),
|
|
|
|
TP_ARGS(gl, new_state),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__field( u64, glnum )
|
|
__field( u32, gltype )
|
|
__field( u8, cur_state )
|
|
__field( u8, new_state )
|
|
__field( u8, dmt_state )
|
|
__field( u8, tgt_state )
|
|
__field( unsigned long, flags )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = gl->gl_sbd->sd_vfs->s_dev;
|
|
__entry->glnum = gl->gl_name.ln_number;
|
|
__entry->gltype = gl->gl_name.ln_type;
|
|
__entry->cur_state = glock_trace_state(gl->gl_state);
|
|
__entry->new_state = glock_trace_state(new_state);
|
|
__entry->tgt_state = glock_trace_state(gl->gl_target);
|
|
__entry->dmt_state = glock_trace_state(gl->gl_demote_state);
|
|
__entry->flags = gl->gl_flags;
|
|
),
|
|
|
|
TP_printk("%u,%u glock %d:%lld state %s to %s tgt:%s dmt:%s flags:%s",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev), __entry->gltype,
|
|
(unsigned long long)__entry->glnum,
|
|
glock_trace_name(__entry->cur_state),
|
|
glock_trace_name(__entry->new_state),
|
|
glock_trace_name(__entry->tgt_state),
|
|
glock_trace_name(__entry->dmt_state),
|
|
show_glock_flags(__entry->flags))
|
|
);
|
|
|
|
/* State change -> unlocked, glock is being deallocated */
|
|
TRACE_EVENT(gfs2_glock_put,
|
|
|
|
TP_PROTO(const struct gfs2_glock *gl),
|
|
|
|
TP_ARGS(gl),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__field( u64, glnum )
|
|
__field( u32, gltype )
|
|
__field( u8, cur_state )
|
|
__field( unsigned long, flags )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = gl->gl_sbd->sd_vfs->s_dev;
|
|
__entry->gltype = gl->gl_name.ln_type;
|
|
__entry->glnum = gl->gl_name.ln_number;
|
|
__entry->cur_state = glock_trace_state(gl->gl_state);
|
|
__entry->flags = gl->gl_flags;
|
|
),
|
|
|
|
TP_printk("%u,%u glock %d:%lld state %s => %s flags:%s",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev),
|
|
__entry->gltype, (unsigned long long)__entry->glnum,
|
|
glock_trace_name(__entry->cur_state),
|
|
glock_trace_name(DLM_LOCK_IV),
|
|
show_glock_flags(__entry->flags))
|
|
|
|
);
|
|
|
|
/* Callback (local or remote) requesting lock demotion */
|
|
TRACE_EVENT(gfs2_demote_rq,
|
|
|
|
TP_PROTO(const struct gfs2_glock *gl),
|
|
|
|
TP_ARGS(gl),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__field( u64, glnum )
|
|
__field( u32, gltype )
|
|
__field( u8, cur_state )
|
|
__field( u8, dmt_state )
|
|
__field( unsigned long, flags )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = gl->gl_sbd->sd_vfs->s_dev;
|
|
__entry->gltype = gl->gl_name.ln_type;
|
|
__entry->glnum = gl->gl_name.ln_number;
|
|
__entry->cur_state = glock_trace_state(gl->gl_state);
|
|
__entry->dmt_state = glock_trace_state(gl->gl_demote_state);
|
|
__entry->flags = gl->gl_flags;
|
|
),
|
|
|
|
TP_printk("%u,%u glock %d:%lld demote %s to %s flags:%s",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev), __entry->gltype,
|
|
(unsigned long long)__entry->glnum,
|
|
glock_trace_name(__entry->cur_state),
|
|
glock_trace_name(__entry->dmt_state),
|
|
show_glock_flags(__entry->flags))
|
|
|
|
);
|
|
|
|
/* Promotion/grant of a glock */
|
|
TRACE_EVENT(gfs2_promote,
|
|
|
|
TP_PROTO(const struct gfs2_holder *gh, int first),
|
|
|
|
TP_ARGS(gh, first),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__field( u64, glnum )
|
|
__field( u32, gltype )
|
|
__field( int, first )
|
|
__field( u8, state )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = gh->gh_gl->gl_sbd->sd_vfs->s_dev;
|
|
__entry->glnum = gh->gh_gl->gl_name.ln_number;
|
|
__entry->gltype = gh->gh_gl->gl_name.ln_type;
|
|
__entry->first = first;
|
|
__entry->state = glock_trace_state(gh->gh_state);
|
|
),
|
|
|
|
TP_printk("%u,%u glock %u:%llu promote %s %s",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev), __entry->gltype,
|
|
(unsigned long long)__entry->glnum,
|
|
__entry->first ? "first": "other",
|
|
glock_trace_name(__entry->state))
|
|
);
|
|
|
|
/* Queue/dequeue a lock request */
|
|
TRACE_EVENT(gfs2_glock_queue,
|
|
|
|
TP_PROTO(const struct gfs2_holder *gh, int queue),
|
|
|
|
TP_ARGS(gh, queue),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__field( u64, glnum )
|
|
__field( u32, gltype )
|
|
__field( int, queue )
|
|
__field( u8, state )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = gh->gh_gl->gl_sbd->sd_vfs->s_dev;
|
|
__entry->glnum = gh->gh_gl->gl_name.ln_number;
|
|
__entry->gltype = gh->gh_gl->gl_name.ln_type;
|
|
__entry->queue = queue;
|
|
__entry->state = glock_trace_state(gh->gh_state);
|
|
),
|
|
|
|
TP_printk("%u,%u glock %u:%llu %squeue %s",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev), __entry->gltype,
|
|
(unsigned long long)__entry->glnum,
|
|
__entry->queue ? "" : "de",
|
|
glock_trace_name(__entry->state))
|
|
);
|
|
|
|
/* Section 2 - Log/journal
|
|
*
|
|
* Objectives:
|
|
* Latency: Log flush time
|
|
* Correctness: pin/unpin vs. disk I/O ordering
|
|
* Performance: Log usage stats
|
|
*/
|
|
|
|
/* Pin/unpin a block in the log */
|
|
TRACE_EVENT(gfs2_pin,
|
|
|
|
TP_PROTO(const struct gfs2_bufdata *bd, int pin),
|
|
|
|
TP_ARGS(bd, pin),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__field( int, pin )
|
|
__field( u32, len )
|
|
__field( sector_t, block )
|
|
__field( u64, ino )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = bd->bd_gl->gl_sbd->sd_vfs->s_dev;
|
|
__entry->pin = pin;
|
|
__entry->len = bd->bd_bh->b_size;
|
|
__entry->block = bd->bd_bh->b_blocknr;
|
|
__entry->ino = bd->bd_gl->gl_name.ln_number;
|
|
),
|
|
|
|
TP_printk("%u,%u log %s %llu/%lu inode %llu",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev),
|
|
__entry->pin ? "pin" : "unpin",
|
|
(unsigned long long)__entry->block,
|
|
(unsigned long)__entry->len,
|
|
(unsigned long long)__entry->ino)
|
|
);
|
|
|
|
/* Flushing the log */
|
|
TRACE_EVENT(gfs2_log_flush,
|
|
|
|
TP_PROTO(const struct gfs2_sbd *sdp, int start),
|
|
|
|
TP_ARGS(sdp, start),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__field( int, start )
|
|
__field( u64, log_seq )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = sdp->sd_vfs->s_dev;
|
|
__entry->start = start;
|
|
__entry->log_seq = sdp->sd_log_sequence;
|
|
),
|
|
|
|
TP_printk("%u,%u log flush %s %llu",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev),
|
|
__entry->start ? "start" : "end",
|
|
(unsigned long long)__entry->log_seq)
|
|
);
|
|
|
|
/* Reserving/releasing blocks in the log */
|
|
TRACE_EVENT(gfs2_log_blocks,
|
|
|
|
TP_PROTO(const struct gfs2_sbd *sdp, int blocks),
|
|
|
|
TP_ARGS(sdp, blocks),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__field( int, blocks )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = sdp->sd_vfs->s_dev;
|
|
__entry->blocks = blocks;
|
|
),
|
|
|
|
TP_printk("%u,%u log reserve %d", MAJOR(__entry->dev),
|
|
MINOR(__entry->dev), __entry->blocks)
|
|
);
|
|
|
|
/* Section 3 - bmap
|
|
*
|
|
* Objectives:
|
|
* Latency: Bmap request time
|
|
* Performance: Block allocator tracing
|
|
* Correctness: Test of disard generation vs. blocks allocated
|
|
*/
|
|
|
|
/* Map an extent of blocks, possibly a new allocation */
|
|
TRACE_EVENT(gfs2_bmap,
|
|
|
|
TP_PROTO(const struct gfs2_inode *ip, const struct buffer_head *bh,
|
|
sector_t lblock, int create, int errno),
|
|
|
|
TP_ARGS(ip, bh, lblock, create, errno),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__field( sector_t, lblock )
|
|
__field( sector_t, pblock )
|
|
__field( u64, inum )
|
|
__field( unsigned long, state )
|
|
__field( u32, len )
|
|
__field( int, create )
|
|
__field( int, errno )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = ip->i_gl->gl_sbd->sd_vfs->s_dev;
|
|
__entry->lblock = lblock;
|
|
__entry->pblock = buffer_mapped(bh) ? bh->b_blocknr : 0;
|
|
__entry->inum = ip->i_no_addr;
|
|
__entry->state = bh->b_state;
|
|
__entry->len = bh->b_size;
|
|
__entry->create = create;
|
|
__entry->errno = errno;
|
|
),
|
|
|
|
TP_printk("%u,%u bmap %llu map %llu/%lu to %llu flags:%08lx %s %d",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev),
|
|
(unsigned long long)__entry->inum,
|
|
(unsigned long long)__entry->lblock,
|
|
(unsigned long)__entry->len,
|
|
(unsigned long long)__entry->pblock,
|
|
__entry->state, __entry->create ? "create " : "nocreate",
|
|
__entry->errno)
|
|
);
|
|
|
|
/* Keep track of blocks as they are allocated/freed */
|
|
TRACE_EVENT(gfs2_block_alloc,
|
|
|
|
TP_PROTO(const struct gfs2_inode *ip, u64 block, unsigned len,
|
|
u8 block_state),
|
|
|
|
TP_ARGS(ip, block, len, block_state),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( dev_t, dev )
|
|
__field( u64, start )
|
|
__field( u64, inum )
|
|
__field( u32, len )
|
|
__field( u8, block_state )
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->dev = ip->i_gl->gl_sbd->sd_vfs->s_dev;
|
|
__entry->start = block;
|
|
__entry->inum = ip->i_no_addr;
|
|
__entry->len = len;
|
|
__entry->block_state = block_state;
|
|
),
|
|
|
|
TP_printk("%u,%u bmap %llu alloc %llu/%lu %s",
|
|
MAJOR(__entry->dev), MINOR(__entry->dev),
|
|
(unsigned long long)__entry->inum,
|
|
(unsigned long long)__entry->start,
|
|
(unsigned long)__entry->len,
|
|
block_state_name(__entry->block_state))
|
|
);
|
|
|
|
#endif /* _TRACE_GFS2_H */
|
|
|
|
/* This part must be outside protection */
|
|
#undef TRACE_INCLUDE_PATH
|
|
#define TRACE_INCLUDE_PATH .
|
|
#define TRACE_INCLUDE_FILE trace_gfs2
|
|
#include <trace/define_trace.h>
|
|
|