mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-25 18:30:06 +00:00
![Sven Eckelmann](/assets/img/avatar_default.png)
It is easier to understand that the returned value of a specific function doesn't have to be 0 when the functions was successful when the actual return type is bool. This is especially true when all surrounding functions with return type int use negative values to return the error code. Reported-by: Nicholas Krause <xerofoify@gmail.com> Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch> Signed-off-by: Antonio Quartulli <a@unstable.cc>
62 lines
1.9 KiB
C
62 lines
1.9 KiB
C
/* Copyright (C) 2006-2016 B.A.T.M.A.N. contributors:
|
|
*
|
|
* Simon Wunderlich, Marek Lindner
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of version 2 of the GNU General Public
|
|
* License as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef _NET_BATMAN_ADV_BITARRAY_H_
|
|
#define _NET_BATMAN_ADV_BITARRAY_H_
|
|
|
|
#include "main.h"
|
|
|
|
#include <linux/bitops.h>
|
|
#include <linux/compiler.h>
|
|
#include <linux/stddef.h>
|
|
#include <linux/types.h>
|
|
|
|
/**
|
|
* batadv_test_bit - check if bit is set in the current window
|
|
*
|
|
* @seq_bits: pointer to the sequence number receive packet
|
|
* @last_seqno: latest sequence number in seq_bits
|
|
* @curr_seqno: sequence number to test for
|
|
*
|
|
* Return: true if the corresponding bit in the given seq_bits indicates true
|
|
* and curr_seqno is within range of last_seqno. Otherwise returns false.
|
|
*/
|
|
static inline bool batadv_test_bit(const unsigned long *seq_bits,
|
|
u32 last_seqno, u32 curr_seqno)
|
|
{
|
|
s32 diff;
|
|
|
|
diff = last_seqno - curr_seqno;
|
|
if (diff < 0 || diff >= BATADV_TQ_LOCAL_WINDOW_SIZE)
|
|
return false;
|
|
return test_bit(diff, seq_bits) != 0;
|
|
}
|
|
|
|
/* turn corresponding bit on, so we can remember that we got the packet */
|
|
static inline void batadv_set_bit(unsigned long *seq_bits, s32 n)
|
|
{
|
|
/* if too old, just drop it */
|
|
if (n < 0 || n >= BATADV_TQ_LOCAL_WINDOW_SIZE)
|
|
return;
|
|
|
|
set_bit(n, seq_bits); /* turn the position on */
|
|
}
|
|
|
|
bool batadv_bit_get_packet(void *priv, unsigned long *seq_bits,
|
|
s32 seq_num_diff, int set_mark);
|
|
|
|
#endif /* _NET_BATMAN_ADV_BITARRAY_H_ */
|